Skip to content

Port signbit to structured kernel #57936

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
Kiyosora wants to merge 2 commits into from
Closed

Port signbit to structured kernel #57936

Kiyosora wants to merge 2 commits into from

Conversation

@Kiyosora
Copy link
Contributor

@Kiyosora Kiyosora commented May 10, 2021

Port signbit to structured kernel
Related #55070

@facebook-github-bot
Copy link
Contributor

facebook-github-bot commented May 10, 2021 •
edited
Loading

💊 CI failures summary and remediations

As of commit 2b1d18a (more details on the Dr. CI page and at hud.pytorch.org/pr/57936):

  • 1/1 failures introduced in this PR

🕵️ 1 new failure recognized by patterns

The following CI failures do not appear to be due to upstream breakages:

See CircleCI build pytorch_macos_10_13_py3_test (1/1)

Step: "Test" (full log | diagnosis details | 🔁 rerun)

Jul 19 16:23:04 RuntimeError: test_dataloader failed! 
Jul 19 16:23:04 Generated XML report: test-reports/python-unittest/test_dataloader/TEST-TestNamedTupleDataLoader-20210719161917.xml
Jul 19 16:23:04 Generated XML report: test-reports/python-unittest/test_dataloader/TEST-TestTensorDataset-20210719161917.xml
Jul 19 16:23:04 Generated XML report: test-reports/python-unittest/test_dataloader/TEST-TestCustomPinFn-20210719161917.xml
Jul 19 16:23:04 Generated XML report: test-reports/python-unittest/test_dataloader/TEST-TestSetAffinity-20210719161917.xml
Jul 19 16:23:04 Generated XML report: test-reports/python-unittest/test_dataloader/TEST-TestStringDataLoader-20210719161917.xml
Jul 19 16:23:04 Traceback (most recent call last):
Jul 19 16:23:04   File "test/run_test.py", line 1088, in <module>
Jul 19 16:23:04     main()
Jul 19 16:23:04   File "test/run_test.py", line 1067, in main
Jul 19 16:23:04     raise RuntimeError(err_message)
Jul 19 16:23:04 RuntimeError: test_dataloader failed!
Jul 19 16:23:04 + cleanup
Jul 19 16:23:04 + retcode=1
Jul 19 16:23:04 + set +x


Exited with code exit status 1

Preview docs built from this PR

This comment was automatically generated by Dr. CI (expand for details).Follow this link to opt-out of these comments for your Pull Requests.

Please report bugs/suggestions to the (internal) Dr. CI Users group.

Click here to manually regenerate this comment.

@Kiyosora Kiyosora force-pushed the structured_signbit branch 2 times, most recently from 53fd6b4 to aaf5a71 Compare June 29, 2021 15:24
@codecov
Copy link

codecov bot commented Jun 29, 2021 •
edited
Loading

Codecov Report

Merging #57936 (aaf5a71) into master (179b3ab) will increase coverage by 56.23%.
The diff coverage is 84.21%.

❗ Current head aaf5a71 differs from pull request most recent head 502542b. Consider uploading reports for the commit 502542b to get more accurate results

@@             Coverage Diff             @@
##           master   #57936       +/-   ##
===========================================
+ Coverage   19.98%   76.21%   +56.23%     
===========================================
  Files          23     2062     +2039     
  Lines        5224   205583   +200359     
===========================================
+ Hits         1044   156688   +155644     
- Misses       4180    48895    +44715

@ezyang ezyang requested a review from SplitInfinity July 6, 2021 16:40
@SplitInfinity SplitInfinity mentioned this pull request Jul 6, 2021
Closed
@Kiyosora Kiyosora force-pushed the structured_signbit branch 3 times, most recently from 53ad032 to 502542b Compare July 8, 2021 06:24
@Kiyosora Kiyosora changed the title [WIP] Port signbit to structured kernel Port signbit to structured kernel Jul 8, 2021
@Kiyosora Kiyosora changed the title Port signbit to structured kernel Port signbit to structured kernel Jul 8, 2021
@Kiyosora Kiyosora marked this pull request as ready for review July 8, 2021 10:36
@Kiyosora Kiyosora requested a review from ezyang as a code owner July 8, 2021 10:36
@iramazanli iramazanli added the triaged This issue has been looked at a team member, and triaged and prioritized into an appropriate module label Jul 8, 2021
@Kiyosora Kiyosora force-pushed the structured_signbit branch 2 times, most recently from 662e934 to a9af733 Compare July 10, 2021 08:58
@Kiyosora Kiyosora force-pushed the structured_signbit branch from a9af733 to b9662d8 Compare July 16, 2021 04:46
@facebook-github-bot
Copy link
Contributor

facebook-github-bot commented Jul 19, 2021

@ezyang has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

ezyang
ezyang reviewed Jul 19, 2021
View reviewed changes
@facebook-github-bot
Copy link
Contributor

facebook-github-bot commented Jul 19, 2021

@ezyang has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

@facebook-github-bot
Copy link
Contributor

facebook-github-bot commented Jul 19, 2021

@ezyang merged this pull request in 43c5dc4.

@Kiyosora Kiyosora deleted the structured_signbit branch July 20, 2021 01:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ezyang ezyang ezyang approved these changes

@SplitInfinity SplitInfinity Awaiting requested review from SplitInfinity

Assignees

No one assigned

Labels

cla signed Merged open source triaged This issue has been looked at a team member, and triaged and prioritized into an appropriate module

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@Kiyosora @facebook-github-bot @ezyang @pytorchbot @iramazanli