port mm to structure kernel #57755
port mm to structure kernel #57755
Conversation
facebook-github-bot
added
oncall: jit
💊 CI failures summary and remediationsAs of commit 128fcbb (more details on the Dr. CI page): 💚 💚 Looks good so far! There are no failures yet. 💚 💚 This comment was automatically generated by Dr. CI (expand for details).Follow this link to opt-out of these comments for your Pull Requests.Please report bugs/suggestions to the (internal) Dr. CI Users group. |
walterddr
force-pushed
the
structure_kernel_mm
branch
from
81372d7 to
e461b18
Compare
|
@walterddr has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator. |
test/test_nn.py
Outdated
There was a problem hiding this comment.
The changes here look a little questionable. I think we want it to be possible to stream inputs through modules, in general, so you should keep calling the m(input) (and maybe put some asserts on them). So instead of removing the m(input) call entirely, if they are now passing, you should keep calling them to exercise.
There was a problem hiding this comment.
nit: don't need to explicitly cast the initializer list to IntArrayRef, there's an implicit conversion
There was a problem hiding this comment.
Delete the resize_ here, it's always a noop
ezyang
left a comment
ezyang
left a comment
There was a problem hiding this comment.
some minor fixes, thanks for doing this
walterddr
force-pushed
the
structure_kernel_mm
branch
2 times, most recently
from
8991514 to
26da71a
Compare
|
@walterddr has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator. |
walterddr
force-pushed
the
structure_kernel_mm
branch
from
26da71a to
128fcbb
Compare
|
@walterddr has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator. |
|
@walterddr merged this pull request in c1c9be1. |
3 participants
relate to #57417.