maximum and minimum: port to structured
#57630
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
[ghstack-poisoned]
This was referenced May 5, 2021
Contributor
💊 CI failures summary and remediationsAs of commit 1636a32 (more details on the Dr. CI page):
This comment was automatically generated by Dr. CI (expand for details).Follow this link to opt-out of these comments for your Pull Requests.Please report bugs/suggestions to the (internal) Dr. CI Users group. |
ezyang
approved these changes
May 5, 2021
Contributor
|
@ezyang has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator. |
Contributor
|
Differential Revision: [D28224831](https://our.internmc.facebook.com/intern/diff/D28224831) [ghstack-poisoned]
Contributor
|
I'm not convinced by the new change. How come it wasn't necessary to test if it was complex in the old version of the code? |
Contributor
|
@ezyang has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator. |
Contributor
Contributor
Author
Sorry for the late reply. Older versions of the code did not need this because it skipped the meta-test. The meta-test was performed after porting to the structured kernel |
krshrimali
pushed a commit
to krshrimali/pytorch
that referenced
this pull request
May 19, 2021
Summary: Pull Request resolved: pytorch#57630 Test Plan: Imported from OSS Reviewed By: VitalyFedyunin Differential Revision: D28224831 Pulled By: ezyang fbshipit-source-id: de4c40560613b68473aa53bb7424476dc558a6b2
bdhirsh
changed the title
maximum and minimum: port to structured
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack from ghstack:
maximumandminimum: port to structured #57630 Port maximum and minimum to structuredlogaddexpandlogaddexp2: port to structured #57629 Port logaddexp and logaddexp2 to structuredlcm: port to structured #57628 Port lcm to structuredhypot: port to structured #57627 Port hypot to structuredigammaandigammac: port to structured #57626 Port igamma and igammac to structurednextafter: port to structured #57625 Port nextafter to structuredgcd: port to structured #57624 Port gcd to structuredDifferential Revision: D28224831