Skip to content

softplus: port to structured #57620

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
Freey0 wants to merge 3 commits into from
Closed

softplus: port to structured #57620

Freey0 wants to merge 3 commits into from

Conversation

@Freey0
Copy link
Contributor

@Freey0 Freey0 commented May 5, 2021 •
edited
Loading

Stack from ghstack:

Differential Revision: D28224705

@Freey0
Port softplus to structured
6f4e42f 
[ghstack-poisoned]
@Freey0 Freey0 requested a review from ezyang as a code owner May 5, 2021 14:08
@facebook-github-bot
Copy link
Contributor

facebook-github-bot commented May 5, 2021 •
edited
Loading

💊 CI failures summary and remediations

As of commit 5e191fe (more details on the Dr. CI page):

🕵️ 1 new failure recognized by patterns

The following CI failures do not appear to be due to upstream breakages:

See CircleCI build pytorch_linux_bionic_cuda10_2_cudnn7_py3_9_gcc7_test1 (1/1)

Step: "Run tests" (full log | diagnosis details | 🔁 rerun)

May 13 18:15:28 AssertionError: False is not tr...lowed difference with rtol=0 and atol=0 is only 0! 
May 13 18:15:28 ----------------------------------------------------------------------
May 13 18:15:28 Traceback (most recent call last):
May 13 18:15:28   File "/opt/conda/lib/python3.9/site-packages/torch/testing/_internal/common_distributed.py", line 391, in wrapper
May 13 18:15:28     self._join_processes(fn)
May 13 18:15:28   File "/opt/conda/lib/python3.9/site-packages/torch/testing/_internal/common_distributed.py", line 583, in _join_processes
May 13 18:15:28     self._check_return_codes(elapsed_time)
May 13 18:15:28   File "/opt/conda/lib/python3.9/site-packages/torch/testing/_internal/common_distributed.py", line 632, in _check_return_codes
May 13 18:15:28     self.assertEqual(
May 13 18:15:28   File "/opt/conda/lib/python3.9/site-packages/torch/testing/_internal/common_utils.py", line 1400, in assertEqual
May 13 18:15:28     super().assertTrue(result, msg=self._get_assert_msg(msg, debug_msg=debug_msg))
May 13 18:15:28 AssertionError: False is not true : Scalars failed to compare as equal! Comparing 1 and -11 gives a difference of 12, but the allowed difference with rtol=0 and atol=0 is only 0!
May 13 18:15:28 Expect process 1 exit code to match Process 0 exit code of -11, but got 1
May 13 18:15:28 
May 13 18:15:28 ----------------------------------------------------------------------
May 13 18:15:28 Ran 210 tests in 236.605s
May 13 18:15:28 
May 13 18:15:28 FAILED (failures=1, skipped=119)
May 13 18:15:28 
May 13 18:15:28 Generating XML reports...
May 13 18:15:28 Generated XML report: test-reports/dist-nccl/.var.lib.jenkins.workspace.test.distributed.test_distributed_fork/TEST-TestDistBackendWithFork-20210513181132.xml
May 13 18:15:28 Traceback (most recent call last):

❄️ 1 failure tentatively classified as flaky

but reruns have not yet been triggered to confirm:

See CircleCI build pytorch_linux_bionic_cuda10_2_cudnn7_py3_9_gcc7_test2 (1/1)

Step: "Run tests" (full log | diagnosis details | 🔁 rerun) ❄️

May 13 19:30:38 unknown file: Failure 
May 13 19:30:34 [       OK ] NVFuserTest.FusionBCastConcretizeRfactor_CUDA (0 ms)
May 13 19:30:34 [ RUN      ] NVFuserTest.FusionProveIdEqBasic_CUDA
May 13 19:30:34 [       OK ] NVFuserTest.FusionProveIdEqBasic_CUDA (0 ms)
May 13 19:30:34 [ RUN      ] NVFuserTest.FusionProveIdEqRfactor_CUDA
May 13 19:30:34 [       OK ] NVFuserTest.FusionProveIdEqRfactor_CUDA (0 ms)
May 13 19:30:34 [ RUN      ] NVFuserTest.FusionScalarInputs_CUDA
May 13 19:30:34 [       OK ] NVFuserTest.FusionScalarInputs_CUDA (294 ms)
May 13 19:30:34 [ RUN      ] NVFuserTest.FusionLoopUnroll_CUDA
May 13 19:30:34 [       OK ] NVFuserTest.FusionLoopUnroll_CUDA (364 ms)
May 13 19:30:34 [ RUN      ] NVFuserTest.FusionUnaryOps_CUDA
May 13 19:30:38 unknown file: Failure
May 13 19:30:38 C++ exception with description "
May 13 19:30:38 Op Type: -- round -- had a mismatch.
May 13 19:30:38 INPUT1: Columns 1 to 10 0.4852  0.4112  0.0529  0.5997  0.1347  0.6508  0.5927  0.9420  0.2030  0.6239
May 13 19:30:38  0.1112  0.8680  0.0131  0.6388  0.4174  0.1038  0.7993  0.8163  0.8541  0.9687
May 13 19:30:38  0.0045  0.1650  0.1775  0.7901  0.8339  0.5491  0.8707  0.2313  0.7615  0.1381
May 13 19:30:38  0.2704  0.3351  0.0885  0.1749  0.4581  0.9206  0.8274  0.2172  0.4180  0.8094
May 13 19:30:38  0.6806  0.4080  0.8701  0.4192  0.9581  0.4249  0.3090  0.5612  0.3764  0.5285
May 13 19:30:38  0.4385  0.0676  0.3627  0.4850  0.4324  0.2993  0.7490  0.1289  0.9978  0.2043
May 13 19:30:38  0.6809  0.9754  0.2663  0.5930  0.6713  0.5807  0.2306  0.3232  0.5022  0.1465
May 13 19:30:38  0.3978  0.7175  0.1645  0.7369  0.4772  0.6361  0.6572  0.5026  0.0895  0.1328
This comment was automatically generated by Dr. CI (expand for details).Follow this link to opt-out of these comments for your Pull Requests.

Please report bugs/suggestions to the (internal) Dr. CI Users group.

Click here to manually regenerate this comment.

This was referenced May 5, 2021
Closed
Closed
Closed
Closed
@ezyang
Copy link
Contributor

ezyang commented May 5, 2021

@ezyang has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

@ezyang
Copy link
Contributor

ezyang commented May 5, 2021 

May 05 16:28:13 ======================================================================
May 05 16:28:13 FAIL [0.007s]: test_softplus_inplace_overlap_meta (__main__.TestNNDeviceTypeMETA)
May 05 16:28:13 ----------------------------------------------------------------------
May 05 16:28:13 Traceback (most recent call last):
May 05 16:28:13   File "/opt/conda/lib/python3.6/site-packages/torch/testing/_internal/common_utils.py", line 1030, in wrapper
May 05 16:28:13     method(*args, **kwargs)
May 05 16:28:13   File "/opt/conda/lib/python3.6/site-packages/torch/testing/_internal/common_device_type.py", line 292, in instantiated_test
May 05 16:28:13     result = test_fn(self, *args)
May 05 16:28:13   File "/opt/conda/lib/python3.6/site-packages/torch/testing/_internal/common_device_type.py", line 710, in efail_fn
May 05 16:28:13     slf.fail('expected test to fail, but it passed')
May 05 16:28:13 AssertionError: expected test to fail, but it passed
May 05 16:28:13

@Freey0 Freey0 mentioned this pull request May 11, 2021
Closed
dgl-intel pushed a commit to dgl-intel/pytorch that referenced this pull request May 11, 2021
@Freey0
Port softplus to structured
da7e47b 
ghstack-source-id: 0ae5e90
Pull Request resolved: pytorch#57620
@ezyang
Copy link
Contributor

ezyang commented May 11, 2021

@ezyang has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

1 similar comment
@ezyang
Copy link
Contributor

ezyang commented May 12, 2021

@ezyang has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

@ezyang
Copy link
Contributor

ezyang commented May 13, 2021

@ezyang has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

@facebook-github-bot
Copy link
Contributor

facebook-github-bot commented May 14, 2021

@ezyang merged this pull request in 9dba26e.

@facebook-github-bot facebook-github-bot deleted the gh/Feey0/5/head branch May 17, 2021 14:17
krshrimali pushed a commit to krshrimali/pytorch that referenced this pull request May 19, 2021
@Freey0
Port softplus to structured (pytorch#57620)
fe0786f 
Summary: Pull Request resolved: pytorch#57620

Test Plan: Imported from OSS

Reviewed By: VitalyFedyunin

Differential Revision: D28224705

Pulled By: ezyang

fbshipit-source-id: a48419f5958e4d29427fb1fec7ff929f0297e4e4
@bdhirsh bdhirsh changed the title Port softplus to structured softplus: port to structured May 24, 2021
@Freey0 Freey0 mentioned this pull request Jun 1, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ezyang ezyang ezyang approved these changes

Assignees

No one assigned

Labels

cla signed Merged open source

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@Freey0 @facebook-github-bot @ezyang @pytorchbot