Skip to content

elu: port to structured #57619

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
Freey0 wants to merge 3 commits into from
Closed

elu: port to structured #57619

Freey0 wants to merge 3 commits into from

Conversation

@Freey0
Copy link
Contributor

@Freey0 Freey0 commented May 5, 2021 •
edited
Loading

Stack from ghstack:

Differential Revision: D28224707

@Freey0
Port elu to structured
d013cd4 
[ghstack-poisoned]
@Freey0 Freey0 requested a review from ezyang as a code owner May 5, 2021 14:08
@facebook-github-bot
Copy link
Contributor

facebook-github-bot commented May 5, 2021 •
edited
Loading

💊 CI failures summary and remediations

As of commit b3b82c6 (more details on the Dr. CI page):

  • 1/1 failures possibly* introduced in this PR
    • 1/1 non-scanned failure(s)
This comment was automatically generated by Dr. CI (expand for details).Follow this link to opt-out of these comments for your Pull Requests.

Please report bugs/suggestions to the (internal) Dr. CI Users group.

Click here to manually regenerate this comment.

This was referenced May 5, 2021
Closed
Closed
Closed
Closed
@ezyang
Copy link
Contributor

ezyang commented May 5, 2021

@ezyang has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

@ezyang
Copy link
Contributor

ezyang commented May 5, 2021 

May 05 16:25:51 ======================================================================
May 05 16:25:51 FAIL [0.012s]: test_elu_inplace_overlap_meta (__main__.TestNNDeviceTypeMETA)
May 05 16:25:51 ----------------------------------------------------------------------
May 05 16:25:51 Traceback (most recent call last):
May 05 16:25:51   File "/opt/conda/lib/python3.6/site-packages/torch/testing/_internal/common_utils.py", line 1030, in wrapper
May 05 16:25:51     method(*args, **kwargs)
May 05 16:25:51   File "/opt/conda/lib/python3.6/site-packages/torch/testing/_internal/common_device_type.py", line 292, in instantiated_test
May 05 16:25:51     result = test_fn(self, *args)
May 05 16:25:51   File "/opt/conda/lib/python3.6/site-packages/torch/testing/_internal/common_device_type.py", line 710, in efail_fn
May 05 16:25:51     slf.fail('expected test to fail, but it passed')
May 05 16:25:51 AssertionError: expected test to fail, but it passed
May 05 16:25:51

@Freey0 Freey0 mentioned this pull request May 11, 2021
Closed
dgl-intel pushed a commit to dgl-intel/pytorch that referenced this pull request May 11, 2021
@Freey0
Port elu to structured
21b1af0 
ghstack-source-id: 15a8dfa
Pull Request resolved: pytorch#57619
@ezyang
Copy link
Contributor

ezyang commented May 11, 2021

@ezyang has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

1 similar comment
@ezyang
Copy link
Contributor

ezyang commented May 12, 2021

@ezyang has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

@Freey0
Copy link
Contributor Author

Freey0 commented May 13, 2021

Facebook internal test failed, can you help to check it?

@ezyang
Copy link
Contributor

ezyang commented May 13, 2021

you're ok, this one is just flakiness

@ezyang
Copy link
Contributor

ezyang commented May 13, 2021

@ezyang has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

@facebook-github-bot
Copy link
Contributor

facebook-github-bot commented May 14, 2021

@ezyang merged this pull request in 03398b7.

@facebook-github-bot facebook-github-bot deleted the gh/Feey0/4/head branch May 17, 2021 14:17
krshrimali pushed a commit to krshrimali/pytorch that referenced this pull request May 19, 2021
@Freey0
Port elu to structured (pytorch#57619)
65e20b8 
Summary: Pull Request resolved: pytorch#57619

Test Plan: Imported from OSS

Reviewed By: VitalyFedyunin

Differential Revision: D28224707

Pulled By: ezyang

fbshipit-source-id: 9e1cad3f5536c65ada2d951366de134ebcb6bb3f
@bdhirsh bdhirsh changed the title Port elu to structured elu: port to structured May 24, 2021
@Freey0 Freey0 mentioned this pull request Jun 1, 2021
Closed
@jjsjann123 jjsjann123 mentioned this pull request Sep 21, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ezyang ezyang ezyang approved these changes

Assignees

No one assigned

Labels

cla signed Merged open source

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@Freey0 @facebook-github-bot @ezyang @pytorchbot