floor: port to structured
#57587
Closed
floor: port to structured
#57587
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
[ghstack-poisoned]
Contributor
💊 CI failures summary and remediationsAs of commit 894bbc4 (more details on the Dr. CI page):
1 failure not recognized by patterns:
This comment was automatically generated by Dr. CI (expand for details).Follow this link to opt-out of these comments for your Pull Requests.Please report bugs/suggestions to the (internal) Dr. CI Users group. |
This was referenced May 5, 2021
Codecov Report
@@ Coverage Diff @@
## gh/Feey0/1/base #57587 +/- ##
===================================================
- Coverage 76.91% 76.91% -0.01%
===================================================
Files 1968 1968
Lines 196385 196385
===================================================
- Hits 151050 151049 -1
- Misses 45335 45336 +1 |
Contributor
|
@ezyang has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator. |
ezyang
approved these changes
May 5, 2021
Contributor
Author
|
@ezyang , Newbie question, does the failure look irrelevant and do I need to change the base again and wait for the CI to go all green? |
Contributor
|
These are all fine; this was an error on the master you based this set on but it is fixed on master. Don't rebase it will prevent me from landing this set. |
Contributor
mrshenli
pushed a commit
to mrshenli/pytorch
that referenced
this pull request
May 8, 2021
Summary: Pull Request resolved: pytorch#57587 Use ghstack to reopen to reduce self conflict。 Test Plan: Imported from OSS Reviewed By: albanD Differential Revision: D28224599 Pulled By: ezyang fbshipit-source-id: 023f21bc976b90f8a5a409db4f3390aa4eaea446
krshrimali
pushed a commit
to krshrimali/pytorch
that referenced
this pull request
May 19, 2021
Summary: Pull Request resolved: pytorch#57587 Use ghstack to reopen to reduce self conflict。 Test Plan: Imported from OSS Reviewed By: albanD Differential Revision: D28224599 Pulled By: ezyang fbshipit-source-id: 023f21bc976b90f8a5a409db4f3390aa4eaea446
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack from ghstack:
ceil: port to structured #57589 Port ceil to structuredsign: port to structured #57588 Port sign to structuredfloor: port to structured #57587 Port floor to structuredUse ghstack to reopen to reduce self conflict。
Differential Revision: D28224599