.github: Be specific about what to render #57584
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes issues where non-test reports were getting read by the junitparser Signed-off-by: Eli Uriegas <[email protected]> [ghstack-poisoned]
Contributor
💊 CI failures summary and remediationsAs of commit 1ee313d (more details on the Dr. CI page):
1 failure not recognized by patterns:
This comment was automatically generated by Dr. CI (expand for details).Follow this link to opt-out of these comments for your Pull Requests.Please report bugs/suggestions to the (internal) Dr. CI Users group. |
seemethere
added a commit
that referenced
this pull request
May 5, 2021
Fixes issues where non-test reports were getting read by the junitparser Signed-off-by: Eli Uriegas <[email protected]> ghstack-source-id: 4e4ce8e Pull Request resolved: #57584
walterddr
approved these changes
May 5, 2021
Codecov Report
@@ Coverage Diff @@
## gh/seemethere/80/base #57584 +/- ##
======================================================
Coverage 76.91% 76.91%
======================================================
Files 1968 1968
Lines 196385 196385
======================================================
+ Hits 151050 151053 +3
+ Misses 45335 45332 -3 |
malfet
approved these changes
May 5, 2021
7 tasks
facebook-github-bot
pushed a commit
that referenced
this pull request
May 10, 2021
Summary: Judging from #57584, it seems like the test-reports artifact was originally intended to be downloaded to `$PWD/test-reports` instead of just directly into `$PWD`. To minimize confusion, this PR changes it to download into `test/test-reports`, which should match where the files came from in the `test` step anyway. TODOs: - [x] change the extract path for test-reports - [x] install Python dependencies - [x] call `tools/print_test_stats.py` - [x] use deep clone to allow `git` commands - [x] correctly set `CIRCLE_*` environment variables - [x] set Scribe credentials - [x] set AWS credentials Pull Request resolved: #57647 Test Plan: CI. Reviewed By: seemethere Differential Revision: D28325833 Pulled By: samestep fbshipit-source-id: cc322bad76747f59b764a1a0a863153bb26095e7
krshrimali
pushed a commit
to krshrimali/pytorch
that referenced
this pull request
May 19, 2021
Summary: Judging from pytorch#57584, it seems like the test-reports artifact was originally intended to be downloaded to `$PWD/test-reports` instead of just directly into `$PWD`. To minimize confusion, this PR changes it to download into `test/test-reports`, which should match where the files came from in the `test` step anyway. TODOs: - [x] change the extract path for test-reports - [x] install Python dependencies - [x] call `tools/print_test_stats.py` - [x] use deep clone to allow `git` commands - [x] correctly set `CIRCLE_*` environment variables - [x] set Scribe credentials - [x] set AWS credentials Pull Request resolved: pytorch#57647 Test Plan: CI. Reviewed By: seemethere Differential Revision: D28325833 Pulled By: samestep fbshipit-source-id: cc322bad76747f59b764a1a0a863153bb26095e7
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack from ghstack:
Fixes issues where non-test reports were getting read by the junitparser
Signed-off-by: Eli Uriegas [email protected]
Differential Revision: D28210540