Always run as many quick-checks steps as possible #57572
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
💊 CI failures summary and remediationsAs of commit a1fedad (more details on the Dr. CI page): ✅ None of the CI failures appear to be your fault 💚
1 job timed out:
🚧 2 fixed upstream failures:These were probably caused by upstream breakages that were already fixed.
Please rebase on the
|
Contributor
|
@samestep has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator. |
driazati
approved these changes
May 5, 2021
Contributor
krshrimali
pushed a commit
to krshrimali/pytorch
that referenced
this pull request
May 19, 2021
Summary: This is essentially a continuation of pytorch#56700. Currently, some of the steps in **Lint / quick-checks** (such as the trailing newlines check) still don't always run if an earlier steps fail; example: https://github.com/pytorch/pytorch/runs/2504623867 This PR adds some more `if`s to remaining steps, so that they, too, can still run even when earlier steps fail. Pull Request resolved: pytorch#57572 Test Plan: - https://github.com/pytorch/pytorch/runs/2504706736 before this PR, many steps get skipped if an early step fails - https://github.com/pytorch/pytorch/runs/2504778437 using this PR's technique, those steps still run - https://github.com/pytorch/pytorch/runs/2504787234 if the requirements step doesn't run, steps still get skipped - https://github.com/pytorch/pytorch/runs/2504796695 after this PR, `quick-checks` still succeeds Reviewed By: driazati Differential Revision: D28205900 Pulled By: samestep fbshipit-source-id: bea856e15bdd17ee66e9ebba019ce91133b17bcd
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is essentially a continuation of #56700. Currently, some of the steps in Lint / quick-checks (such as the trailing newlines check) still don't always run if an earlier steps fail; example: https://github.com/pytorch/pytorch/runs/2504623867
This PR adds some more
ifs to remaining steps, so that they, too, can still run even when earlier steps fail.Test plan:
quick-checksstill succeeds