Skip to content

neg: port to structure kernel #57212

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
walterddr wants to merge 1 commit into from
Closed

neg: port to structure kernel #57212

walterddr wants to merge 1 commit into from

Conversation

@walterddr
Copy link
Contributor

@walterddr walterddr commented Apr 28, 2021

negative alias is not ported.

@walterddr walterddr requested a review from ezyang as a code owner April 28, 2021 23:05
@facebook-github-bot
Copy link
Contributor

facebook-github-bot commented Apr 28, 2021 •
edited
Loading

💊 CI failures summary and remediations

As of commit d9278d2 (more details on the Dr. CI page):

1 failure not recognized by patterns:

Job Step Action
CircleCI pytorch_linux_xenial_cuda10_2_cudnn7_py3_gcc7_test2 Run tests 🔁 rerun

1 job timed out:

  • pytorch_linux_xenial_cuda10_2_cudnn7_py3_gcc7_test2

❄️ 1 failure tentatively classified as flaky

but reruns have not yet been triggered to confirm:

See CircleCI build pytorch_xla_linux_bionic_py3_6_clang9_test (1/1)

Step: "Run tests" (full log | diagnosis details | 🔁 rerun) ❄️

Apr 29 16:57:37 RuntimeError: tensorflow/compil...OK() (Unknown: Could not start gRPC server vs. OK) 
Apr 29 16:57:37   File "/opt/conda/lib/python3.6/site-packages/torch_xla-1.9-py3.6-linux-x86_64.egg/torch_xla/distributed/xla_multiprocessing.py", line 314, in _setup_replication
Apr 29 16:57:37     device = xm.xla_device()
Apr 29 16:57:37   File "/opt/conda/lib/python3.6/site-packages/torch_xla-1.9-py3.6-linux-x86_64.egg/torch_xla/core/xla_model.py", line 231, in xla_device
Apr 29 16:57:37     devkind=devkind if devkind is not None else None)
Apr 29 16:57:37   File "/opt/conda/lib/python3.6/site-packages/torch_xla-1.9-py3.6-linux-x86_64.egg/torch_xla/core/xla_model.py", line 136, in get_xla_supported_devices
Apr 29 16:57:37     xla_devices = _DEVICES.value
Apr 29 16:57:37   File "/opt/conda/lib/python3.6/site-packages/torch_xla-1.9-py3.6-linux-x86_64.egg/torch_xla/utils/utils.py", line 32, in value
Apr 29 16:57:37     self._value = self._gen_fn()
Apr 29 16:57:37   File "/opt/conda/lib/python3.6/site-packages/torch_xla-1.9-py3.6-linux-x86_64.egg/torch_xla/core/xla_model.py", line 18, in <lambda>
Apr 29 16:57:37     _DEVICES = xu.LazyProperty(lambda: torch_xla._XLAC._xla_get_devices())
Apr 29 16:57:37 RuntimeError: tensorflow/compiler/xla/xla_client/xrt_local_service.cc:56 : Check failed: tensorflow::NewServer(server_def, &server_) == ::tensorflow::Status::OK() (Unknown: Could not start gRPC server vs. OK)
Apr 29 16:57:37 Traceback (most recent call last):
Apr 29 16:57:37   File "/var/lib/jenkins/workspace/xla/test/test_mp_mesh_reduce.py", line 35, in <module>
Apr 29 16:57:37     xmp.spawn(_mp_fn, args=())
Apr 29 16:57:37   File "/opt/conda/lib/python3.6/site-packages/torch_xla-1.9-py3.6-linux-x86_64.egg/torch_xla/distributed/xla_multiprocessing.py", line 394, in spawn
Apr 29 16:57:37     start_method=start_method)
Apr 29 16:57:37   File "/opt/conda/lib/python3.6/site-packages/torch/multiprocessing/spawn.py", line 188, in start_processes
Apr 29 16:57:37     while not context.join():
Apr 29 16:57:37   File "/opt/conda/lib/python3.6/site-packages/torch/multiprocessing/spawn.py", line 144, in join
Apr 29 16:57:37     exit_code=exitcode
Apr 29 16:57:37 torch.multiprocessing.spawn.ProcessExitedException: process 0 terminated with exit code 17
This comment was automatically generated by Dr. CI (expand for details).Follow this link to opt-out of these comments for your Pull Requests.

Please report bugs/suggestions to the (internal) Dr. CI Users group.

Click here to manually regenerate this comment.

walterddr
walterddr commented Apr 28, 2021
View reviewed changes
Initial commit to support structure neg
d9278d2 
- added sparse support dispatch
- move check to meta
- negative alias is not working
@walterddr walterddr force-pushed the structure_kernel_neg branch from 3de0de4 to d9278d2 Compare April 29, 2021 14:09
ezyang
ezyang approved these changes Apr 29, 2021
View reviewed changes
Copy link
Contributor

@ezyang ezyang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thankee

@facebook-github-bot
Copy link
Contributor

facebook-github-bot commented Apr 29, 2021

@walterddr has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

@samestep samestep mentioned this pull request Apr 29, 2021
Closed
@facebook-github-bot
Copy link
Contributor

facebook-github-bot commented Apr 29, 2021

@walterddr merged this pull request in 16fc18b.

krshrimali pushed a commit to krshrimali/pytorch that referenced this pull request May 19, 2021
port neg to structure kernel (pytorch#57212)
bc12b9f 
Summary:
`negative` alias is not ported.

Pull Request resolved: pytorch#57212

Reviewed By: driazati

Differential Revision: D28095043

Pulled By: walterddr

fbshipit-source-id: 6c7bcd727800bb1db7add43a152de7b58f4ccf43
@bdhirsh bdhirsh changed the title port neg to structure kernel neg: port to structure kernel May 24, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ezyang ezyang ezyang approved these changes

Assignees

No one assigned

Labels

cla signed Merged

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@walterddr @facebook-github-bot @ezyang