torch: Add cpython as a dependency for torch_python_obj #56740
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Was running into a race condition where the torch_python_obj was attempting to build before cpython was actually finished installing, this should resolve that issue. Only applicable on builds that use the `USE_DEPLOY=ON` option Signed-off-by: Eli Uriegas <[email protected]> [ghstack-poisoned]
This was referenced Apr 22, 2021
Contributor
💊 CI failures summary and remediationsAs of commit 6bb9489 (more details on the Dr. CI page):
🕵️ 1 new failure recognized by patternsThe following CI failures do not appear to be due to upstream breakages:
|
seemethere
added
module: build
wconstab
approved these changes
Apr 22, 2021
malfet
approved these changes
Apr 22, 2021
Contributor
|
@seemethere merged this pull request in 08ce230. |
krshrimali
pushed a commit
to krshrimali/pytorch
that referenced
this pull request
May 19, 2021
Summary: Pull Request resolved: pytorch#56740 Was running into a race condition where the torch_python_obj was attempting to build before cpython was actually finished installing, this should resolve that issue. Only applicable on builds that use the `USE_DEPLOY=ON` option Signed-off-by: Eli Uriegas <[email protected]> Test Plan: Imported from OSS Reviewed By: malfet Differential Revision: D27953782 Pulled By: seemethere fbshipit-source-id: 76dd7c4218870eac97fc4c14e20b46128d264b30
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack from ghstack:
Was running into a race condition where the torch_python_obj was
attempting to build before cpython was actually finished installing,
this should resolve that issue.
Only applicable on builds that use the
USE_DEPLOY=ONoptionSigned-off-by: Eli Uriegas [email protected]
Differential Revision: D27953782