Always run all the grep-based quick-checks steps #56700
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
💊 CI failures summary and remediationsAs of commit 654b204 (more details on the Dr. CI page):
1 failure not recognized by patterns:
This comment was automatically generated by Dr. CI (expand for details).Follow this link to opt-out of these comments for your Pull Requests.Please report bugs/suggestions to the (internal) Dr. CI Users group. |
Contributor
|
@samestep has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator. |
walterddr
approved these changes
Apr 22, 2021
Contributor
|
bravo. explosed some more quick check errors. plz fix them in the same PR? |
Contributor
Author
@walterddr I'm not fixing them in this PR because they're already being fixed by #56692, which is landing right now. |
Contributor
sounds good! maybe rebase after #56692 landed to retrigger quick check ? |
Contributor
Author
janeyx99
approved these changes
Apr 22, 2021
Contributor
Contributor
Author
|
Contributor
facebook-github-bot
pushed a commit
that referenced
this pull request
May 5, 2021
Summary: This is essentially a continuation of #56700. Currently, some of the steps in **Lint / quick-checks** (such as the trailing newlines check) still don't always run if an earlier steps fail; example: https://github.com/pytorch/pytorch/runs/2504623867 This PR adds some more `if`s to remaining steps, so that they, too, can still run even when earlier steps fail. Pull Request resolved: #57572 Test Plan: - https://github.com/pytorch/pytorch/runs/2504706736 before this PR, many steps get skipped if an early step fails - https://github.com/pytorch/pytorch/runs/2504778437 using this PR's technique, those steps still run - https://github.com/pytorch/pytorch/runs/2504787234 if the requirements step doesn't run, steps still get skipped - https://github.com/pytorch/pytorch/runs/2504796695 after this PR, `quick-checks` still succeeds Reviewed By: driazati Differential Revision: D28205900 Pulled By: samestep fbshipit-source-id: bea856e15bdd17ee66e9ebba019ce91133b17bcd
krshrimali
pushed a commit
to krshrimali/pytorch
that referenced
this pull request
May 19, 2021
Summary: Pull Request resolved: pytorch#56700 Reviewed By: walterddr Differential Revision: D27940638 Pulled By: samestep fbshipit-source-id: 54311ef45ec051ee29d934d501e83b3542bbb439
krshrimali
pushed a commit
to krshrimali/pytorch
that referenced
this pull request
May 19, 2021
Summary: This is essentially a continuation of pytorch#56700. Currently, some of the steps in **Lint / quick-checks** (such as the trailing newlines check) still don't always run if an earlier steps fail; example: https://github.com/pytorch/pytorch/runs/2504623867 This PR adds some more `if`s to remaining steps, so that they, too, can still run even when earlier steps fail. Pull Request resolved: pytorch#57572 Test Plan: - https://github.com/pytorch/pytorch/runs/2504706736 before this PR, many steps get skipped if an early step fails - https://github.com/pytorch/pytorch/runs/2504778437 using this PR's technique, those steps still run - https://github.com/pytorch/pytorch/runs/2504787234 if the requirements step doesn't run, steps still get skipped - https://github.com/pytorch/pytorch/runs/2504796695 after this PR, `quick-checks` still succeeds Reviewed By: driazati Differential Revision: D28205900 Pulled By: samestep fbshipit-source-id: bea856e15bdd17ee66e9ebba019ce91133b17bcd
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds
if: always()to all the steps in our "Lint / quick-checks" job that don't depend on any preceding steps. Technically means that the title of this PR isn't entirely correct, since the "Ensure correct trailing newlines" step depends on the "Setup Python" step and thus we don'talways()run it even though it'sgrep-based.Test plan:
On
master, it looks like the only failing part of quick-checks is the trailing whitespace check:However, the CI on this PR shows that the unqualified type ignore check is also failing: