adaptive_max_pool2d: port to structured kernel
#56317
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
[ghstack-poisoned]
Contributor
💊 CI failures summary and remediationsAs of commit f4c6902 (more details on the Dr. CI page): 💚 💚 Looks good so far! There are no failures yet. 💚 💚 This comment was automatically generated by Dr. CI (expand for details).Follow this link to opt-out of these comments for your Pull Requests.Please report bugs/suggestions to the (internal) Dr. CI Users group. |
[ghstack-poisoned]
qingyunqu
reviewed
Apr 19, 2021
| { | ||
| Tensor output = at::empty({0}, input.options()); | ||
| Tensor indices = at::empty({0}, input.options().dtype(kLong)); | ||
| adaptive_max_pool2d_out_cpu_template( |
There was a problem hiding this comment.
@SplitInfinity should delete this function? same as cuda.
There was a problem hiding this comment.
and should use git rebase -i to squash these two commits into one?
Author
There was a problem hiding this comment.
I'll delete it. It has already been deleted in the CUDA version.
As for squashing commits, the merging automation will take care of that.
ezyang
approved these changes
Apr 19, 2021
[ghstack-poisoned]
Contributor
|
@SplitInfinity merged this pull request in 0d43947. |
krshrimali
pushed a commit
to krshrimali/pytorch
that referenced
this pull request
May 19, 2021
Summary: Pull Request resolved: pytorch#56317 Test Plan: Imported from OSS Reviewed By: ailzhang Differential Revision: D27862930 Pulled By: SplitInfinity fbshipit-source-id: e2d199df0ebaf585698f26fcfda5a0301ba67ade
bdhirsh
changed the title
adaptive_max_pool2d: port to structured kernel
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack from ghstack:
adaptive_max_pool3d: port to structured kernel #56320 Port adaptive_max_pool3d to structured kerneladaptive_max_pool2d: port to structured kernel #56317 Port adaptive_max_pool2d to structured kernelDifferential Revision: D27862930