Skip to content

[pytorch distributed] Implementing all_gather_base#56304

Closed
liangluofb wants to merge 2 commits intopytorch:masterfrom
liangluofb:export-D27488999
Closed

[pytorch distributed] Implementing all_gather_base#56304
liangluofb wants to merge 2 commits intopytorch:masterfrom
liangluofb:export-D27488999

Conversation

@liangluofb
Copy link
Copy Markdown
Contributor

Summary: This diff implements the all_gather_base in pytorch distributed.

Test Plan: dist.all_gather_base(output, input)...

Differential Revision: D27488999

@facebook-github-bot
Copy link
Copy Markdown
Contributor

facebook-github-bot commented Apr 16, 2021

💊 CI failures summary and remediations

As of commit d7a365c (more details on the Dr. CI page):


  • 2/2 failures introduced in this PR

🕵️ 1 new failure recognized by patterns

The following CI failures do not appear to be due to upstream breakages:

See GitHub Actions build mypy (1/1)

Step: "Run mypy" (full log | diagnosis details | 🔁 rerun)

2021-04-16T22:35:51.0694930Z torch/_C/_distribu...gle overload definition, multiple required [misc]
2021-04-16T22:35:00.6673957Z   LD_LIBRARY_PATH: /opt/hostedtoolcache/Python/3.8.9/x64/lib
2021-04-16T22:35:00.6674454Z ##[endgroup]
2021-04-16T22:35:00.6800725Z + for CONFIG in mypy*.ini
2021-04-16T22:35:00.6801885Z + mypy --config=mypy-strict.ini
2021-04-16T22:35:18.7929235Z Success: no issues found in 56 source files
2021-04-16T22:35:19.4888014Z + for CONFIG in mypy*.ini
2021-04-16T22:35:19.4889140Z + mypy --config=mypy.ini
2021-04-16T22:35:29.0216292Z torch/utils/_cpp_extension_versioner.py:54: error: Name 'hash_value' is not defined  [name-defined]
2021-04-16T22:35:29.0217692Z torch/utils/_cpp_extension_versioner.py:55: error: Name 'hash_value' is not defined  [name-defined]
2021-04-16T22:35:29.0218916Z torch/utils/_cpp_extension_versioner.py:56: error: Name 'hash_value' is not defined  [name-defined]
2021-04-16T22:35:51.0694930Z torch/_C/_distributed_c10d.pyi:225: error: Single overload definition, multiple required  [misc]
2021-04-16T22:36:27.8999397Z Found 4 errors in 2 files (checked 1315 source files)
2021-04-16T22:36:29.7031373Z ##[error]Process completed with exit code 1.
2021-04-16T22:36:29.7133131Z Post job cleanup.
2021-04-16T22:36:29.8207340Z [command]/usr/bin/git version
2021-04-16T22:36:29.8256594Z git version 2.31.1
2021-04-16T22:36:29.8304387Z [command]/usr/bin/git config --local --name-only --get-regexp core\.sshCommand
2021-04-16T22:36:29.8346484Z [command]/usr/bin/git submodule foreach --recursive git config --local --name-only --get-regexp 'core\.sshCommand' && git config --local --unset-all 'core.sshCommand' || :
2021-04-16T22:36:29.8639248Z [command]/usr/bin/git config --local --name-only --get-regexp http\.https\:\/\/github\.com\/\.extraheader
2021-04-16T22:36:29.8672437Z http.https://github.com/.extraheader
2021-04-16T22:36:29.8686536Z [command]/usr/bin/git config --local --unset-all http.https://github.com/.extraheader

1 failure not recognized by patterns:

Job Step Action
GitHub Actions flake8-py3 Fail if there were any warnings 🔁 rerun

This comment was automatically generated by Dr. CI (expand for details).Follow this link to opt-out of these comments for your Pull Requests.

Please report bugs/suggestions to the (internal) Dr. CI Users group.

@facebook-github-bot
Copy link
Copy Markdown
Contributor

This pull request was exported from Phabricator. Differential Revision: D27488999

@rohan-varma rohan-varma requested a review from agolynski April 16, 2021 22:23
amylittleyang and others added 2 commits April 16, 2021 15:32
Differential Revision: D27372372

fbshipit-source-id: bfe7966725bb1b5d5c0cce487b9c0f040dbd7ab6
Summary:
Pull Request resolved: #56304

This diff implements the all_gather_base in pytorch distributed.

Test Plan: dist.all_gather_base(output, input)...

Differential Revision: D27488999

fbshipit-source-id: 2804a99f6abbeed7838273706ec954ffa4e4bf7f
@facebook-github-bot
Copy link
Copy Markdown
Contributor

This pull request was exported from Phabricator. Differential Revision: D27488999

@liangluofb liangluofb closed this Apr 16, 2021
@liangluofb liangluofb deleted the export-D27488999 branch April 16, 2021 22:39
@facebook-github-bot
Copy link
Copy Markdown
Contributor

This pull request was exported from Phabricator. Differential Revision: D27488999

@facebook-github-bot
Copy link
Copy Markdown
Contributor

This pull request was exported from Phabricator. Differential Revision: D27488999

@facebook-github-bot
Copy link
Copy Markdown
Contributor

This pull request was exported from Phabricator. Differential Revision: D27488999

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cla signed fb-exported oncall: distributed Add this issue/PR to distributed oncall triage queue

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants