Remove size arguments for internal orgqr and geqrf calls #56255

IvanYashchuk · 2021-04-16T09:50:57Z

Stack from ghstack:

Add cuSOLVER path for torch.linalg.lstsq #57317 Add cuSOLVER path for torch.linalg.lstsq
Add CUDA support for torch.ormqr #57316 Add CUDA support for torch.ormqr
Port CPU torch.ormqr to ATen #57315 Port CPU torch.ormqr to ATen
Fix torch.ormqr for non Fortran-contiguous inputs #57314 Fix torch.ormqr for non Fortran-contiguous inputs
Fix MAGMA qr for empty batched inputs #56257 Fix MAGMA qr for empty batched inputs
Add cuSOLVER path for torch.linalg.qr #56256 Add cuSOLVER path for torch.linalg.qr
Remove size arguments for internal orgqr and geqrf calls #56255 Remove size arguments for internal orgqr and geqrf calls
Add non-allocating helper function for torch.linalg.qr #56254 Add non-allocating helper function for torch.linalg.qr

With refactored non-allocating linalg_qr_out_helper from the previous
commit we don't need to specify the size arguments because the inputs to
orgqr and geqrf are always of correct size.

Differential Revision: D27960153

With refactored non-allocating `linalg_qr_out_helper` from the previous commit we don't need to specify the size arguments because the inputs to orgqr and geqrf are always of correct size. [ghstack-poisoned]

facebook-github-bot · 2021-04-16T09:51:28Z

💊 CI failures summary and remediations

As of commit 0414629 (more details on the Dr. CI page):

💚 💚 Looks good so far! There are no failures yet. 💚 💚

This comment was automatically generated by Dr. CI (expand for details).

Follow this link to opt-out of these comments for your Pull Requests.

Please report bugs/suggestions to the (internal) Dr. CI Users group.

Click here to manually regenerate this comment.

With refactored non-allocating `linalg_qr_out_helper` from the previous commit we don't need to specify the size arguments because the inputs to orgqr and geqrf are always of correct size. ghstack-source-id: 86540dd Pull Request resolved: pytorch#56255

With refactored non-allocating `linalg_qr_out_helper` from the previous commit we don't need to specify the size arguments because the inputs to orgqr and geqrf are always of correct size. [ghstack-poisoned]

With refactored non-allocating `linalg_qr_out_helper` from the previous commit we don't need to specify the size arguments because the inputs to orgqr and geqrf are always of correct size. ghstack-source-id: 05100bd Pull Request resolved: pytorch#56255

With refactored non-allocating `linalg_qr_out_helper` from the previous commit we don't need to specify the size arguments because the inputs to orgqr and geqrf are always of correct size. [ghstack-poisoned]

With refactored non-allocating `linalg_qr_out_helper` from the previous commit we don't need to specify the size arguments because the inputs to orgqr and geqrf are always of correct size. ghstack-source-id: da404c5 Pull Request resolved: pytorch#56255

With refactored non-allocating `linalg_qr_out_helper` from the previous commit we don't need to specify the size arguments because the inputs to orgqr and geqrf are always of correct size. [ghstack-poisoned]

With refactored non-allocating `linalg_qr_out_helper` from the previous commit we don't need to specify the size arguments because the inputs to orgqr and geqrf are always of correct size. ghstack-source-id: 48082d4 Pull Request resolved: pytorch#56255

With refactored non-allocating `linalg_qr_out_helper` from the previous commit we don't need to specify the size arguments because the inputs to orgqr and geqrf are always of correct size. [ghstack-poisoned]

With refactored non-allocating `linalg_qr_out_helper` from the previous commit we don't need to specify the size arguments because the inputs to orgqr and geqrf are always of correct size. ghstack-source-id: bda5539 Pull Request resolved: pytorch#56255

mruberry

Cool!

With refactored non-allocating `linalg_qr_out_helper` from the previous commit we don't need to specify the size arguments because the inputs to orgqr and geqrf are always of correct size. Differential Revision: [D27960153](https://our.internmc.facebook.com/intern/diff/D27960153) [ghstack-poisoned]

With refactored non-allocating `linalg_qr_out_helper` from the previous commit we don't need to specify the size arguments because the inputs to orgqr and geqrf are always of correct size. ghstack-source-id: 96494a7 Pull Request resolved: pytorch#56255

With refactored non-allocating `linalg_qr_out_helper` from the previous commit we don't need to specify the size arguments because the inputs to orgqr and geqrf are always of correct size. Differential Revision: [D27960153](https://our.internmc.facebook.com/intern/diff/D27960153) [ghstack-poisoned]

With refactored non-allocating `linalg_qr_out_helper` from the previous commit we don't need to specify the size arguments because the inputs to orgqr and geqrf are always of correct size. ghstack-source-id: a4c4bde Pull Request resolved: pytorch#56255

With refactored non-allocating `linalg_qr_out_helper` from the previous commit we don't need to specify the size arguments because the inputs to orgqr and geqrf are always of correct size. Differential Revision: [D27960153](https://our.internmc.facebook.com/intern/diff/D27960153) [ghstack-poisoned]

With refactored non-allocating `linalg_qr_out_helper` from the previous commit we don't need to specify the size arguments because the inputs to orgqr and geqrf are always of correct size. ghstack-source-id: 2cdf056 Pull Request resolved: pytorch#56255

facebook-github-bot · 2021-04-30T18:15:21Z

@mruberry merged this pull request in 6cb9abf.

Summary: Pull Request resolved: pytorch#56255 With refactored non-allocating `linalg_qr_out_helper` from the previous commit we don't need to specify the size arguments because the inputs to orgqr and geqrf are always of correct size. Test Plan: Imported from OSS Reviewed By: ngimel Differential Revision: D27960153 Pulled By: mruberry fbshipit-source-id: 0f9be25781371633378752b587da62b828816646

Remove size arguments for internal orgqr and geqrf calls

c1fe54a

With refactored non-allocating `linalg_qr_out_helper` from the previous commit we don't need to specify the size arguments because the inputs to orgqr and geqrf are always of correct size. [ghstack-poisoned]

facebook-github-bot added the cla signed label Apr 16, 2021

pytorchbot added the open source label Apr 16, 2021

IvanYashchuk added the module: linear algebra Issues related to specialized linear algebra operations in PyTorch; includes matrix multiply matmul label Apr 16, 2021

IvanYashchuk requested a review from mruberry April 16, 2021 10:03

Update on "Remove size arguments for internal orgqr and geqrf calls"

26891b6

With refactored non-allocating `linalg_qr_out_helper` from the previous commit we don't need to specify the size arguments because the inputs to orgqr and geqrf are always of correct size. [ghstack-poisoned]

Update on "Remove size arguments for internal orgqr and geqrf calls"

6068ef1

With refactored non-allocating `linalg_qr_out_helper` from the previous commit we don't need to specify the size arguments because the inputs to orgqr and geqrf are always of correct size. [ghstack-poisoned]

Update on "Remove size arguments for internal orgqr and geqrf calls"

7a1da4d

With refactored non-allocating `linalg_qr_out_helper` from the previous commit we don't need to specify the size arguments because the inputs to orgqr and geqrf are always of correct size. [ghstack-poisoned]

IvanYashchuk added 2 commits April 19, 2021 12:10

Update on "Remove size arguments for internal orgqr and geqrf calls"

5ec43bf

With refactored non-allocating `linalg_qr_out_helper` from the previous commit we don't need to specify the size arguments because the inputs to orgqr and geqrf are always of correct size. [ghstack-poisoned]

Update on "Remove size arguments for internal orgqr and geqrf calls"

a4d760e

With refactored non-allocating `linalg_qr_out_helper` from the previous commit we don't need to specify the size arguments because the inputs to orgqr and geqrf are always of correct size. [ghstack-poisoned]

Update on "Remove size arguments for internal orgqr and geqrf calls"

0c9d3c3

With refactored non-allocating `linalg_qr_out_helper` from the previous commit we don't need to specify the size arguments because the inputs to orgqr and geqrf are always of correct size. [ghstack-poisoned]

Update on "Remove size arguments for internal orgqr and geqrf calls"

b8d9869

With refactored non-allocating `linalg_qr_out_helper` from the previous commit we don't need to specify the size arguments because the inputs to orgqr and geqrf are always of correct size. [ghstack-poisoned]

Update on "Remove size arguments for internal orgqr and geqrf calls"

442181f

With refactored non-allocating `linalg_qr_out_helper` from the previous commit we don't need to specify the size arguments because the inputs to orgqr and geqrf are always of correct size. [ghstack-poisoned]

Update on "Remove size arguments for internal orgqr and geqrf calls"

9ae0ea5

With refactored non-allocating `linalg_qr_out_helper` from the previous commit we don't need to specify the size arguments because the inputs to orgqr and geqrf are always of correct size. [ghstack-poisoned]

mruberry approved these changes Apr 23, 2021

View reviewed changes

This was referenced Apr 29, 2021

Fix torch.ormqr for non Fortran-contiguous inputs #57314

Closed

Port CPU torch.ormqr to ATen #57315

Closed

Add CUDA support for torch.ormqr #57316

Closed

Add cuSOLVER path for torch.linalg.lstsq #57317

Closed

facebook-github-bot closed this in 6cb9abf Apr 30, 2021

facebook-github-bot added the Merged label Apr 30, 2021

facebook-github-bot deleted the gh/ivanyashchuk/16/head branch May 4, 2021 14:16

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Remove size arguments for internal orgqr and geqrf calls #56255

Remove size arguments for internal orgqr and geqrf calls #56255

Uh oh!

IvanYashchuk commented Apr 16, 2021 •

edited

Loading

Uh oh!

facebook-github-bot commented Apr 16, 2021 •

edited

Loading

Uh oh!

mruberry left a comment

Uh oh!

facebook-github-bot commented Apr 30, 2021

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

Remove size arguments for internal orgqr and geqrf calls #56255

Remove size arguments for internal orgqr and geqrf calls #56255

Uh oh!

Conversation

IvanYashchuk commented Apr 16, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

facebook-github-bot commented Apr 16, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

💊 CI failures summary and remediations

Uh oh!

mruberry left a comment

Choose a reason for hiding this comment

Uh oh!

facebook-github-bot commented Apr 30, 2021

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

IvanYashchuk commented Apr 16, 2021 •

edited

Loading

facebook-github-bot commented Apr 16, 2021 •

edited

Loading