Finish deprecation cycle for inplace view error checks #56093
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
💊 CI failures summary and remediationsAs of commit f04bc30 (more details on the Dr. CI page):
🚧 2 fixed upstream failures:These were probably caused by upstream breakages that were already fixed.
Please rebase on the
|
soulitzer
force-pushed
the
inplace-view-error
branch
4 times, most recently
from
7c476bc to
435aa3b
Compare
Codecov Report
@@ Coverage Diff @@
## master #56093 +/- ##
=======================================
Coverage 77.12% 77.12%
=======================================
Files 1912 1912
Lines 189559 189557 -2
=======================================
- Hits 146195 146194 -1
+ Misses 43364 43363 -1 |
albanD
reviewed
Apr 15, 2021
Collaborator
albanD
left a comment
albanD
left a comment
There was a problem hiding this comment.
Looks mostly good! Thanks
soulitzer
force-pushed
the
inplace-view-error
branch
2 times, most recently
from
2fa5fb8 to
06415cb
Compare
soulitzer
force-pushed
the
inplace-view-error
branch
from
06415cb to
f04bc30
Compare
Contributor
|
@soulitzer has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator. |
Contributor
|
@soulitzer merged this pull request in dd8bfe2. |
krshrimali
pushed a commit
to krshrimali/pytorch
that referenced
this pull request
May 19, 2021
Summary: Fixes pytorch#50617 Also updates the relevant tests to expect errors instead of warnings Pull Request resolved: pytorch#56093 Reviewed By: agolynski Differential Revision: D27806795 Pulled By: soulitzer fbshipit-source-id: 93c5c28edb1f97fa4457332c2ef4711f050ac81f
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #50617
BC-breaking Notes
In-place modification of views will now raise an error if that view was created by a custom function or a function that returns multiple views, or if the view was created in no-grad mode.
Modifying in-place a view created in the situations above are error-prone and have been deprecated since v1.5.0. Doing these in-place modifications are now forbidden.
For more information on how to work around this, see the related sections the release notes linked below:
splitandchunk, i.e., functions that return multiple views).-- end release notes --
This PR also updates the relevant tests to expect errors instead of warnings