[c10d] Remove deprecated use of torch.LongTensor, torch.ByteTensor#55861
Closed
rohan-varma wants to merge 4 commits intogh/rohan-varma/288/basefrom
Closed
[c10d] Remove deprecated use of torch.LongTensor, torch.ByteTensor#55861rohan-varma wants to merge 4 commits intogh/rohan-varma/288/basefrom
rohan-varma wants to merge 4 commits intogh/rohan-varma/288/basefrom
Conversation
APIs such as torch.LongTensor and torch.ByteTensor are deprecated and the recommended API is torch.tensor(args, dtype=...). Use this API in distributed_c10d. Differential Revision: [D27726600](https://our.internmc.facebook.com/intern/diff/D27726600/) [ghstack-poisoned]
rohan-varma
requested review from
H-Huang,
mingzhe09088,
mrshenli,
pritamdamania87,
wayi1 and
zhaojuanmao
as code owners
Contributor
💊 CI failures summary and remediationsAs of commit aa74e7a (more details on the Dr. CI page):
This comment was automatically generated by Dr. CI (expand for details).Follow this link to opt-out of these comments for your Pull Requests.Please report bugs/suggestions to the (internal) Dr. CI Users group. |
facebook-github-bot
added
oncall: distributed
rohan-varma
added a commit
that referenced
this pull request
Apr 13, 2021
APIs such as torch.LongTensor and torch.ByteTensor are deprecated and the recommended API is torch.tensor(args, dtype=...). Use this API in distributed_c10d. Differential Revision: [D27726600](https://our.internmc.facebook.com/intern/diff/D27726600/) ghstack-source-id: 126357498 Pull Request resolved: #55861
zhaojuanmao
approved these changes
Apr 13, 2021
…teTensor" APIs such as torch.LongTensor and torch.ByteTensor are deprecated and the recommended API is torch.tensor(args, dtype=...). Use this API in distributed_c10d. Differential Revision: [D27726600](https://our.internmc.facebook.com/intern/diff/D27726600/) [ghstack-poisoned]
…teTensor" APIs such as torch.LongTensor and torch.ByteTensor are deprecated and the recommended API is torch.tensor(args, dtype=...). Use this API in distributed_c10d. Differential Revision: [D27726600](https://our.internmc.facebook.com/intern/diff/D27726600/) [ghstack-poisoned]
…teTensor" APIs such as torch.LongTensor and torch.ByteTensor are deprecated and the recommended API is torch.tensor(args, dtype=...). Use this API in distributed_c10d. Differential Revision: [D27726600](https://our.internmc.facebook.com/intern/diff/D27726600/) [ghstack-poisoned]
rohan-varma
added a commit
that referenced
this pull request
Apr 16, 2021
Pull Request resolved: #55861 APIs such as torch.LongTensor and torch.ByteTensor are deprecated and the recommended API is torch.tensor(args, dtype=...). Use this API in distributed_c10d. ghstack-source-id: 126777875 Differential Revision: [D27726600](https://our.internmc.facebook.com/intern/diff/D27726600/)
Contributor
|
This pull request has been merged in ce05b7a. |
krshrimali
pushed a commit
to krshrimali/pytorch
that referenced
this pull request
May 19, 2021
…ytorch#55861) Summary: Pull Request resolved: pytorch#55861 APIs such as torch.LongTensor and torch.ByteTensor are deprecated and the recommended API is torch.tensor(args, dtype=...). Use this API in distributed_c10d. ghstack-source-id: 126777875 Test Plan: CI Reviewed By: pbelevich Differential Revision: D27726600 fbshipit-source-id: 07eb8168d93697593589002c93c3903ce29431ef
This was referenced Sep 27, 2021
wayi1
pushed a commit
that referenced
this pull request
Sep 27, 2021
#Closes: #65696 The bug is introduced in #55861, and it causes 100X slowdown since 1.9. Differential Revision: [D31219794](https://our.internmc.facebook.com/intern/diff/D31219794/) [ghstack-poisoned]
wayi1
pushed a commit
that referenced
this pull request
Sep 27, 2021
#Closes: #65696 The bug is introduced in #55861, and it causes 100X slowdown since 1.9. Differential Revision: [D31219794](https://our.internmc.facebook.com/intern/diff/D31219794/) ghstack-source-id: 139128267 Pull Request resolved: #65721
facebook-github-bot
pushed a commit
that referenced
this pull request
Sep 28, 2021
Summary: Pull Request resolved: #65721 #Closes: #65696 The bug is introduced in #55861, and it causes 100X slowdown since 1.9. ghstack-source-id: 139128267 Test Plan: Performance test: ``` import time from torch.distributed.distributed_c10d import _object_to_tensor start = time.time() _object_to_tensor("x" * 50_000_000) print("Time:", time.time() - start) ``` Reviewed By: rohan-varma Differential Revision: D31219794 fbshipit-source-id: 1abec38f9d51361c1eab6ad5efd87b589322e208
malfet
pushed a commit
to malfet/pytorch
that referenced
this pull request
Sep 29, 2021
Summary: Pull Request resolved: pytorch#65721 #Closes: pytorch#65696 The bug is introduced in pytorch#55861, and it causes 100X slowdown since 1.9. ghstack-source-id: 139128267 Test Plan: Performance test: ``` import time from torch.distributed.distributed_c10d import _object_to_tensor start = time.time() _object_to_tensor("x" * 50_000_000) print("Time:", time.time() - start) ``` Reviewed By: rohan-varma Differential Revision: D31219794 fbshipit-source-id: 1abec38f9d51361c1eab6ad5efd87b589322e208
malfet
added a commit
that referenced
this pull request
Sep 29, 2021
Summary: Pull Request resolved: #65721 #Closes: #65696 The bug is introduced in #55861, and it causes 100X slowdown since 1.9. ghstack-source-id: 139128267 Test Plan: Performance test: ``` import time from torch.distributed.distributed_c10d import _object_to_tensor start = time.time() _object_to_tensor("x" * 50_000_000) print("Time:", time.time() - start) ``` Reviewed By: rohan-varma Differential Revision: D31219794 fbshipit-source-id: 1abec38f9d51361c1eab6ad5efd87b589322e208 Co-authored-by: Yi Wang <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stack from ghstack:
APIs such as torch.LongTensor and torch.ByteTensor are deprecated and
the recommended API is torch.tensor(args, dtype=...). Use this API in
distributed_c10d.
Differential Revision: D27726600