Skip to content

Fix complex mean and reduction tests not being run #55640

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
peterbell10 wants to merge 1 commit into from
Closed

Fix complex mean and reduction tests not being run #55640

peterbell10 wants to merge 1 commit into from

Conversation

@peterbell10
Copy link
Collaborator

@peterbell10 peterbell10 commented Apr 8, 2021 •
edited
Loading

Stack from ghstack:

Mean is broken for complex types, since #53218 it's now allocating the result
as a real tensor which discards the imaginary component. This wasn't picked up
in testing because _test_dim_ops tests are defined as closures inside of
_test_dim_ops instead of as methods on the test class. The result is, they
never get run.

For best results, view diff with "Hide whitespace changes".

Differential Revision: D27671127

@peterbell10
Fix complex mean and reduction tests not being run
2557cee 
Mean is broken for complex types, since #53218 it's now allocating the result
as a real tensor which discards the imaginary component. This wasn't picked up
in testing because `_test_dim_ops` tests are defined as closures inside of
`_test_dim_ops` instead of as methods on the test class. The result is, they
never get run.

For best results, view diff with "Hide whitespace changes".

[ghstack-poisoned]
@peterbell10 peterbell10 mentioned this pull request Apr 8, 2021
Closed
@facebook-github-bot
Copy link
Contributor

facebook-github-bot commented Apr 8, 2021 •
edited
Loading

💊 CI failures summary and remediations

As of commit 2557cee (more details on the Dr. CI page):

  • 1/1 failures introduced in this PR

🕵️ 1 new failure recognized by patterns

The following CI failures do not appear to be due to upstream breakages:

See CircleCI build pytorch_linux_xenial_py3_6_gcc5_4_test (1/1)

Step: "Run tests" (full log | diagnosis details | 🔁 rerun)

Apr 08 23:08:06 [E request_callback_no_python.cpp:656] Received error while processing request type 256: The following operation failed in the TorchScript interpreter. 
Apr 08 23:08:06 
Apr 08 23:08:06 [E request_callback_no_python.cpp:656] Received error while processing request type 256: The following operation failed in the TorchScript interpreter.
Apr 08 23:08:06 Traceback of TorchScript (most recent call last):
Apr 08 23:08:06   File "/opt/conda/lib/python3.6/site-packages/torch/testing/_internal/distributed/rpc/rpc_test.py", line 334, in raise_func_script
Apr 08 23:08:06 @torch.jit.script
Apr 08 23:08:06 def raise_func_script(expected_err: str) -> torch.Tensor:
Apr 08 23:08:06     raise ValueError(expected_err)
Apr 08 23:08:06     ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ <--- HERE
Apr 08 23:08:06 RuntimeError: Expected error
Apr 08 23:08:06 
Apr 08 23:08:06 [E request_callback_no_python.cpp:656] Received error while processing request type 256: The following operation failed in the TorchScript interpreter.
Apr 08 23:08:06 Traceback of TorchScript (most recent call last):
Apr 08 23:08:06   File "/opt/conda/lib/python3.6/site-packages/torch/testing/_internal/distributed/rpc/rpc_test.py", line 334, in raise_func_script
Apr 08 23:08:06 @torch.jit.script
Apr 08 23:08:06 def raise_func_script(expected_err: str) -> torch.Tensor:
Apr 08 23:08:06     raise ValueError(expected_err)
Apr 08 23:08:06     ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ <--- HERE
Apr 08 23:08:06 RuntimeError: Expected error
Apr 08 23:08:06 
Apr 08 23:08:06 ok (2.663s)
Apr 08 23:08:08   test_wait_all_multiple_call (__main__.TensorPipeRpcTestWithSpawn) ... WARNING:root:This caffe2 python run failed to load cuda module:No module named 'caffe2.python.caffe2_pybind11_state_gpu',and AMD hip module:No module named 'caffe2.python.caffe2_pybind11_state_hip'.Will run in CPU only mode.

1 job timed out:

  • pytorch_linux_xenial_py3_6_gcc5_4_test
This comment was automatically generated by Dr. CI (expand for details).Follow this link to opt-out of these comments for your Pull Requests.

Please report bugs/suggestions to the (internal) Dr. CI Users group.

@peterbell10 peterbell10 requested a review from mruberry April 8, 2021 20:50
@peterbell10
Copy link
Collaborator Author

peterbell10 commented Apr 8, 2021

Actually, I think the whitespace got messed up when the tests were split off from test_torch.py.

mruberry
mruberry approved these changes Apr 9, 2021
View reviewed changes
Copy link
Collaborator

@mruberry mruberry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

This was referenced Apr 9, 2021
Closed
Closed
Closed
Closed
@facebook-github-bot
Copy link
Contributor

facebook-github-bot commented Apr 9, 2021

@mruberry merged this pull request in 35a66db.

@facebook-github-bot facebook-github-bot deleted the gh/peterbell10/57/head branch April 13, 2021 14:16
krshrimali pushed a commit to krshrimali/pytorch that referenced this pull request May 19, 2021
@peterbell10
Fix complex mean and reduction tests not being run (pytorch#55640)
d11d91c 
Summary:
Pull Request resolved: pytorch#55640

Mean is broken for complex types, since pytorch#53218 it's now allocating the result
as a real tensor which discards the imaginary component. This wasn't picked up
in testing because `_test_dim_ops` tests are defined as closures inside of
`_test_dim_ops` instead of as methods on the test class. The result is, they
never get run.

For best results, view diff with "Hide whitespace changes".

Test Plan: Imported from OSS

Reviewed By: ngimel

Differential Revision: D27671127

Pulled By: mruberry

fbshipit-source-id: 4a1f6fea1048919fda7339c867ee78e88f2d7bd2
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mruberry mruberry mruberry approved these changes

Assignees

No one assigned

Labels

cla signed Merged open source

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@peterbell10 @facebook-github-bot @mruberry @pytorchbot