Skip to content

cosh: port to structured kernel #55563

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
SplitInfinity wants to merge 2 commits into from
Closed

cosh: port to structured kernel #55563

SplitInfinity wants to merge 2 commits into from

Conversation

@SplitInfinity
Copy link

@SplitInfinity SplitInfinity commented Apr 7, 2021 •
edited
Loading

Stack from ghstack:

Differential Revision: D27653767

@SplitInfinity SplitInfinity requested a review from ezyang as a code owner April 7, 2021 21:54
@SplitInfinity SplitInfinity mentioned this pull request Apr 7, 2021
Closed
@facebook-github-bot
Copy link
Contributor

facebook-github-bot commented Apr 7, 2021 •
edited
Loading

💊 CI failures summary and remediations

As of commit bd93b08 (more details on the Dr. CI page):

  • 1/1 failures possibly* introduced in this PR
    • 1/1 non-scanned failure(s)

ci.pytorch.org: 1 failed

This comment was automatically generated by Dr. CI (expand for details).Follow this link to opt-out of these comments for your Pull Requests.

Please report bugs/suggestions to the (internal) Dr. CI Users group.

This was referenced Apr 7, 2021
Closed
Closed
@SplitInfinity SplitInfinity mentioned this pull request Apr 7, 2021
Closed
@SplitInfinity SplitInfinity linked an issue Apr 7, 2021 that may be closed by this pull request
Port kernels to be structured [tracker] #55070
Closed
@SplitInfinity SplitInfinity removed a link to an issue Apr 7, 2021
Port kernels to be structured [tracker] #55070
Closed
ezyang
ezyang approved these changes Apr 8, 2021
View reviewed changes
Copy link
Contributor

@ezyang ezyang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

but need to do CUDA too!

@SplitInfinity
Copy link
Author

SplitInfinity commented Apr 8, 2021 •
edited
Loading

but need to do CUDA too!

What am I missing? I updated the CUDA kernel to use TensorIteratorBase instead of TensorIterator. There weren't any other CUDA-related changes in the PR I copied took inspiration from...

@ezyang
Copy link
Contributor

ezyang commented Apr 8, 2021

Might be a problem with sinh, which is also got compilation errors

@SplitInfinity
Copy link
Author

SplitInfinity commented Apr 8, 2021

Might be a problem with sinh, which is also got compilation errors

Ah yes, that would explain things.

@facebook-github-bot
Copy link
Contributor

facebook-github-bot commented Apr 9, 2021

@SplitInfinity merged this pull request in 19e43ea.

@facebook-github-bot facebook-github-bot deleted the gh/splitinfinity/123/head branch April 12, 2021 14:21
@bdhirsh bdhirsh changed the title Migrate cosh to structured kernel cosh: port to structured kernel May 24, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ezyang ezyang ezyang approved these changes

Assignees

No one assigned

Labels

cla signed hackathon Merged

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@SplitInfinity @facebook-github-bot @ezyang