Skip to content

reflection_pad1: port to structured kernel #55531

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
zyan0 wants to merge 1 commit into from
Closed

reflection_pad1: port to structured kernel #55531

zyan0 wants to merge 1 commit into from

Conversation

@zyan0
Copy link

@zyan0 zyan0 commented Apr 7, 2021 •
edited
Loading

@zyan0 zyan0 requested a review from ezyang as a code owner April 7, 2021 19:18
@facebook-github-bot
Copy link
Contributor

facebook-github-bot commented Apr 7, 2021 •
edited
Loading

💊 CI failures summary and remediations

As of commit 0dc2f5d (more details on the Dr. CI page):

💚 💚 Looks good so far! There are no failures yet. 💚 💚

This comment was automatically generated by Dr. CI (expand for details).Follow this link to opt-out of these comments for your Pull Requests.

Please report bugs/suggestions to the (internal) Dr. CI Users group.

@facebook-github-bot
Copy link
Contributor

facebook-github-bot commented Apr 7, 2021

This pull request was exported from Phabricator. Differential Revision: D27628059

@zyan0 zyan0 force-pushed the export-D27628059 branch from 412a44f to abd5863 Compare April 7, 2021 19:21
@zyan0 zyan0 mentioned this pull request Apr 7, 2021
Closed
@facebook-github-bot
Copy link
Contributor

facebook-github-bot commented Apr 7, 2021

This pull request was exported from Phabricator. Differential Revision: D27628059

@zyan0 zyan0 force-pushed the export-D27628059 branch from abd5863 to e4e3af5 Compare April 7, 2021 19:24
@zyan0 zyan0 added the hackathon label Apr 7, 2021
@facebook-github-bot
Copy link
Contributor

facebook-github-bot commented Apr 7, 2021

This pull request was exported from Phabricator. Differential Revision: D27628059

@zyan0 zyan0 force-pushed the export-D27628059 branch from e4e3af5 to 656ec1b Compare April 7, 2021 19:33
@facebook-github-bot
Copy link
Contributor

facebook-github-bot commented Apr 7, 2021

This pull request was exported from Phabricator. Differential Revision: D27628059

@zyan0 zyan0 force-pushed the export-D27628059 branch from 656ec1b to 26c7b7b Compare April 7, 2021 19:39
ezyang
ezyang reviewed Apr 8, 2021
View reviewed changes
aten/src/ATen/native/cuda/ReflectionPad.cu Outdated
Copy link
Contributor

@ezyang ezyang Apr 8, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This will "work" but it will be better to inline reflection_pad1d_out_template into the IMPL_FUNC and then delete the unnecessary shape checking code.

ezyang
ezyang reviewed Apr 8, 2021
View reviewed changes
aten/src/ATen/native/ReflectionPad.cpp Outdated
Copy link
Contributor

@ezyang ezyang Apr 8, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ditto here

Copy link
Author

@zyan0 zyan0 Apr 8, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

reflection_pad1d_out_template is still used in reflection_pad1d_cpu for reflection_pad1d to dispatch QuantizedCPU.

ezyang
ezyang approved these changes Apr 8, 2021
View reviewed changes
Copy link
Contributor

@ezyang ezyang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a good start but it would be better to now remove the redundant checks.

@zyan0 zyan0 force-pushed the export-D27628059 branch from 26c7b7b to f3d773e Compare April 8, 2021 18:16
@facebook-github-bot
Copy link
Contributor

facebook-github-bot commented Apr 8, 2021

This pull request was exported from Phabricator. Differential Revision: D27628059

@facebook-github-bot
Copy link
Contributor

facebook-github-bot commented Apr 8, 2021

This pull request was exported from Phabricator. Differential Revision: D27628059

@zyan0 zyan0 force-pushed the export-D27628059 branch from f3d773e to db368dc Compare April 8, 2021 19:42
@codecov
Copy link

codecov bot commented Apr 9, 2021 •
edited
Loading

Codecov Report

Merging #55531 (2046763) into master (c7312f5) will increase coverage by 2.73%.
The diff coverage is 64.87%.

❗ Current head 2046763 differs from pull request most recent head 0dc2f5d. Consider uploading reports for the commit 0dc2f5d to get more accurate results

@@            Coverage Diff             @@
##           master   #55531      +/-   ##
==========================================
+ Coverage   74.66%   77.40%   +2.73%     
==========================================
  Files        1896     1902       +6     
  Lines      187857   188386     +529     
==========================================
+ Hits       140268   145814    +5546     
+ Misses      47589    42572    -5017

@facebook-github-bot
Copy link
Contributor

facebook-github-bot commented Apr 12, 2021

This pull request was exported from Phabricator. Differential Revision: D27628059

@zyan0 zyan0 force-pushed the export-D27628059 branch from db368dc to 2046763 Compare April 12, 2021 18:24
@facebook-github-bot
Port reflection_pad1d to structured kernel (pytorch#55531)
0dc2f5d 
Summary:
Pull Request resolved: pytorch#55531

Following https://github.com/pytorch/rfcs/blob/rfc-0005/RFC-0005-structured-kernel-definitions.md

Test Plan: unittests

Reviewed By: ezyang

Differential Revision: D27628059

fbshipit-source-id: 3c314e6263313d13daa08da81f76eed29b390de6
@zyan0 zyan0 force-pushed the export-D27628059 branch from 2046763 to 0dc2f5d Compare April 13, 2021 17:49
@facebook-github-bot
Copy link
Contributor

facebook-github-bot commented Apr 13, 2021

This pull request was exported from Phabricator. Differential Revision: D27628059

@facebook-github-bot
Copy link
Contributor

facebook-github-bot commented Apr 13, 2021

This pull request has been merged in a61d91e.

krshrimali pushed a commit to krshrimali/pytorch that referenced this pull request May 19, 2021
Port reflection_pad1d to structured kernel (pytorch#55531)
49b61b3 
Summary:
Pull Request resolved: pytorch#55531

Following https://github.com/pytorch/rfcs/blob/rfc-0005/RFC-0005-structured-kernel-definitions.md

Test Plan: unittests

Reviewed By: ezyang

Differential Revision: D27628059

fbshipit-source-id: 885a10b766db39f8f8df4dcaaf0769fcf2ff9751
@bdhirsh bdhirsh changed the title Port reflection_pad1d to structured kernel reflection_pad1: port to structured kernel May 24, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ezyang ezyang ezyang approved these changes

Assignees

No one assigned

Labels

cla signed fb-exported hackathon Merged

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@zyan0 @facebook-github-bot @ezyang