[tools] Remove newline from clang-format reference hashes #55328
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
**Summary** The `clang-format` reference hashes committed in #54737 have newlines at the end but the locally computed ones do not. This commit removes these newlines so that the `clang-format` binary verification step doesn't fail. **Test Plan** `./tools/clang_format_all.py`, ran successfully. **Fixes** This commit fixes ##54790. [ghstack-poisoned]
Contributor
💊 CI failures summary and remediationsAs of commit 4e28b4c (more details on the Dr. CI page):
2 failures not recognized by patterns:
This comment was automatically generated by Dr. CI (expand for details).Follow this link to opt-out of these comments for your Pull Requests.Please report bugs/suggestions to the (internal) Dr. CI Users group. |
Contributor
|
Patch to fix the trailing-newlines lint: diff --git a/.github/workflows/lint.yml b/.github/workflows/lint.yml
index e20814cec7..52ecfb874e 100644
--- a/.github/workflows/lint.yml
+++ b/.github/workflows/lint.yml
@@ -43,7 +43,7 @@ jobs:
.jenkins/run-shellcheck.sh
- name: Ensure correct trailing newlines
run: |
- (! git grep -Il '' -- . ':(exclude)**/contrib/**' ':(exclude)third_party' ':(exclude)**.expect' | tools/trailing_newlines.py || (echo "The above files do not have correct trailing newlines; please normalize them"; false))
+ (! git grep -Il '' -- . ':(exclude)**/contrib/**' ':(exclude)third_party' ':(exclude)**.expect' ':(exclude)tools/clang_format_hash' | tools/trailing_newlines.py || (echo "The above files do not have correct trailing newlines; please normalize them"; false))
- name: Ensure no trailing spaces
run: |
(! git grep -I -no ' $' -- . ':(exclude)**/contrib/**' ':(exclude)third_party' || (echo "The above files have trailing spaces; please remove them"; false)) |
**Summary** The `clang-format` reference hashes committed in #54737 have newlines at the end but the locally computed ones do not. This commit removes these newlines so that the `clang-format` binary verification step doesn't fail. **Test Plan** `./tools/clang_format_all.py`, ran successfully. **Fixes** This commit fixes ##54790. [ghstack-poisoned]
SplitInfinity
pushed a commit
that referenced
this pull request
Apr 5, 2021
**Summary** The `clang-format` reference hashes committed in #54737 have newlines at the end but the locally computed ones do not. This commit removes these newlines so that the `clang-format` binary verification step doesn't fail. **Test Plan** `./tools/clang_format_all.py`, ran successfully. **Fixes** This commit fixes ##54790. ghstack-source-id: f856a00 Pull Request resolved: #55328
samestep
approved these changes
Apr 5, 2021
Contributor
|
Why not just strip newlines from the hash files. |
Contributor
I like that solution too. Either way is fine with me. |
Author
You mean in code with |
**Summary** The `clang-format` reference hashes committed in #54737 have newlines at the end but the locally computed ones do not. This commit removes these newlines so that the `clang-format` binary verification step doesn't fail. **Test Plan** `./tools/clang_format_all.py`, ran successfully. **Fixes** This commit fixes #54790. Differential Revision: [D27577398](https://our.internmc.facebook.com/intern/diff/D27577398) [ghstack-poisoned]
SplitInfinity
pushed a commit
that referenced
this pull request
Apr 6, 2021
Pull Request resolved: #55328 **Summary** The `clang-format` reference hashes committed in #54737 have newlines at the end but the locally computed ones do not. This commit removes these newlines so that the `clang-format` binary verification step doesn't fail. **Test Plan** `./tools/clang_format_all.py`, ran successfully. **Fixes** This commit fixes #54790. Differential Revision: [D27577398](https://our.internmc.facebook.com/intern/diff/D27577398/) ghstack-source-id: 125877245
Contributor
|
@SplitInfinity merged this pull request in 34a7b4a. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack from ghstack:
Summary
The
clang-formatreference hashes committed in #54737 have newlines atthe end but the locally computed ones do not. This commit removes these
newlines so that the
clang-formatbinary verification step doesn'tfail.
Test Plan
./tools/clang_format_all.py, ran successfully.Fixes
This commit fixes #54790.
Differential Revision: D27577398