Don't allocate result Tensors in out overloads: _linalg_solve_out_helper_cuda #55321
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…per_cuda We have some operators that previously allowed you to pass in an undefined tensor to the out argument, and then would go on to allocate that for you. This behavior is broken and doesn't work in JIT when things are converted to/from IValues. Because of this, it blocks backend fallbacks because they force going through IValue. This PR is one in a series to remove that behavior and forces out arguments to be defined tensors. It only looks at at::_linalg_solve_out_helper_cuda(), but there's more PRs for other ops. Differential Revision: [D27572759](https://our.internmc.facebook.com/intern/diff/D27572759/) [ghstack-poisoned]
Contributor
💊 CI failures summary and remediationsAs of commit f719860 (more details on the Dr. CI page):
This comment was automatically generated by Dr. CI (expand for details).Follow this link to opt-out of these comments for your Pull Requests.Please report bugs/suggestions to the (internal) Dr. CI Users group. |
This was referenced Apr 5, 2021
Closed
…lve_out_helper_cuda" We have some operators that previously allowed you to pass in an undefined tensor to the out argument, and then would go on to allocate that for you. This behavior is broken and doesn't work in JIT when things are converted to/from IValues. Because of this, it blocks backend fallbacks because they force going through IValue. This PR is one in a series to remove that behavior and forces out arguments to be defined tensors. It only looks at at::_linalg_solve_out_helper_cuda(), but there's more PRs for other ops. Differential Revision: [D27572759](https://our.internmc.facebook.com/intern/diff/D27572759/) [ghstack-poisoned]
IvanYashchuk
approved these changes
Apr 6, 2021
…lve_out_helper_cuda" We have some operators that previously allowed you to pass in an undefined tensor to the out argument, and then would go on to allocate that for you. This behavior is broken and doesn't work in JIT when things are converted to/from IValues. Because of this, it blocks backend fallbacks because they force going through IValue. This PR is one in a series to remove that behavior and forces out arguments to be defined tensors. It only looks at at::_linalg_solve_out_helper_cuda(), but there's more PRs for other ops. Differential Revision: [D27572759](https://our.internmc.facebook.com/intern/diff/D27572759/) [ghstack-poisoned]
…lve_out_helper_cuda" We have some operators that previously allowed you to pass in an undefined tensor to the out argument, and then would go on to allocate that for you. This behavior is broken and doesn't work in JIT when things are converted to/from IValues. Because of this, it blocks backend fallbacks because they force going through IValue. This PR is one in a series to remove that behavior and forces out arguments to be defined tensors. It only looks at at::_linalg_solve_out_helper_cuda(), but there's more PRs for other ops. Differential Revision: [D27572759](https://our.internmc.facebook.com/intern/diff/D27572759/) [ghstack-poisoned]
…lve_out_helper_cuda" We have some operators that previously allowed you to pass in an undefined tensor to the out argument, and then would go on to allocate that for you. This behavior is broken and doesn't work in JIT when things are converted to/from IValues. Because of this, it blocks backend fallbacks because they force going through IValue. This PR is one in a series to remove that behavior and forces out arguments to be defined tensors. It only looks at at::_linalg_solve_out_helper_cuda(), but there's more PRs for other ops. Differential Revision: [D27572759](https://our.internmc.facebook.com/intern/diff/D27572759/) [ghstack-poisoned]
Contributor
|
This pull request has been merged in 87cf277. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack from ghstack:
We have some operators that previously allowed you to pass in an undefined tensor to the out argument,
and then would go on to allocate that for you. This behavior is broken and doesn't work in JIT when things
are converted to/from IValues. Because of this, it blocks backend fallbacks because they force going
through IValue.
This PR is one in a series to remove that behavior and forces out arguments to be defined tensors.
It only looks at at::_linalg_solve_out_helper_cuda(), but there's more PRs for other ops.
Differential Revision: D27572759