copysign: port to structured kernel
#55040
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
💊 CI failures summary and remediationsAs of commit 2793daf (more details on the Dr. CI page):
1 failure not recognized by patterns:
This comment was automatically generated by Dr. CI (expand for details).Follow this link to opt-out of these comments for your Pull Requests.Please report bugs/suggestions to the (internal) Dr. CI Users group. |
ezyang
approved these changes
Mar 31, 2021
Contributor
ezyang
left a comment
ezyang
left a comment
There was a problem hiding this comment.
Thanks! Goes to show that we really need structured aliases lol
Contributor
|
@ezyang has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator. |
Codecov Report
@@ Coverage Diff @@
## master #55040 +/- ##
==========================================
- Coverage 77.43% 77.42% -0.01%
==========================================
Files 1893 1893
Lines 186440 186438 -2
==========================================
- Hits 144366 144352 -14
- Misses 42074 42086 +12 |
Contributor
bdhirsh
changed the title
copysign: port to structured kernel
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related #54945
This PR ports
copysignto structured, and thecopysign.Scalaroverloads are re-dispatched to the structured kernel.