Cancel redundant GHA workflows #54685
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
💊 CI failures summary and remediationsAs of commit 884af22 (more details on the Dr. CI page):
🕵️ 1 new failure recognized by patternsThe following CI failures do not appear to be due to upstream breakages:
|
Contributor
|
@samestep has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator. |
janeyx99
reviewed
Mar 25, 2021
| workflow_run: | ||
| types: | ||
| - requested | ||
| workflows: |
Contributor
There was a problem hiding this comment.
This is the most lightweight way for us to cancel redundant workflows, but it comes at the potential cost of needing to list out all the names of our workflows here. It would not be too difficult to write a script that would generate the names, but I wonder if there's a better, more GH supported way to accomplish the same thing. (e.g., if there were some way to just specify all workflows with a *).
Contributor
Contributor
Author
|
Unlanding this because I just realized that
are things we do not actually want to cancel (e.g. on Will follow up with a reland that filters this to only cancel redundant workflows from PRs. |
Contributor
|
This pull request has been reverted by 0b0a5dd. |
facebook-github-bot
pushed a commit
that referenced
this pull request
Mar 29, 2021
Summary: We've been using [pytorch/add-annotations-github-action](https://github.com/pytorch/add-annotations-github-action) to add annotations to PRs when they fail Flake8 or clang-tidy. Up until now, though, that functionality has only worked on PRs in pytorch/pytorch itself, not on PRs from forks. This PR fixes that using a technique from [this GitHub blog post](https://securitylab.github.com/research/github-actions-preventing-pwn-requests/) (also linked in a comment in this diff). Pull Request resolved: #54779 Test Plan: janeyx99 and I tested this in the same GitHub repo used to test #54685 and #54693, including with PRs from forks. Reviewed By: walterddr Differential Revision: D27364777 Pulled By: samestep fbshipit-source-id: a830d372d7bb3b2529fc633b707b44f2b6cf9baa
facebook-github-bot
pushed a commit
that referenced
this pull request
Mar 31, 2021
Summary: We've been using [pytorch/add-annotations-github-action](https://github.com/pytorch/add-annotations-github-action) to add annotations to PRs when they fail Flake8 or clang-tidy. Up until now, though, that functionality has only worked on PRs in pytorch/pytorch itself, not on PRs from forks. This PR fixes that using a technique from [this GitHub blog post](https://securitylab.github.com/research/github-actions-preventing-pwn-requests/) (also linked in a comment in this diff). Pull Request resolved: #54779 Test Plan: janeyx99 and I tested this in the same GitHub repo used to test #54685 and #54693, including with PRs from forks. Reviewed By: seemethere, xuzhao9 Differential Revision: D27470866 Pulled By: samestep fbshipit-source-id: d165b8e875d412b910592aa897163fb938d23365
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a lightweight workflow which runs when any of our GitHub Actions lint or test workflows start (currently just the three listed in the YAML in this PR's diff), and cancels redundant ones (e.g. if a PR author pushes several commits in rapid succession). Currently this isn't particularly impactful, but it would become more so if/when we add heavier workflows that run on PRs.
Initially we tried using
technote-space/auto-cancel-redundant-workflowinstead ofpotiuk/cancel-workflow-runs, but for some reason it the former doesn't seem to work even if triggered byworkflow_runwith theTARGET_RUN_IDinput set appropriately.Test plan:
@janeyx99 and I tested this in a separate GitHub repo, and confirmed that it successfully cancels redundant
push-triggered workflows on the source repo andpull_request-triggered workflows from forks.