[ready] torch.* doc update for Variable/Tensor merge, and other improvements #5443
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ssnl
changed the title
Collaborator
Author
|
changing |
ssnl
changed the title
ssnl
changed the title
colesbury
reviewed
Feb 28, 2018
torch/csrc/Module.cpp
Outdated
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
colesbury
pushed a commit
that referenced
this pull request
Mar 1, 2018
ssnl
force-pushed
the
var_doc
branch
3 times, most recently
from
8516fd6 to
9be20cc
Compare
jamesr66a
pushed a commit
to jamesr66a/pytorch
that referenced
this pull request
Mar 2, 2018
The nn.* counterpart of pytorch#5443 . Mostly removed Variable wrapper. Also added doc for nn.RReLU. Notice that torch.randn(*, requires_grad=True) isn't documented until pytorch#5462 is done.
fmassa
reviewed
Mar 3, 2018
torch/__init__.py
Outdated
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
Collaborator
Author
|
@colesbury could you take a look at this? Most of the changes are examples formatting and |
fmassa
reviewed
Mar 8, 2018
torch/_tensor_docs.py
Outdated
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
…inting style 2. Remove functions in torch/functional.py that are already implemented with native_function 3. Add set_detault_tensor_type doc
Collaborator
Author
|
@pytorchbot retest this please |
colesbury
approved these changes
Mar 8, 2018
Member
colesbury
left a comment
colesbury
left a comment
There was a problem hiding this comment.
changes lgtm assuming the tests pass
facebook-github-bot
pushed a commit
that referenced
this pull request
Sep 7, 2018
Summary: ~~This PR fixes #8525 by renaming `split_with_sizes` to `split` so that 2 `aten::split` ops are generated (previously `aten::split(self, int, int)` and `aten::split_with_sizes(self, int[], int)` were generated)~~ ~~`split_with_sizes` was made in PR #5443, but I don't see a reason for it to have a different name than `split` rather than just overload `split`.~~ This PR fixes #8525 by adding `register_special_ops.cpp` to mirror Python dispatching from `split` to `split` and `split_with_sizes` in [tensor.py](https://github.com/pytorch/pytorch/blob/master/torch/tensor.py#L279). It also fixes #8520 by adding an `int[]` wherever it sees `torch.Size` In a follow up PR this could also be used to fix some of the other `unknown builtin op` test errors. Pull Request resolved: #11051 Differential Revision: D9582443 Pulled By: driazati fbshipit-source-id: d27201f85937d72e45e851eaa1460dd3dd1b61a9
PenghuiCheng
pushed a commit
to PenghuiCheng/pytorch
that referenced
this pull request
Sep 11, 2018
Summary: ~~This PR fixes pytorch#8525 by renaming `split_with_sizes` to `split` so that 2 `aten::split` ops are generated (previously `aten::split(self, int, int)` and `aten::split_with_sizes(self, int[], int)` were generated)~~ ~~`split_with_sizes` was made in PR pytorch#5443, but I don't see a reason for it to have a different name than `split` rather than just overload `split`.~~ This PR fixes pytorch#8525 by adding `register_special_ops.cpp` to mirror Python dispatching from `split` to `split` and `split_with_sizes` in [tensor.py](https://github.com/pytorch/pytorch/blob/master/torch/tensor.py#L279). It also fixes pytorch#8520 by adding an `int[]` wherever it sees `torch.Size` In a follow up PR this could also be used to fix some of the other `unknown builtin op` test errors. Pull Request resolved: pytorch#11051 Differential Revision: D9582443 Pulled By: driazati fbshipit-source-id: d27201f85937d72e45e851eaa1460dd3dd1b61a9
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Commits:
-> floatfunctions become-> Tensor), and new printing styletorch/functional.pythat are already implemented with native_function. Move their doc to_torch_docs.pyand_tensor_docs.py.set_detault_tensor_typedoctorch.gels(Docs Error: Incorrect Output of torch.gels() Example #5431 )torch.split. The method behaves differently basing on the type of 2nd arg.splitandsplit_with_sizes. The Python API stays the same with the if-statement invariable.py.torch.splitfunctional form, this commit also movesfrom .functional import *to after ATen bindings intorch/__init__.py._add_doc_strto work on Python functions sotorch.splitdoc can remain in_torch_docs.py.partially addresses #5571
cc @vishwakftw hope that this doesn't conflict with what you are working on.