-
Notifications
You must be signed in to change notification settings - Fork 26.3k
[Fixup!] A few manual fixup after codemod #53469
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Fixup!] A few manual fixup after codemod #53469
Conversation
Summary: Test Plan: Reviewers: Subscribers: Tasks: Tags: [ghstack-poisoned]
💊 CI failures summary and remediationsAs of commit ff671ea (more details on the Dr. CI page):
🕵️ 26 new failures recognized by patternsThe following CI failures do not appear to be due to upstream breakages:
|
| Job | Step | Action |
|---|---|---|
| Test | 🔁 rerun |
ci.pytorch.org: 2 failed
- Failed:
pr/pytorch-linux-bionic-rocm4.0.1-py3.6 - Failed:
pr/caffe2-pytorch-linux-bionic-rocm4.0.1-py3.6-test
This comment was automatically generated by Dr. CI (expand for details).
Follow this link to opt-out of these comments for your Pull Requests.Please report bugs/suggestions to the (internal) Dr. CI Users group.
Summary: Test Plan: Reviewers: Subscribers: Tasks: Tags: Differential Revision: [D26873801](https://our.internmc.facebook.com/intern/diff/D26873801) [ghstack-poisoned]
Summary: Test Plan: Reviewers: Subscribers: Tasks: Tags: Differential Revision: [D26873801](https://our.internmc.facebook.com/intern/diff/D26873801) [ghstack-poisoned]
Summary: Test Plan: Reviewers: Subscribers: Tasks: Tags: Differential Revision: [D26873801](https://our.internmc.facebook.com/intern/diff/D26873801) [ghstack-poisoned]
Summary:
1. Fix methods change Scalar paramaeters -- const Scalar& doesn't allow change.
2. Introduce ScalarList = ArrayRef<Scalar>
3. Some minor manual Scalar parameter changes.
Missing, or Scalar& -> const Scalar&
Test Plan:
Reviewers:
Subscribers:
Tasks:
Tags:
Differential Revision: [D26873801](https://our.internmc.facebook.com/intern/diff/D26873801)
[ghstack-poisoned]
|
Reorganize the stack so there are only two PRs in the stack (see #53583) . Close PRs no longer exist in stack. |
Stack from ghstack:
Summary:
1. Fix methods change Scalar paramaeters -- const Scalar& doesn't allow change.
2. Introduce ScalarList = ArrayRef
3. Some minor manual Scalar parameter changes.
Missing, or Scalar& -> const Scalar&
Test Plan:
Reviewers:
Subscribers:
Tasks:
Tags:
Differential Revision: D26873801