docker: Update default cuda => 11.1 #53299
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We no longer build binaries for CUDA 11.0 so let's ensure that we have build for CUDA 11.1 by default instead Signed-off-by: Eli Uriegas <[email protected]>
Contributor
💊 CI failures summary and remediationsAs of commit c895192 (more details on the Dr. CI page): ✅ None of the CI failures appear to be your fault 💚
🚧 1 fixed upstream failure:These were probably caused by upstream breakages that were already fixed.
Please rebase on the
|
seemethere
commented
Mar 4, 2021
| # | ||
| # If you do not use buildkit you are not going to have a good time | ||
| # | ||
| # For reference: |
Member
Author
There was a problem hiding this comment.
Trailing whitespace is not cool kids
Contributor
There was a problem hiding this comment.
Would it make sense to add a lint check for trailing whitespace? (similar to our existing check for tabs)
Member
Author
There was a problem hiding this comment.
Probably, I don’t think trailing whitespace is acceptable anywhere in this repository outside of places we can’t change it like third_party
Contributor
There was a problem hiding this comment.
Cool, I'll do that soon then
xuzhao9
reviewed
Mar 4, 2021
| ARG CUDA_VERSION=11.0 | ||
| ARG CUDA_CHANNEL=defaults | ||
| ARG CUDA_VERSION=11.1 | ||
| ARG CUDA_CHANNEL=nvidia |
Contributor
There was a problem hiding this comment.
Do we also to change CUDA_CHANNEL in docker.Makefile as well?
Also, is conda-forge channel not used anymore?
Contributor
There was a problem hiding this comment.
AFAIK cudatoolkit=11.1 only exist in conda-forge
Contributor
There was a problem hiding this comment.
AFAIK cudatoolkit=11.1 only exist in conda-forge
It exists in the nvidia channel as well: https://anaconda.org/nvidia/cudatoolkit/files
xuzhao9
approved these changes
Mar 4, 2021
walterddr
approved these changes
Mar 4, 2021
This was referenced Mar 4, 2021
Contributor
facebook-github-bot
left a comment
facebook-github-bot
left a comment
There was a problem hiding this comment.
@seemethere has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
Contributor
|
@seemethere merged this pull request in 474fe7d. |
facebook-github-bot
pushed a commit
that referenced
this pull request
Mar 6, 2021
Summary: Context: #53299 (comment) These are the only hand-written parts of this diff: - the addition to `.github/workflows/lint.yml` - the file endings changed in these four files (to appease FB-internal land-blocking lints): - `GLOSSARY.md` - `aten/src/ATen/core/op_registration/README.md` - `scripts/README.md` - `torch/csrc/jit/codegen/fuser/README.md` The rest was generated by running this command (on macOS): ``` git grep -I -l ' $' -- . ':(exclude)**/contrib/**' ':(exclude)third_party' | xargs gsed -i 's/ *$//' ``` I looked over the auto-generated changes and didn't see anything that looked problematic. Pull Request resolved: #53406 Test Plan: This run (after adding the lint but before removing existing trailing spaces) failed: - https://github.com/pytorch/pytorch/runs/2043032377 This run (on the tip of this PR) succeeded: - https://github.com/pytorch/pytorch/runs/2043296348 Reviewed By: walterddr, seemethere Differential Revision: D26856620 Pulled By: samestep fbshipit-source-id: 3f0de7f7c2e4b0f1c089eac9b5085a58dd7e0d97
facebook-github-bot
pushed a commit
that referenced
this pull request
Mar 12, 2021
…it (#53316) Summary: Pull Request resolved: #53316 Test Plan: Nightly Docker build CI This is a follow-up PR after docker moved default CUDA => 11.1. Only merge this after #53299 is committed. Reviewed By: albanD Differential Revision: D26996287 Pulled By: xuzhao9 fbshipit-source-id: 0c2e03da41d036d7aada3e07d479a3dede219f58
xsacha
pushed a commit
to xsacha/pytorch
that referenced
this pull request
Mar 31, 2021
Summary: We no longer build binaries for CUDA 11.0 so let's ensure that we have build for CUDA 11.1 by default instead Signed-off-by: Eli Uriegas <[email protected]> Pull Request resolved: pytorch#53299 Reviewed By: anjali411 Differential Revision: D26857194 Pulled By: seemethere fbshipit-source-id: 6094913922c0da832b96e5e49a67369d69d0b8ad
xsacha
pushed a commit
to xsacha/pytorch
that referenced
this pull request
Mar 31, 2021
Summary: Context: pytorch#53299 (comment) These are the only hand-written parts of this diff: - the addition to `.github/workflows/lint.yml` - the file endings changed in these four files (to appease FB-internal land-blocking lints): - `GLOSSARY.md` - `aten/src/ATen/core/op_registration/README.md` - `scripts/README.md` - `torch/csrc/jit/codegen/fuser/README.md` The rest was generated by running this command (on macOS): ``` git grep -I -l ' $' -- . ':(exclude)**/contrib/**' ':(exclude)third_party' | xargs gsed -i 's/ *$//' ``` I looked over the auto-generated changes and didn't see anything that looked problematic. Pull Request resolved: pytorch#53406 Test Plan: This run (after adding the lint but before removing existing trailing spaces) failed: - https://github.com/pytorch/pytorch/runs/2043032377 This run (on the tip of this PR) succeeded: - https://github.com/pytorch/pytorch/runs/2043296348 Reviewed By: walterddr, seemethere Differential Revision: D26856620 Pulled By: samestep fbshipit-source-id: 3f0de7f7c2e4b0f1c089eac9b5085a58dd7e0d97
xsacha
pushed a commit
to xsacha/pytorch
that referenced
this pull request
Mar 31, 2021
…it (pytorch#53316) Summary: Pull Request resolved: pytorch#53316 Test Plan: Nightly Docker build CI This is a follow-up PR after docker moved default CUDA => 11.1. Only merge this after pytorch#53299 is committed. Reviewed By: albanD Differential Revision: D26996287 Pulled By: xuzhao9 fbshipit-source-id: 0c2e03da41d036d7aada3e07d479a3dede219f58
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We no longer build binaries for CUDA 11.0 so let's ensure that we have
build for CUDA 11.1 by default instead
Signed-off-by: Eli Uriegas [email protected]