Skip to content

Fix boxing/unboxing for Scalar bool values #53228

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
smessmer wants to merge 14 commits into from
Closed

Fix boxing/unboxing for Scalar bool values #53228

smessmer wants to merge 14 commits into from

Conversation

@smessmer
Copy link
Contributor

@smessmer smessmer commented Mar 4, 2021 •
edited
Loading

Stack from ghstack:

Previously, if a Scalar value contained a bool and was put into and then out of an IValue, it would magically transform to an int.
This PR fixes that and preserves the bool-ness.

Differential Revision: D26800346

@smessmer
Fix boxing/unboxing for Scalar bool values
c3ba98f 
Previously, if a Scalar value contained a bool and was put into and then out of an IValue, it would magically transform to an int.
This PR fixes that and preserves the bool-ness.

Differential Revision: [D26800346](https://our.internmc.facebook.com/intern/diff/D26800346/)

[ghstack-poisoned]
@facebook-github-bot
Copy link
Contributor

facebook-github-bot commented Mar 4, 2021 •
edited
Loading

💊 CI failures summary and remediations

As of commit 0f7cf68 (more details on the Dr. CI page):

  • 1/1 failures introduced in this PR

🕵️ 1 new failure recognized by patterns

The following CI failures do not appear to be due to upstream breakages:

See CircleCI build pytorch_ios_12_0_0_x86_64_build (1/1)

Step: "Spin up environment" (full log | diagnosis details | 🔁 rerun)

Waiting for a VM assignment: .................................................. 
Build-agent version 1.0.55188-cc884bc1 (2021-04-06T15:23:45+0000)
Creating a dedicated VM with xcode:12.0 image
Waiting for a VM assignment: ..................................................
Assigned VM request id: 31557807
  provisioning: 
VM 'default-b03f180b-8e6c-406b-976f-64adf7484d42' has been created
Initializing agent


Unexpected environment preparation error: failed to upload runner config: failed to scp: signal: killed
This comment was automatically generated by Dr. CI (expand for details).Follow this link to opt-out of these comments for your Pull Requests.

Please report bugs/suggestions to the (internal) Dr. CI Users group.

This was referenced Mar 4, 2021
Closed
Closed
Merged
@smessmer smessmer requested review from bhosmer and ezyang March 4, 2021 01:03
ezyang
ezyang approved these changes Mar 4, 2021
View reviewed changes
Copy link
Contributor

@ezyang ezyang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch!

@smessmer
Update on "Fix boxing/unboxing for Scalar bool values"
d4bd8bd 
Previously, if a Scalar value contained a bool and was put into and then out of an IValue, it would magically transform to an int.
This PR fixes that and preserves the bool-ness.

Differential Revision: [D26800346](https://our.internmc.facebook.com/intern/diff/D26800346/)

[ghstack-poisoned]
This was referenced Mar 8, 2021
Closed
Closed
@smessmer
Update on "Fix boxing/unboxing for Scalar bool values"
5922d63 
Previously, if a Scalar value contained a bool and was put into and then out of an IValue, it would magically transform to an int.
This PR fixes that and preserves the bool-ness.

Differential Revision: [D26800346](https://our.internmc.facebook.com/intern/diff/D26800346/)

[ghstack-poisoned]
This was referenced Mar 9, 2021
Closed
Closed
Closed
smessmer added 7 commits March 9, 2021 15:39
@smessmer
Update on "Fix boxing/unboxing for Scalar bool values"
f888a40 
Previously, if a Scalar value contained a bool and was put into and then out of an IValue, it would magically transform to an int.
This PR fixes that and preserves the bool-ness.

Differential Revision: [D26800346](https://our.internmc.facebook.com/intern/diff/D26800346/)

[ghstack-poisoned]
@smessmer
Update on "Fix boxing/unboxing for Scalar bool values"
4af96dd 
Previously, if a Scalar value contained a bool and was put into and then out of an IValue, it would magically transform to an int.
This PR fixes that and preserves the bool-ness.

Differential Revision: [D26800346](https://our.internmc.facebook.com/intern/diff/D26800346/)

[ghstack-poisoned]
@smessmer
Update on "Fix boxing/unboxing for Scalar bool values"
2b876c3 
Previously, if a Scalar value contained a bool and was put into and then out of an IValue, it would magically transform to an int.
This PR fixes that and preserves the bool-ness.

Differential Revision: [D26800346](https://our.internmc.facebook.com/intern/diff/D26800346/)

[ghstack-poisoned]
@smessmer
Update on "Fix boxing/unboxing for Scalar bool values"
61f79fc 
Previously, if a Scalar value contained a bool and was put into and then out of an IValue, it would magically transform to an int.
This PR fixes that and preserves the bool-ness.

Differential Revision: [D26800346](https://our.internmc.facebook.com/intern/diff/D26800346/)

[ghstack-poisoned]
@smessmer
Update on "Fix boxing/unboxing for Scalar bool values"
f0f4726 
Previously, if a Scalar value contained a bool and was put into and then out of an IValue, it would magically transform to an int.
This PR fixes that and preserves the bool-ness.

Differential Revision: [D26800346](https://our.internmc.facebook.com/intern/diff/D26800346/)

[ghstack-poisoned]
@smessmer
Update on "Fix boxing/unboxing for Scalar bool values"
40d9501 
Previously, if a Scalar value contained a bool and was put into and then out of an IValue, it would magically transform to an int.
This PR fixes that and preserves the bool-ness.

Differential Revision: [D26800346](https://our.internmc.facebook.com/intern/diff/D26800346/)

[ghstack-poisoned]
@smessmer
Update on "Fix boxing/unboxing for Scalar bool values"
4066c3f 
Previously, if a Scalar value contained a bool and was put into and then out of an IValue, it would magically transform to an int.
This PR fixes that and preserves the bool-ness.

Differential Revision: [D26800346](https://our.internmc.facebook.com/intern/diff/D26800346/)

[ghstack-poisoned]
@smessmer smessmer mentioned this pull request Apr 5, 2021
Closed
smessmer added 4 commits April 5, 2021 17:14
@smessmer
Update on "Fix boxing/unboxing for Scalar bool values"
515ed0c 
Previously, if a Scalar value contained a bool and was put into and then out of an IValue, it would magically transform to an int.
This PR fixes that and preserves the bool-ness.

Differential Revision: [D26800346](https://our.internmc.facebook.com/intern/diff/D26800346/)

[ghstack-poisoned]
@smessmer
Update on "Fix boxing/unboxing for Scalar bool values"
357b502 
Previously, if a Scalar value contained a bool and was put into and then out of an IValue, it would magically transform to an int.
This PR fixes that and preserves the bool-ness.

Differential Revision: [D26800346](https://our.internmc.facebook.com/intern/diff/D26800346/)

[ghstack-poisoned]
@smessmer
Update on "Fix boxing/unboxing for Scalar bool values"
2c906a3 
Previously, if a Scalar value contained a bool and was put into and then out of an IValue, it would magically transform to an int.
This PR fixes that and preserves the bool-ness.

Differential Revision: [D26800346](https://our.internmc.facebook.com/intern/diff/D26800346/)

[ghstack-poisoned]
@smessmer
Update on "Fix boxing/unboxing for Scalar bool values"
0f7cf68 
Previously, if a Scalar value contained a bool and was put into and then out of an IValue, it would magically transform to an int.
This PR fixes that and preserves the bool-ness.

Differential Revision: [D26800346](https://our.internmc.facebook.com/intern/diff/D26800346/)

[ghstack-poisoned]
@facebook-github-bot
Copy link
Contributor

facebook-github-bot commented Apr 7, 2021

This pull request has been merged in 35caae6.

@facebook-github-bot facebook-github-bot deleted the gh/smessmer/300/head branch April 10, 2021 14:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ezyang ezyang ezyang approved these changes

+1 more reviewer

@bhosmer bhosmer bhosmer approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

cla signed Merged

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@smessmer @facebook-github-bot @ezyang @bhosmer