Skip to content

Conversation

@quickwritereader
Copy link
Contributor

@quickwritereader quickwritereader commented Jan 27, 2021

Fixes #51132

@facebook-github-bot
Copy link
Contributor

facebook-github-bot commented Jan 27, 2021

💊 CI failures summary and remediations

As of commit 4a3c37d (more details on the Dr. CI page):


💚 💚 Looks good so far! There are no failures yet. 💚 💚


This comment was automatically generated by Dr. CI (expand for details).Follow this link to opt-out of these comments for your Pull Requests.

Please report bugs/suggestions to the (internal) Dr. CI Users group.

@dncliss
Copy link
Contributor

dncliss commented Jan 27, 2021

A local trial build, with this change, does indeed confirm the error no longer appears.

@codecov
Copy link

codecov bot commented Jan 27, 2021

Codecov Report

Merging #51217 (4a3c37d) into master (e429d05) will increase coverage by 0.11%.
The diff coverage is 88.38%.

@@            Coverage Diff             @@
##           master   #51217      +/-   ##
==========================================
+ Coverage   80.76%   80.88%   +0.11%     
==========================================
  Files        1867     1931      +64     
  Lines      201584   210560    +8976     
==========================================
+ Hits       162817   170302    +7485     
- Misses      38767    40258    +1491     

Copy link
Contributor

@ezyang ezyang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"whoops"

Copy link
Contributor

@facebook-github-bot facebook-github-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ezyang has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

@facebook-github-bot
Copy link
Contributor

@ezyang merged this pull request in 8b27c2c.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Undefined reference errors to VSX symbols during build (link phase) on PPC64LE

5 participants