[ONNX] Fix param names (#50764)#50955
Closed
BowenBao wants to merge 5 commits intogh/BowenBao/10/basefrom
Closed
Conversation
Preserve name of parameters for ONNX. Looks like output->copyMetadata(input) API is giving the same debugName to the output. So the name of the original input is changed. This update avoid the name change by just copying the type. [ghstack-poisoned]
This was referenced Jan 22, 2021
[ONNX] Add logical_and, logical_or, logical_xor torch op support in pytorch exporter (#50570)
#50909
Closed
facebook-github-bot
added
the
oncall: jit
Contributor
💊 CI failures summary and remediationsAs of commit 61f75ca (more details on the Dr. CI page):
This comment was automatically generated by Dr. CI (expand for details).Follow this link to opt-out of these comments for your Pull Requests.Please report bugs/suggestions to the (internal) Dr. CI Users group. |
Preserve name of parameters for ONNX. Looks like output->copyMetadata(input) API is giving the same debugName to the output. So the name of the original input is changed. This update avoid the name change by just copying the type. Differential Revision: [D26023932](https://our.internmc.facebook.com/intern/diff/D26023932) [ghstack-poisoned]
Preserve name of parameters for ONNX. Looks like output->copyMetadata(input) API is giving the same debugName to the output. So the name of the original input is changed. This update avoid the name change by just copying the type. [ghstack-poisoned]
Preserve name of parameters for ONNX. Looks like output->copyMetadata(input) API is giving the same debugName to the output. So the name of the original input is changed. This update avoid the name change by just copying the type. Differential Revision: [D26050880](https://our.internmc.facebook.com/intern/diff/D26050880) [ghstack-poisoned]
Preserve name of parameters for ONNX. Looks like output->copyMetadata(input) API is giving the same debugName to the output. So the name of the original input is changed. This update avoid the name change by just copying the type. Differential Revision: [D26050880](https://our.internmc.facebook.com/intern/diff/D26050880) [ghstack-poisoned]
Contributor
|
@SplitInfinity merged this pull request in e2eb97d. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stack from ghstack:
Preserve name of parameters for ONNX.
Looks like output->copyMetadata(input) API is giving the same debugName to the output. So the name of the original input is changed. This update avoid the name change by just copying the type.
Differential Revision: D26050880