Merged
Conversation
facebook-github-bot
added
cla signed
oncall: jit
KsenijaS
reviewed
Jan 21, 2021
BowenBao
approved these changes
Jan 22, 2021
BowenBao
added a commit
that referenced
this pull request
Jan 22, 2021
Preserve name of parameters for ONNX. Looks like output->copyMetadata(input) API is giving the same debugName to the output. So the name of the original input is changed. This update avoid the name change by just copying the type. [ghstack-poisoned]
This was referenced Jan 22, 2021
[ONNX] Add logical_and, logical_or, logical_xor torch op support in pytorch exporter (#50570)
#50909
Closed
BowenBao
added a commit
that referenced
this pull request
Jan 22, 2021
Preserve name of parameters for ONNX. Looks like output->copyMetadata(input) API is giving the same debugName to the output. So the name of the original input is changed. This update avoid the name change by just copying the type. Differential Revision: [D26023932](https://our.internmc.facebook.com/intern/diff/D26023932) [ghstack-poisoned]
BowenBao
added a commit
that referenced
this pull request
Jan 25, 2021
Preserve name of parameters for ONNX. Looks like output->copyMetadata(input) API is giving the same debugName to the output. So the name of the original input is changed. This update avoid the name change by just copying the type. [ghstack-poisoned]
BowenBao
added a commit
that referenced
this pull request
Jan 25, 2021
Preserve name of parameters for ONNX. Looks like output->copyMetadata(input) API is giving the same debugName to the output. So the name of the original input is changed. This update avoid the name change by just copying the type. Differential Revision: [D26050880](https://our.internmc.facebook.com/intern/diff/D26050880) [ghstack-poisoned]
BowenBao
added a commit
that referenced
this pull request
Jan 26, 2021
Preserve name of parameters for ONNX. Looks like output->copyMetadata(input) API is giving the same debugName to the output. So the name of the original input is changed. This update avoid the name change by just copying the type. Differential Revision: [D26050880](https://our.internmc.facebook.com/intern/diff/D26050880) [ghstack-poisoned]
facebook-github-bot
pushed a commit
that referenced
this pull request
Jan 28, 2021
Summary: Pull Request resolved: #50955 Preserve name of parameters for ONNX. Looks like output->copyMetadata(input) API is giving the same debugName to the output. So the name of the original input is changed. This update avoid the name change by just copying the type. Test Plan: Imported from OSS Reviewed By: pbelevich Differential Revision: D26050880 Pulled By: SplitInfinity fbshipit-source-id: 8b04e41e6df7f33c5c9c873fb323c21462fc125b
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Preserve name of parameters for ONNX.
Looks like output->copyMetadata(input) API is giving the same debugName to the output. So the name of the original input is changed. This update avoid the name change by just copying the type.