[tools] Update clang-format linux hash #50520
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
[ghstack-poisoned]
Contributor
💊 CI failures summary and remediationsAs of commit 43dd3c0 (more details on the Dr. CI page): 💚 💚 Looks good so far! There are no failures yet. 💚 💚 This comment was automatically generated by Dr. CI (expand for details).Follow this link to opt-out of these comments for your Pull Requests.Please report bugs/suggestions to the (internal) Dr. CI Users group. |
[ghstack-poisoned]
[ghstack-poisoned]
SplitInfinity
changed the title
**Summary** The new version of `clang-format` for linux64 that was uploaded to S3 earlier this week was dynamically linked to fbcode's custom platform. A new binary has been uploaded that statically links against `libgcc` and `libstdc++`, which seems to have fixed this issue. Ideally, all libraries would be statically linked. **Test Plan** `clang-format` workflow passes on this PR and output shows that it successfully downloaded, verified and ran. [ghstack-poisoned]
SplitInfinity
changed the title
SplitInfinity
pushed a commit
that referenced
this pull request
Jan 14, 2021
**Summary** The new version of `clang-format` for linux64 that was uploaded to S3 earlier this week was dynamically linked to fbcode's custom platform. A new binary has been uploaded that statically links against `libgcc` and `libstdc++`, which seems to have fixed this issue. Ideally, all libraries would be statically linked. **Test Plan** `clang-format` workflow passes on this PR and output shows that it successfully downloaded, verified and ran. ghstack-source-id: 77136b7 Pull Request resolved: #50520
seemethere
approved these changes
Jan 14, 2021
Contributor
|
@SplitInfinity merged this pull request in 52ea372. |
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack from ghstack:
Summary
The new version of
clang-formatfor linux64 that was uploaded to S3earlier this week was dynamically linked to fbcode's custom platform.
A new binary has been uploaded that statically links against
libgccand
libstdc++, which seems to have fixed this issue. Ideally, alllibraries would be statically linked.
Test Plan
clang-formatworkflow passes on this PR and output shows that itsuccessfully downloaded, verified and ran.
Differential Revision: D25908868