[ONNX] Support gelu for fp16 export#50487
Merged
BowenBao merged 5 commits intopytorch:onnx_ms_1from Jan 21, 2021
Merged
Conversation
Contributor
💊 CI failures summary and remediationsAs of commit ffb185e (more details on the Dr. CI page):
❄️ 3 failures tentatively classified as flakybut reruns have not yet been triggered to confirm:
|
spandantiwari
force-pushed
the
onnx_ms_1
branch
from
33f26ed to
4db8cb4
Compare
BowenBao
force-pushed
the
onnx_mp_gelu
branch
from
fd6c0cd to
b686cb4
Compare
neginraoof
approved these changes
Jan 14, 2021
|
|
||
| from test_pytorch_onnx_onnxruntime import TestONNXRuntime | ||
|
|
||
| class TestONNXRuntime_cuda(unittest.TestCase): |
Contributor
There was a problem hiding this comment.
Thanks for setting this up. Are you going to add a CI job for these test?
Collaborator
Author
There was a problem hiding this comment.
I see that this test is already added to CI job accidentally, i'll update to disable it for now.
BowenBao
added a commit
that referenced
this pull request
Jan 21, 2021
Need to replace dtype of export created scalars from float to double. (In torch implicit conversion logic, python numbers are double) Test case skipped in CI due to that current CI job env does not have CUDA support. [ghstack-poisoned]
This was referenced Jan 21, 2021
[ONNX] Add logical_and, logical_or, logical_xor torch op support in pytorch exporter (#50570)
#50909
Closed
BowenBao
added a commit
that referenced
this pull request
Jan 21, 2021
Need to replace dtype of export created scalars from float to double. (In torch implicit conversion logic, python numbers are double) Test case skipped in CI due to that current CI job env does not have CUDA support. [ghstack-poisoned]
BowenBao
added a commit
that referenced
this pull request
Jan 22, 2021
Need to replace dtype of export created scalars from float to double. (In torch implicit conversion logic, python numbers are double) Test case skipped in CI due to that current CI job env does not have CUDA support. [ghstack-poisoned]
This was referenced Jan 22, 2021
BowenBao
added a commit
that referenced
this pull request
Jan 22, 2021
Need to replace dtype of export created scalars from float to double. (In torch implicit conversion logic, python numbers are double) Test case skipped in CI due to that current CI job env does not have CUDA support. Differential Revision: [D26023938](https://our.internmc.facebook.com/intern/diff/D26023938) [ghstack-poisoned]
BowenBao
added a commit
that referenced
this pull request
Jan 25, 2021
Need to replace dtype of export created scalars from float to double. (In torch implicit conversion logic, python numbers are double) Test case skipped in CI due to that current CI job env does not have CUDA support. [ghstack-poisoned]
BowenBao
added a commit
that referenced
this pull request
Jan 25, 2021
Need to replace dtype of export created scalars from float to double. (In torch implicit conversion logic, python numbers are double) Test case skipped in CI due to that current CI job env does not have CUDA support. Differential Revision: [D26050889](https://our.internmc.facebook.com/intern/diff/D26050889) [ghstack-poisoned]
BowenBao
added a commit
that referenced
this pull request
Jan 26, 2021
Need to replace dtype of export created scalars from float to double. (In torch implicit conversion logic, python numbers are double) Test case skipped in CI due to that current CI job env does not have CUDA support. Differential Revision: [D26050889](https://our.internmc.facebook.com/intern/diff/D26050889) [ghstack-poisoned]
facebook-github-bot
pushed a commit
that referenced
this pull request
Jan 28, 2021
Summary: Pull Request resolved: #50911 Need to replace dtype of export created scalars from float to double. (In torch implicit conversion logic, python numbers are double) Test case skipped in CI due to that current CI job env does not have CUDA support. Test Plan: Imported from OSS Reviewed By: pbelevich Differential Revision: D26050889 Pulled By: SplitInfinity fbshipit-source-id: 1fdde23a68d4793e6b9a82840acc213e5c3aa760
BowenBao
added a commit
to BowenBao/pytorch
that referenced
this pull request
Jan 28, 2021
Need to replace dtype of export created scalars from float to double. (In torch implicit conversion logic, python numbers are double) Test case skipped in CI due to that current CI job env does not have CUDA support. ghstack-source-id: 1be05b0 Pull Request resolved: pytorch#50911
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Need to replace dtype of export created scalars from float to double. (In torch implicit conversion logic, python numbers are double)
Test case skipped in CI due to that current CI job env does not have CUDA support.