Skip to content

[ONNX] Support opset13 Squeeze and Unsqueeze#50150

Merged
BowenBao merged 12 commits intopytorch:onnx_ms_1from
BowenBao:onnx_opset13_squeeze
Jan 15, 2021
Merged

[ONNX] Support opset13 Squeeze and Unsqueeze#50150
BowenBao merged 12 commits intopytorch:onnx_ms_1from
BowenBao:onnx_opset13_squeeze

Conversation

@BowenBao
Copy link
Copy Markdown
Collaborator

@BowenBao BowenBao commented Jan 6, 2021

In opset 13, squeeze/unsqueeze is updated to take axes as input, instead of attribute.

@facebook-github-bot facebook-github-bot added cla signed oncall: jit Add this issue/PR to JIT oncall triage queue labels Jan 6, 2021
@facebook-github-bot
Copy link
Copy Markdown
Contributor

facebook-github-bot commented Jan 6, 2021 •
edited
Loading

💊 CI failures summary and remediations

As of commit 3ddd7b3 (more details on the Dr. CI page):

❄️ 1 failure tentatively classified as flaky

but reruns have not yet been triggered to confirm:

See CircleCI build pytorch_linux_xenial_cuda10_2_cudnn7_py3_gcc7_test2 (1/1)

Step: "Run tests" (full log | diagnosis details | 🔁 rerun) ❄️

Jan 14 09:49:47 RuntimeError: CUDA error: an illegal memory access was encountered 
Jan 14 09:49:47                        ~~~~ <--- HERE
Jan 14 09:49:47 RuntimeError: CUDA error: an illegal memory access was encountered
Jan 14 09:49:47 
Jan 14 09:49:47 
Jan 14 09:49:47 ======================================================================
Jan 14 09:49:47 ERROR [0.205s]: test_where_and_typing (__main__.TestTEFuser)
Jan 14 09:49:47 ----------------------------------------------------------------------
Jan 14 09:49:47 Traceback (most recent call last):
Jan 14 09:49:47   File "test_jit_fuser_te.py", line 1142, in test_where_and_typing
Jan 14 09:49:47     x = torch.randn(4, 4, dtype=torch.double, device=device)
Jan 14 09:49:47 RuntimeError: CUDA error: an illegal memory access was encountered
Jan 14 09:49:47 
Jan 14 09:49:47 ======================================================================
Jan 14 09:49:47 ERROR [0.177s]: test_zero_element_tensors_cuda (__main__.TestTEFuser)
Jan 14 09:49:47 ----------------------------------------------------------------------
Jan 14 09:49:47 Traceback (most recent call last):
Jan 14 09:49:47   File "/opt/conda/lib/python3.6/site-packages/torch/testing/_internal/common_utils.py", line 888, in wrapper
Jan 14 09:49:47     method(*args, **kwargs)
Jan 14 09:49:47   File "test_jit_fuser_te.py", line 178, in test_zero_element_tensors_cuda
Jan 14 09:49:47     self._test_zero_element_tensors(device="cuda")
Jan 14 09:49:47   File "test_jit_fuser_te.py", line 174, in _test_zero_element_tensors

ci.pytorch.org: 1 failed

This comment was automatically generated by Dr. CI (expand for details).Follow this link to opt-out of these comments for your Pull Requests.

Please report bugs/suggestions to the (internal) Dr. CI Users group.

fatcat-z
fatcat-z reviewed Jan 8, 2021
View reviewed changes
neginraoof
neginraoof reviewed Jan 11, 2021
View reviewed changes
neginraoof
neginraoof reviewed Jan 11, 2021
View reviewed changes
@fatcat-z fatcat-z mentioned this pull request Jan 14, 2021
Closed
@BowenBao BowenBao force-pushed the onnx_opset13_squeeze branch from 77629fc to 2a3f3e8 Compare January 14, 2021 05:43
@BowenBao BowenBao force-pushed the onnx_opset13_squeeze branch from 3ddd7b3 to 1188d94 Compare January 15, 2021 00:39
neginraoof
neginraoof approved these changes Jan 15, 2021
View reviewed changes
Copy link
Copy Markdown
Contributor

@neginraoof neginraoof left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks!

@BowenBao BowenBao merged commit 2d2b6f2 into pytorch:onnx_ms_1 Jan 15, 2021
BowenBao added a commit that referenced this pull request Jan 21, 2021
@BowenBao
[ONNX] Support opset13 Squeeze and Unsqueeze (#50150)
a1f2867 
In opset 13, squeeze/unsqueeze is updated to take axes as input, instead of attribute.

[ghstack-poisoned]
This was referenced Jan 21, 2021
Closed
Closed
This was referenced Jan 21, 2021
Closed
Closed
Closed
Closed
Closed
BowenBao added a commit that referenced this pull request Jan 21, 2021
@BowenBao
Update on "[ONNX] Support opset13 Squeeze and Unsqueeze (#50150)"
7e84edf 
In opset 13, squeeze/unsqueeze is updated to take axes as input, instead of attribute.

[ghstack-poisoned]
BowenBao added a commit that referenced this pull request Jan 22, 2021
@BowenBao
Update on "[ONNX] Support opset13 Squeeze and Unsqueeze (#50150)"
ca92fe7 
In opset 13, squeeze/unsqueeze is updated to take axes as input, instead of attribute.

[ghstack-poisoned]
This was referenced Jan 22, 2021
Closed
Closed
BowenBao added a commit that referenced this pull request Jan 22, 2021
@BowenBao
Update on "[ONNX] Support opset13 Squeeze and Unsqueeze (#50150)"
19fbffd 
In opset 13, squeeze/unsqueeze is updated to take axes as input, instead of attribute.

Differential Revision: [D26023937](https://our.internmc.facebook.com/intern/diff/D26023937)

[ghstack-poisoned]
BowenBao added a commit that referenced this pull request Jan 25, 2021
@BowenBao
Update on "[ONNX] Support opset13 Squeeze and Unsqueeze (#50150)"
36f7387 
In opset 13, squeeze/unsqueeze is updated to take axes as input, instead of attribute.

[ghstack-poisoned]
BowenBao added a commit that referenced this pull request Jan 25, 2021
@BowenBao
Update on "[ONNX] Support opset13 Squeeze and Unsqueeze (#50150)"
4afca34 
In opset 13, squeeze/unsqueeze is updated to take axes as input, instead of attribute.

Differential Revision: [D26050883](https://our.internmc.facebook.com/intern/diff/D26050883)

[ghstack-poisoned]
BowenBao added a commit that referenced this pull request Jan 26, 2021
@BowenBao
Update on "[ONNX] Support opset13 Squeeze and Unsqueeze (#50150)"
e31ed3e 
In opset 13, squeeze/unsqueeze is updated to take axes as input, instead of attribute.

Differential Revision: [D26050883](https://our.internmc.facebook.com/intern/diff/D26050883)

[ghstack-poisoned]
facebook-github-bot pushed a commit that referenced this pull request Jan 28, 2021
@BowenBao @facebook-github-bot
[ONNX] Support opset13 Squeeze and Unsqueeze (#50150) (#50906)
7e4c956 
Summary:
Pull Request resolved: #50906

In opset 13, squeeze/unsqueeze is updated to take axes as input, instead of attribute.

Test Plan: Imported from OSS

Reviewed By: pbelevich

Differential Revision: D26050883

Pulled By: SplitInfinity

fbshipit-source-id: 7b5faf0e016d476bc75cbf2bfee6918d77e8aecd
BowenBao added a commit to BowenBao/pytorch that referenced this pull request Jan 28, 2021
@BowenBao
[ONNX] Support opset13 Squeeze and Unsqueeze (pytorch#50150)
d6702b3 
In opset 13, squeeze/unsqueeze is updated to take axes as input, instead of attribute.

ghstack-source-id: 8934ace
Pull Request resolved: pytorch#50906

fix clang-format
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@fatcat-z fatcat-z fatcat-z approved these changes

+1 more reviewer

@neginraoof neginraoof neginraoof approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

cla signed oncall: jit Add this issue/PR to JIT oncall triage queue open source

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@BowenBao @facebook-github-bot @neginraoof @fatcat-z @pytorchbot