[ONNX] Enable opset 13 ops by neginraoof · Pull Request #49612 · pytorch/pytorch

neginraoof · 2020-12-18T20:01:05Z

Duplicate #46903

…neraoof/opset13

…oof/opset13 # Conflicts: # .jenkins/caffe2/test.sh

…oof/opset13

)

facebook-github-bot · 2020-12-18T20:01:27Z

💊 CI failures summary and remediations

As of commit 70aa5c4 (more details on the Dr. CI page):

2/2 failures introduced in this PR

🕵️ 2 new failures recognized by patterns

The following CI failures do not appear to be due to upstream breakages:

pytorch_linux_backward_compatibility_check_test (1/2)

Step: "Run tests" (full log | diagnosis details | 🔁 rerun)

Jan 05 22:23:41 The PR is introducing backward incompatible changes to the operator library. Please contact PyTorch team to confirm whether this change is wanted or not.

Jan 05 22:23:41 processing existing schema:  alltoall(__torch__.torch.classes.dist_c10d.ProcessGroup _0, Tensor[] _1, Tensor[] _2) -> (__torch__.torch.classes.dist_c10d.Work _0)
Jan 05 22:23:41 processing existing schema:  send(__torch__.torch.classes.dist_c10d.ProcessGroup _0, Tensor[] _1, int _2, int _3) -> (__torch__.torch.classes.dist_c10d.Work _0)
Jan 05 22:23:41 processing existing schema:  recv(__torch__.torch.classes.dist_c10d.ProcessGroup _0, Tensor[] _1, int _2, int _3) -> (__torch__.torch.classes.dist_c10d.Work _0)
Jan 05 22:23:41 processing existing schema:  recv_anysource(__torch__.torch.classes.dist_c10d.ProcessGroup _0, Tensor[] _1, int _2) -> (__torch__.torch.classes.dist_c10d.Work _0)
Jan 05 22:23:41 processing existing schema:  barrier(__torch__.torch.classes.dist_c10d.ProcessGroup _0) -> (__torch__.torch.classes.dist_c10d.Work _0)
Jan 05 22:23:41 processing existing schema:  __init__(__torch__.torch.classes.dist_c10d.frontend _0) -> (None _0)
Jan 05 22:23:41 processing existing schema:  new_process_group_helper(__torch__.torch.classes.dist_c10d.frontend _0, int _1, int _2, int[] _3, str _4, __torch__.torch.classes.dist_c10d.Store _5, str? _6, int _7) -> (__torch__.torch.classes.dist_c10d.ProcessGroup _0)
Jan 05 22:23:41 processing existing schema:  get_process_group_by_name(__torch__.torch.classes.dist_c10d.frontend _0, str _1) -> (__torch__.torch.classes.dist_c10d.ProcessGroup _0)
Jan 05 22:23:41 processing existing schema:  get_name_of_process_group(__torch__.torch.classes.dist_c10d.frontend _0, __torch__.torch.classes.dist_c10d.ProcessGroup _1) -> (str _0)
Jan 05 22:23:41 processing existing schema:  __init__(__torch__.torch.classes.dist_rpc.WorkerInfo _0, str _1, int _2) -> (None _0)
Jan 05 22:23:41 The PR is introducing backward incompatible changes to the operator library. Please contact PyTorch team to confirm whether this change is wanted or not. 
Jan 05 22:23:41 
Jan 05 22:23:41 Broken ops: [
Jan 05 22:23:41 	aten::_test_ambiguous_defaults.a(Tensor dummy, int a=1, int b=1) -> (Tensor)
Jan 05 22:23:41 	aten::_test_ambiguous_defaults.b(Tensor dummy, int a=2, str b="2") -> (Tensor)
Jan 05 22:23:41 ]
Jan 05 22:23:41 + cleanup
Jan 05 22:23:41 + retcode=1
Jan 05 22:23:41 + set +x
Jan 05 22:23:41 =================== sccache compilation log ===================
Jan 05 22:23:41 =========== If your build fails, please take a look at the log above for possible reasons ===========

pytorch_xla_linux_bionic_py3_6_clang9_test (2/2)

Step: "Run tests" (full log | diagnosis details | 🔁 rerun)

Jan 05 22:54:21   what():  boxed_kernel_func_ == nullptr INTERNAL ASSERT FAILED at "/var/lib/jenkins/workspace/aten/src/ATen/core/boxing/KernelFunction_impl.h":220, please report a bug to PyTorch. Tried to set a manually boxed kernel for a kernel that already has a boxed kernel set.

Jan 05 22:54:18 + '[' /tmp/pytorch_py_test.log '!=' '' ']'
Jan 05 22:54:18 + run_all_tests
Jan 05 22:54:18 + tee /tmp/pytorch_py_test.log
Jan 05 22:54:18 + run_dynamic python3 /var/lib/jenkins/workspace/xla/test/../../test/test_view_ops.py -v TestViewOpsXLA
Jan 05 22:54:18 + echo 'Running in DynamicShape mode: python3' /var/lib/jenkins/workspace/xla/test/../../test/test_view_ops.py -v TestViewOpsXLA
Jan 05 22:54:18 Running in DynamicShape mode: python3 /var/lib/jenkins/workspace/xla/test/../../test/test_view_ops.py -v TestViewOpsXLA
Jan 05 22:54:18 + XLA_EXPERIMENTAL=nonzero:masked_select
Jan 05 22:54:18 + run_test python3 /var/lib/jenkins/workspace/xla/test/../../test/test_view_ops.py -v TestViewOpsXLA
Jan 05 22:54:18 + python3 /var/lib/jenkins/workspace/xla/test/../../test/test_view_ops.py -v TestViewOpsXLA
Jan 05 22:54:21 terminate called after throwing an instance of 'c10::Error'
Jan 05 22:54:21   what():  boxed_kernel_func_ == nullptr INTERNAL ASSERT FAILED at "/var/lib/jenkins/workspace/aten/src/ATen/core/boxing/KernelFunction_impl.h":220, please report a bug to PyTorch. Tried to set a manually boxed kernel for a kernel that already has a boxed kernel set.
Jan 05 22:54:21 Exception raised from setManuallyBoxedKernel_ at /var/lib/jenkins/workspace/aten/src/ATen/core/boxing/KernelFunction_impl.h:220 (most recent call first):
Jan 05 22:54:21 frame #0: c10::Error::Error(c10::SourceLocation, std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> >) + 0x7d (0x7f3edbf0a31d in /opt/conda/lib/python3.6/site-packages/torch/lib/libc10.so)
Jan 05 22:54:21 frame #1: <unknown function> + 0xf41ee0 (0x7f3edd070ee0 in /opt/conda/lib/python3.6/site-packages/torch/lib/libtorch_cpu.so)
Jan 05 22:54:21 frame #2: c10::impl::OperatorEntry::registerKernel(c10::Dispatcher const&, c10::optional<c10::DispatchKey>, c10::KernelFunction, c10::optional<c10::impl::CppSignature>, std::unique_ptr<c10::FunctionSchema, std::default_delete<c10::FunctionSchema> >, std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> >) + 0x5eb (0x7f3edd06dddb in /opt/conda/lib/python3.6/site-packages/torch/lib/libtorch_cpu.so)
Jan 05 22:54:21 frame #3: c10::Dispatcher::registerImpl(c10::OperatorName, c10::optional<c10::DispatchKey>, c10::KernelFunction, c10::optional<c10::impl::CppSignature>, std::unique_ptr<c10::FunctionSchema, std::default_delete<c10::FunctionSchema> >, std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> >) + 0x134 (0x7f3edd064f54 in /opt/conda/lib/python3.6/site-packages/torch/lib/libtorch_cpu.so)
Jan 05 22:54:21 frame #4: torch::Library::_impl(char const*, torch::CppFunction&&) & + 0x439 (0x7f3edd09b739 in /opt/conda/lib/python3.6/site-packages/torch/lib/libtorch_cpu.so)
Jan 05 22:54:21 frame #5: torch::Library& torch::Library::impl<char const*, at::Tensor (*)(at::Tensor const&, at::Tensor const&)>(char const*, at::Tensor (*&&)(at::Tensor const&, at::Tensor const&)) & + 0x64 (0x7f3ecec41e24 in /opt/conda/lib/python3.6/site-packages/torch_xla-1.6-py3.6-linux-x86_64.egg/_XLAC.cpython-36m-x86_64-linux-gnu.so)
Jan 05 22:54:21 frame #6: <unknown function> + 0x68e4cf (0x7f3ecec334cf in /opt/conda/lib/python3.6/site-packages/torch_xla-1.6-py3.6-linux-x86_64.egg/_XLAC.cpython-36m-x86_64-linux-gnu.so)
Jan 05 22:54:21 frame #7: torch::detail::TorchLibraryInit::TorchLibraryInit(torch::Library::Kind, void (*)(torch::Library&), char const*, c10::optional<c10::DispatchKey>, char const*, unsigned int) + 0xdb (0x7f3ecec4058b in /opt/conda/lib/python3.6/site-packages/torch_xla-1.6-py3.6-linux-x86_64.egg/_XLAC.cpython-36m-x86_64-linux-gnu.so)
Jan 05 22:54:21 frame #8: <unknown function> + 0x223571 (0x7f3ece7c8571 in /opt/conda/lib/python3.6/site-packages/torch_xla-1.6-py3.6-linux-x86_64.egg/_XLAC.cpython-36m-x86_64-linux-gnu.so)

This comment was automatically generated by Dr. CI (expand for details).

Follow this link to opt-out of these comments for your Pull Requests.

Please report bugs/suggestions to the (internal) Dr. CI Users group.

This comment has been revised 88 times.

)

BowenBao

LGTM, thanks! (please do a rebase)

…eraoof/opset13 # Conflicts: # test/onnx/test_pytorch_onnx_onnxruntime.py # torch/onnx/symbolic_helper.py # torch/onnx/symbolic_opset13.py

…neraoof/opset13

test/onnx/test_pytorch_onnx_onnxruntime.py

* Enable opset 13 ORT tests * Update test.sh * Set environ var * Update test.sh * Enabling more ops for opset 13 * change master to main * Update symbolic_opset13.py * Flake 8 fix * [ONNX] Support onnx if/loop sequence output in opset 13 - (pytorch#49270) * Symbolic function for torch.square (pytorch#49446) * Clean up tests * Exclude more tests * Trigge build * [ONNX] Support onnx if/loop sequence output in opset 13 - (pytorch#49270) * Symbolic function for torch.square (pytorch#49446) * update ORT version * disable more tests * clean up * flake8 * Disable TV tests * Update test_pytorch_onnx_onnxruntime.py Co-authored-by: Bowen Bao <[email protected]> Co-authored-by: David Fan <[email protected]>

Summary: [ONNX] ONNX dev branch merge 01-06-2021 - [ONNX] Support onnx if/loop sequence output in opset 13 - (#49270) - Symbolic function for torch.square (#49446) - [ONNX] Add checks in ONNXSetDynamicInputShape (#49783) … - [ONNX] Enable export af aten::__derive_index (#49514) … - [ONNX] Update symbolic for unfold (#49378) … - [ONNX] Update the sequence of initializers in exported graph so that it is as same as inputs. (#49798) - [ONNX] Enable opset 13 ops (#49612) … - [ONNX] Improve error message for supported model input types in ONNX export API. (#50119) - [ONNX] Add a post-pass for If folding (#49410) Pull Request resolved: #50163 Reviewed By: pbelevich Differential Revision: D25821059 Pulled By: SplitInfinity fbshipit-source-id: 9f511a93d9d5812d0ab0a49d61ed0fa5f8066948

neginraoof and others added 14 commits October 26, 2020 23:45

Enable opset 13 ORT tests

4f644a9

Update test.sh

9343ffc

Set environ var

f14615a

Merge branch 'neraoof/opset13' of github.com:neginraoof/pytorch into …

19eb56d

…neraoof/opset13

Update test.sh

61855a5

Enabling more ops for opset 13

be7c21a

change master to main

4e8ef96

Update symbolic_opset13.py

4ab292a

Merge branch 'master' of https://github.com/pytorch/pytorch into nera…

e0ce9bc

…oof/opset13 # Conflicts: # .jenkins/caffe2/test.sh

Merge branch 'master' of https://github.com/pytorch/pytorch into nera…

53b8825

…oof/opset13

Merge branch 'master' of https://github.com/pytorch/pytorch into nera…

0fd0326

…oof/opset13

Flake 8 fix

04f5505

[ONNX] Support onnx if/loop sequence output in opset 13 - (pytorch#49270

170908b

)

Symbolic function for torch.square (pytorch#49446)

203e181

neginraoof requested review from albanD, glaringlee, mingzhe09088, mrshenli, pritamdamania87, rohan-varma and zhaojuanmao as code owners December 18, 2020 20:01

facebook-github-bot added cla signed oncall: jit Add this issue/PR to JIT oncall triage queue labels Dec 18, 2020

facebook-github-bot added oncall: distributed Add this issue/PR to distributed oncall triage queue fx labels Dec 18, 2020

neginraoof removed request for albanD, mrshenli, pritamdamania87 and rohan-varma December 18, 2020 20:01

neginraoof removed oncall: jit Add this issue/PR to JIT oncall triage queue open source labels Dec 18, 2020

neginraoof removed request for ezyang, fmassa and soumith December 18, 2020 20:30

pytorchbot added the open source label Dec 18, 2020

neginraoof and others added 4 commits December 18, 2020 14:58

Exclude more tests

0c84654

Trigge build

b2d6e68

[ONNX] Support onnx if/loop sequence output in opset 13 - (pytorch#49270

29dd23f

)

Symbolic function for torch.square (pytorch#49446)

f7c63eb

BowenBao force-pushed the onnx_ms_1 branch from 203e181 to f7c63eb Compare December 22, 2020 22:23

neginraoof added 5 commits December 23, 2020 08:10

Merge branch 'onnx_ms_1' into neraoof/opset13

44d50a4

update ORT version

2a7d253

disable more tests

c7b9502

clean up

b01b9b5

flake8

9e4a8fd

BowenBao force-pushed the onnx_ms_1 branch from ab060a1 to 1baebbb Compare January 4, 2021 18:29

BowenBao approved these changes Jan 4, 2021

View reviewed changes

neginraoof added 2 commits January 4, 2021 14:50

Merge branch 'onnx_ms_1' of https://github.com/pytorch/pytorch into n…

f6813b9

…eraoof/opset13 # Conflicts: # test/onnx/test_pytorch_onnx_onnxruntime.py # torch/onnx/symbolic_helper.py # torch/onnx/symbolic_opset13.py

Merge branch 'neraoof/opset13' of github.com:neginraoof/pytorch into …

ad7f7f8

…neraoof/opset13

hwangdeyu reviewed Jan 5, 2021

View reviewed changes

test/onnx/test_pytorch_onnx_onnxruntime.py Outdated Show resolved Hide resolved

fatcat-z reviewed Jan 5, 2021

View reviewed changes

test/onnx/test_pytorch_onnx_onnxruntime.py Show resolved Hide resolved

neginraoof added 4 commits January 5, 2021 09:45

Disable TV tests

b130533

Merge branch 'onnx_ms_1' into neraoof/opset13

067a85d

Merge branch 'onnx_ms_1' into neraoof/opset13

226bb72

Update test_pytorch_onnx_onnxruntime.py

70aa5c4

neginraoof merged commit 616da7c into pytorch:onnx_ms_1 Jan 6, 2021

spandantiwari mentioned this pull request Jan 7, 2021

[ONNX] ONNX dev branch merge 01-06-2021 #50163

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[ONNX] Enable opset 13 ops#49612

[ONNX] Enable opset 13 ops#49612
neginraoof merged 31 commits intopytorch:onnx_ms_1from
neginraoof:neraoof/opset13

neginraoof commented Dec 18, 2020

Uh oh!

facebook-github-bot commented Dec 18, 2020 •

edited

Loading

Uh oh!

BowenBao left a comment •

edited

Loading

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

7 participants

Conversation

neginraoof commented Dec 18, 2020

Uh oh!

facebook-github-bot commented Dec 18, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

💊 CI failures summary and remediations

🕵️ 2 new failures recognized by patterns

pytorch_linux_backward_compatibility_check_test (1/2)

pytorch_xla_linux_bionic_py3_6_clang9_test (2/2)

Uh oh!

BowenBao left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

7 participants

facebook-github-bot commented Dec 18, 2020 •

edited

Loading

BowenBao left a comment •

edited

Loading