Skip to content

add checkout PR tip step for quick checks #49590

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
walterddr wants to merge 1 commit into from
Closed

add checkout PR tip step for quick checks #49590

walterddr wants to merge 1 commit into from

Conversation

@walterddr
Copy link
Contributor

@walterddr walterddr commented Dec 18, 2020 •
edited
Loading

with "Checkout PR step" added, quick-checks step now only validates PR changes.

@walterddr walterddr requested a review from samestep December 18, 2020 04:35
@facebook-github-bot
Copy link
Contributor

facebook-github-bot commented Dec 18, 2020 •
edited
Loading

💊 CI failures summary and remediations

As of commit 4ae1d2b (more details on the Dr. CI page):

  • 3/3 failures possibly* introduced in this PR
    • 1/3 non-CircleCI failure(s)

🕵️ 2 new failures recognized by patterns

The following CI failures do not appear to be due to upstream breakages:

See CircleCI build pytorch_linux_bionic_py3_8_gcc9_coverage_test2 (1/2)

Step: "Run tests" (full log | diagnosis details | 🔁 rerun)

Dec 18 06:19:02 [E request_callback_no_python.cpp:636] Received error while processing request type 258: RuntimeError: Can not pickle torch.futures.Future 
Dec 18 06:19:02 At:
Dec 18 06:19:02   /opt/conda/lib/python3.8/site-packages/torch/distributed/rpc/internal.py(120): serialize
Dec 18 06:19:02   /opt/conda/lib/python3.8/site-packages/torch/distributed/rpc/internal.py(172): serialize
Dec 18 06:19:02 
Dec 18 06:19:02 [E request_callback_no_python.cpp:636] Received error while processing request type 258: RuntimeError: Can not pickle torch.futures.Future
Dec 18 06:19:02 
Dec 18 06:19:02 At:
Dec 18 06:19:02   /opt/conda/lib/python3.8/site-packages/torch/distributed/rpc/internal.py(120): serialize
Dec 18 06:19:02   /opt/conda/lib/python3.8/site-packages/torch/distributed/rpc/internal.py(172): serialize
Dec 18 06:19:02 
Dec 18 06:19:02 [E request_callback_no_python.cpp:636] Received error while processing request type 258: RuntimeError: Can not pickle torch.futures.Future
Dec 18 06:19:02 
Dec 18 06:19:02 At:
Dec 18 06:19:02   /opt/conda/lib/python3.8/site-packages/torch/distributed/rpc/internal.py(120): serialize
Dec 18 06:19:02   /opt/conda/lib/python3.8/site-packages/torch/distributed/rpc/internal.py(172): serialize
Dec 18 06:19:02 
Dec 18 06:19:02 [W tensorpipe_agent.cpp:547] RPC agent for worker2 encountered error when reading incoming request from worker1: EOF: end of file (this is expected to happen during shutdown)
Dec 18 06:19:02 [W tensorpipe_agent.cpp:547] RPC agent for worker0 encountered error when reading incoming request from worker3: EOF: end of file (this is expected to happen during shutdown)
Dec 18 06:19:03 ok (2.555s)
Dec 18 06:19:04   test_return_future_remote (__main__.TensorPipeRpcTestWithSpawn) ... [W tensorpipe_agent.cpp:547] RPC agent for worker1 encountered error when reading incoming request from worker0: EOF: end of file (this is expected to happen during shutdown)
Dec 18 06:19:04 [W tensorpipe_agent.cpp:547] RPC agent for worker0 encountered error when reading incoming request from worker3: EOF: end of file (this is expected to happen during shutdown)

See CircleCI build pytorch_windows_vs2019_py36_cuda10.1_test1 (2/2)

Step: "Test" (full log | diagnosis details | 🔁 rerun)

RuntimeError: test_nn failed! 
  test_ReflectionPad2d_alert_nondeterministic_cuda (__main__.TestNN) ... ok (0.013s)
  test_ReflectionPad2d_cuda (__main__.TestNN) ... ok (0.014s)
  test_ReplicationPad1d (__main__.TestNN) ... ok (0.080s)
  test_ReplicationPad1d_alert_nondeterministic_cuda (__main__.TestNN) ... ok (0.004s)
  test_ReplicationPad1d_cuda (__main__.TestNN) ... No data to combine
Traceback (most recent call last):
  File "run_test.py", line 905, in <module>
    main()
  File "run_test.py", line 888, in main
    raise RuntimeError(err_message)
RuntimeError: test_nn failed!

(base) circleci@PACKER-5FD865C5 C:\Users\circleci\project\test>if ERRORLEVEL 1 exit /b 1 
+ cleanup
+ retcode=1
+ set +x


Exited with code exit status 1

1 job timed out:

  • pytorch_linux_bionic_py3_8_gcc9_coverage_test2
This comment was automatically generated by Dr. CI (expand for details).Follow this link to opt-out of these comments for your Pull Requests.

Please report bugs/suggestions to the (internal) Dr. CI Users group.

This comment has been revised 7 times.

facebook-github-bot
facebook-github-bot reviewed Dec 18, 2020
View reviewed changes
Copy link
Contributor

@facebook-github-bot facebook-github-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@walterddr has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

@samestep samestep mentioned this pull request Dec 18, 2020
Closed
@samestep
Copy link
Contributor

samestep commented Dec 18, 2020

for context: this PR is meant to achieve the same thing as #49578, but simply does so by reusing the same solution we already have for other jobs in GitHub Actions (rather than trying to switch over to a different solution before applying it uniformly to all jobs)

@facebook-github-bot
Copy link
Contributor

facebook-github-bot commented Dec 18, 2020

@walterddr merged this pull request in f975f99.

hwangdeyu pushed a commit to hwangdeyu/pytorch that referenced this pull request Jan 6, 2021
add checkout PR tip step for quick checks (pytorch#49590)
25d77c8 
Summary: Pull Request resolved: pytorch#49590

Reviewed By: samestep

Differential Revision: D25633341

Pulled By: walterddr

fbshipit-source-id: 6e8db1f628f562d7632390bdb7788437cb1bf63d
@samestep samestep mentioned this pull request Jan 22, 2021
Closed
@samestep samestep mentioned this pull request Mar 9, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@facebook-github-bot facebook-github-bot facebook-github-bot left review comments

+1 more reviewer

@samestep samestep samestep approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

cla signed Merged

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@walterddr @facebook-github-bot @samestep