[FX] Rename Node._uses and refactor Node.all_input_nodes#49415
Closed
jamesr66a wants to merge 1 commit intogh/jamesr66a/333/basefrom
Closed
[FX] Rename Node._uses and refactor Node.all_input_nodes#49415jamesr66a wants to merge 1 commit intogh/jamesr66a/333/basefrom
jamesr66a wants to merge 1 commit intogh/jamesr66a/333/basefrom
Conversation
[ghstack-poisoned]
Contributor
💊 CI failures summary and remediationsAs of commit 12afc4a (more details on the Dr. CI page): 💚 💚 Looks good so far! There are no failures yet. 💚 💚 This comment was automatically generated by Dr. CI (expand for details).Follow this link to opt-out of these comments for your Pull Requests.Please report bugs/suggestions to the (internal) Dr. CI Users group. This comment has been revised 2 times. |
zdevito
approved these changes
Dec 16, 2020
Contributor
|
@jamesr66a merged this pull request in e9d7d37. |
hwangdeyu
pushed a commit
to hwangdeyu/pytorch
that referenced
this pull request
Jan 6, 2021
Summary: Pull Request resolved: pytorch#49415 Test Plan: Imported from OSS Reviewed By: zdevito Differential Revision: D25565341 Pulled By: jamesr66a fbshipit-source-id: 2290ab62572632788809ba16319578bf0c0260ee
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stack from ghstack:
usesanduserswere pretty close to each other and easy to get confused. We also already had a property namedall_input_nodesthat seemed more clear. This PR:Node._usestoNode._input_nodesNode.all_input_nodesto directly return_input_nodes, potentially speeding stuff upDifferential Revision: D25565341