Skip to content

Unescape string in RPC error message#49373

Closed
rohan-varma wants to merge 3 commits intogh/rohan-varma/209/basefrom
gh/rohan-varma/209/head
Closed

Unescape string in RPC error message#49373
rohan-varma wants to merge 3 commits intogh/rohan-varma/209/basefrom
gh/rohan-varma/209/head

Conversation

@rohan-varma
Copy link
Copy Markdown
Contributor

@rohan-varma rohan-varma commented Dec 15, 2020 •
edited
Loading

Stack from ghstack:

Unescaping the string in RPC error message to provide better error msg

Differential Revision: D25511730

NOTE FOR REVIEWERS: This PR has internal Facebook specific changes or comments, please review them on Phabricator!

@rohan-varma
Unescape string in RPC error message
b156292 
Unescaping the string in RPC error message to provide better error msg

Differential Revision: [D25511730](https://our.internmc.facebook.com/intern/diff/D25511730/)

**NOTE FOR REVIEWERS**: This PR has internal Facebook specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D25511730/)!

[ghstack-poisoned]
@facebook-github-bot
Copy link
Copy Markdown
Contributor

facebook-github-bot commented Dec 15, 2020 •
edited
Loading

💊 CI failures summary and remediations

As of commit 448925a (more details on the Dr. CI page):

  • 2/2 failures introduced in this PR

🕵️ 2 new failures recognized by patterns

The following CI failures do not appear to be due to upstream breakages:

See CircleCI build pytorch_linux_xenial_py3_clang5_asan_test2 (1/2)

Step: "Run tests" (full log | diagnosis details | 🔁 rerun)

Dec 15 21:33:38 SUMMARY: UndefinedBehaviorSanitizer: undefined-behavior /var/lib/jenkins/workspace/aten/src/ATen/Utils.cpp:15:3 in 
Dec 15 21:33:38     #7 0x558dae15270b in PyEval_EvalCode /tmp/build/80754af9/python_1599604603603/work/Python/ceval.c:731
Dec 15 21:33:38     #8 0x558dae1d2573 in run_mod /tmp/build/80754af9/python_1599604603603/work/Python/pythonrun.c:1025
Dec 15 21:33:38     #9 0x558dae1d260c in PyRun_StringFlags /tmp/build/80754af9/python_1599604603603/work/Python/pythonrun.c:949
Dec 15 21:33:38     #10 0x558dae1d266e in PyRun_SimpleStringFlags /tmp/build/80754af9/python_1599604603603/work/Python/pythonrun.c:445
Dec 15 21:33:38     #11 0x558dae1d6472 in run_command /tmp/build/80754af9/python_1599604603603/work/Modules/main.c:301
Dec 15 21:33:38     #12 0x558dae1d6472 in Py_Main /tmp/build/80754af9/python_1599604603603/work/Modules/main.c:749
Dec 15 21:33:38     #13 0x558dae0a043d in main /tmp/build/80754af9/python_1599604603603/work/Programs/python.c:69
Dec 15 21:33:38     #14 0x7efecca0e83f in __libc_start_main /build/glibc-e6zv40/glibc-2.23/csu/../csu/libc-start.c:291
Dec 15 21:33:38     #15 0x558dae17fd0a in _start /home/rdonnelly/mc/conda-bld/compilers_linux-64_1534865402226/work/.build/src/glibc-2.12.2/csu/../sysdeps/x86_64/elf/start.S:103
Dec 15 21:33:38 
Dec 15 21:33:38 SUMMARY: UndefinedBehaviorSanitizer: undefined-behavior /var/lib/jenkins/workspace/aten/src/ATen/Utils.cpp:15:3 in 
Dec 15 21:33:38 + retcode=1
Dec 15 21:33:38 + set -e
Dec 15 21:33:38 + return 1
Dec 15 21:33:38 + [[ pytorch-linux-xenial-py3-clang5-asan-test2 == *-NO_AVX-* ]]
Dec 15 21:33:38 + [[ pytorch-linux-xenial-py3-clang5-asan-test2 == *-NO_AVX2-* ]]
Dec 15 21:33:38 + '[' -n https://github.com/pytorch/pytorch/pull/49373 ']'
Dec 15 21:33:38 + [[ pytorch-linux-xenial-py3-clang5-asan-test2 != *coverage* ]]
Dec 15 21:33:38 ++ mktemp
Dec 15 21:33:38 + DETERMINE_FROM=/tmp/tmp.xOcBvA0qVg
Dec 15 21:33:38 + file_diff_from_base /tmp/tmp.xOcBvA0qVg

See CircleCI build pytorch_linux_xenial_py3_clang7_onnx_ort_test2 (2/2)

Step: "Run tests" (full log | diagnosis details | 🔁 rerun)

Dec 15 21:28:21 [ FAILED ] MathKernelTest.NativeLayerNorm 
Dec 15 21:28:21 Expected: true
Dec 15 21:28:21 [  FAILED  ] MathKernelTest.NativeLayerNorm (3 ms)
Dec 15 21:28:21 [ RUN      ] MathKernelTest.Addr
Dec 15 21:28:21 [       OK ] MathKernelTest.Addr (1 ms)
Dec 15 21:28:21 [----------] 3 tests from MathKernelTest (9 ms total)
Dec 15 21:28:21 
Dec 15 21:28:21 [----------] Global test environment tear-down
Dec 15 21:28:21 [==========] 3 tests from 1 test case ran. (9 ms total)
Dec 15 21:28:21 [  PASSED  ] 2 tests.
Dec 15 21:28:21 [  FAILED  ] 1 test, listed below:
Dec 15 21:28:21 [  FAILED  ] MathKernelTest.NativeLayerNorm
Dec 15 21:28:21 
Dec 15 21:28:21  1 FAILED TEST


Exited with code exit status 1

CONTAINER ID        NAME                CPU %               MEM USAGE / LIMIT     MEM %               NET I/O             BLOCK I/O           PIDS
30ddfd50f381        vigorous_dirac      0.02%               48.09MiB / 14.68GiB   0.32%               3.18MB / 2.15MB     0B / 0B             28
Dec 15 21:28:23 + export BUILD_ENVIRONMENT=pytorch-linux-xenial-py3-clang7-onnx-ort_test2
Dec 15 21:28:23 + BUILD_ENVIRONMENT=pytorch-linux-xenial-py3-clang7-onnx-ort_test2

1 job timed out:

  • pytorch_linux_xenial_py3_clang5_asan_test2
This comment was automatically generated by Dr. CI (expand for details).Follow this link to opt-out of these comments for your Pull Requests.

Please report bugs/suggestions to the (internal) Dr. CI Users group.

This comment has been revised 9 times.

@facebook-github-bot facebook-github-bot added cla signed oncall: distributed Add this issue/PR to distributed oncall triage queue labels Dec 15, 2020
@rohan-varma rohan-varma requested a review from xush6528 December 15, 2020 00:07
@rohan-varma
Update on "Unescape string in RPC error message"
3473022 
Unescaping the string in RPC error message to provide better error msg

Differential Revision: [D25511730](https://our.internmc.facebook.com/intern/diff/D25511730/)

**NOTE FOR REVIEWERS**: This PR has internal Facebook specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D25511730/)!

[ghstack-poisoned]
rohan-varma added a commit that referenced this pull request Dec 15, 2020
@rohan-varma
Unescape string in RPC error message
20a28b4 
Pull Request resolved: #49373

Unescaping the string in RPC error message to provide better error msg

Differential Revision: [D25511730](https://our.internmc.facebook.com/intern/diff/D25511730/)

**NOTE FOR REVIEWERS**: This PR has internal Facebook specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D25511730/)!
ghstack-source-id: 118572206
@rohan-varma
Update on "Unescape string in RPC error message"
448925a 
Unescaping the string in RPC error message to provide better error msg

Differential Revision: [D25511730](https://our.internmc.facebook.com/intern/diff/D25511730/)

**NOTE FOR REVIEWERS**: This PR has internal Facebook specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D25511730/)!

[ghstack-poisoned]
rohan-varma added a commit that referenced this pull request Dec 15, 2020
@rohan-varma
Unescape string in RPC error message
d74979c 
Pull Request resolved: #49373

Unescaping the string in RPC error message to provide better error msg

Differential Revision: [D25511730](https://our.internmc.facebook.com/intern/diff/D25511730/)

**NOTE FOR REVIEWERS**: This PR has internal Facebook specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D25511730/)!
ghstack-source-id: 118646929
@facebook-github-bot
Copy link
Copy Markdown
Contributor

facebook-github-bot commented Dec 16, 2020

This pull request has been merged in 40d7c10.

@facebook-github-bot facebook-github-bot deleted the gh/rohan-varma/209/head branch December 19, 2020 15:18
hwangdeyu pushed a commit to hwangdeyu/pytorch that referenced this pull request Jan 6, 2021
@rohan-varma
Unescape string in RPC error message (pytorch#49373)
28a5455 
Summary:
Pull Request resolved: pytorch#49373

Unescaping the string in RPC error message to provide better error msg

Test Plan: CI

Reviewed By: xush6528

Differential Revision: D25511730

fbshipit-source-id: 054f46d5ffbcb1350012362a023fafb1fe57fca1
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@xush6528 xush6528 xush6528 approved these changes

@mingzhe09088 mingzhe09088 Awaiting requested review from mingzhe09088

@mrshenli mrshenli Awaiting requested review from mrshenli

@pritamdamania87 pritamdamania87 Awaiting requested review from pritamdamania87

@zhaojuanmao zhaojuanmao Awaiting requested review from zhaojuanmao

Assignees

No one assigned

Labels

cla signed Merged oncall: distributed Add this issue/PR to distributed oncall triage queue

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@rohan-varma @facebook-github-bot @xush6528