Skip to content

[ONNX] Add checks in ONNXSetDynamicInputShape#49132

Closed
jiafatom wants to merge 35 commits intopytorch:masterfrom
jiafatom:shape_axis_check
Closed

[ONNX] Add checks in ONNXSetDynamicInputShape#49132
jiafatom wants to merge 35 commits intopytorch:masterfrom
jiafatom:shape_axis_check

Conversation

@jiafatom
Copy link
Copy Markdown
Contributor

@jiafatom jiafatom commented Dec 10, 2020 •
edited
Loading

(1) This PR is one step to fix the torch vision CI failure here.
(2) Import torch vision CI tests to pytorch CI tests, then we can monitor the test failure while submitting PRs.

@facebook-github-bot facebook-github-bot added cla signed oncall: jit Add this issue/PR to JIT oncall triage queue labels Dec 10, 2020
@dr-ci
Copy link
Copy Markdown

dr-ci bot commented Dec 10, 2020 •
edited by facebook-github-bot
Loading

💊 CI failures summary and remediations

As of commit c487d85 (more details on the Dr. CI page):

✅ None of the CI failures appear to be your fault 💚

🚧 1 fixed upstream failure:

These were probably caused by upstream breakages that were already fixed.

Please rebase on the viable/strict branch (expand for instructions)

If your commit is older than viable/strict, run these commands:

git fetch https://github.com/pytorch/pytorch viable/strict
git rebase FETCH_HEAD

Check out the recency history of this "viable master" tracking branch.

This comment was automatically generated by Dr. CI (expand for details).Follow this link to opt-out of these comments for your Pull Requests.

Please report bugs/suggestions to the (internal) Dr. CI Users group.

This comment has been revised 33 times.

@jiafatom jiafatom changed the title Add checks in ONNXSetDynamicInputShape [ONNX] Add checks in ONNXSetDynamicInputShape Dec 10, 2020
@codecov
Copy link
Copy Markdown

codecov bot commented Dec 10, 2020 •
edited
Loading

Codecov Report

Merging #49132 (1e22035) into master (19f4c51) will decrease coverage by 0.07%.
The diff coverage is 67.38%.

@@            Coverage Diff             @@
##           master   #49132      +/-   ##
==========================================
- Coverage   80.77%   80.69%   -0.08%     
==========================================
  Files        1867     1871       +4     
  Lines      201583   202065     +482     
==========================================
+ Hits       162819   163064     +245     
- Misses      38764    39001     +237

@jiafatom
Merge branch 'shape_axis_check' of https://github.com/jiafatom/pytorch …
a8f87e2 
…into shape_axis_check
@jiafatom
Merge branch 'master' into shape_axis_check
b10fcb3
@jiafatom
Merge branch 'shape_axis_check' of https://github.com/jiafatom/pytorch …
f2c0d12 
…into shape_axis_check
@jiafatom
Merge branch 'shape_axis_check' of https://github.com/jiafatom/pytorch …
ba7fa42 
…into shape_axis_check
@jiafatom
Merge branch 'shape_axis_check' of https://github.com/jiafatom/pytorch …
b379e21 
…into shape_axis_check
@jiafatom
Merge branch 'shape_axis_check' of https://github.com/jiafatom/pytorch …
0e01d26 
…into shape_axis_check
@jiafatom
Merge branch 'master' of https://github.com/pytorch/pytorch into shap…
36babe9 
…e_axis_check
@jiafatom
Merge branch 'shape_axis_check' of https://github.com/jiafatom/pytorch …
fbb4892 
…into shape_axis_check
@jiafatom
Merge branch 'shape_axis_check' of https://github.com/jiafatom/pytorch …
ff9a44b 
…into shape_axis_check
@jiafatom
Merge branch 'master' into shape_axis_check
1a18bcd
@jiafatom
Merge branch 'shape_axis_check' of https://github.com/jiafatom/pytorch …
2204d7a 
…into shape_axis_check
@H-Huang H-Huang added the module: onnx Related to torch.onnx label Dec 10, 2020
@H-Huang H-Huang requested a review from neginraoof December 10, 2020 23:52
@H-Huang H-Huang added the triaged This issue has been looked at a team member, and triaged and prioritized into an appropriate module label Dec 10, 2020
@jiafatom jiafatom changed the title [ONNX] Add checks in ONNXSetDynamicInputShape [ONNX] [WIP] Add checks in ONNXSetDynamicInputShape Dec 11, 2020
@jiafatom
Merge branch 'shape_axis_check' of https://github.com/jiafatom/pytorch …
883fa86 
…into shape_axis_check
@jiafatom
Merge branch 'shape_axis_check' of https://github.com/jiafatom/pytorch …
4874ae2 
…into shape_axis_check
@jiafatom
Merge branch 'shape_axis_check' of https://github.com/jiafatom/pytorch …
eb95779 
…into shape_axis_check
@jiafatom
Merge branch 'shape_axis_check' of https://github.com/jiafatom/pytorch …
9eb0714 
…into shape_axis_check
@jiafatom
Merge branch 'master' into shape_axis_check
8011b3f
@jiafatom
Merge branch 'shape_axis_check' of https://github.com/jiafatom/pytorch …
d7b73ba 
…into shape_axis_check
@jiafatom
Merge branch 'shape_axis_check' of https://github.com/jiafatom/pytorch …
268447f 
…into shape_axis_check
@jiafatom
Merge branch 'master' into shape_axis_check
ad902df
@jiafatom
Merge branch 'shape_axis_check' of https://github.com/jiafatom/pytorch …
476b1ef 
…into shape_axis_check
@jiafatom
Merge branch 'shape_axis_check' of https://github.com/jiafatom/pytorch …
19ae914 
…into shape_axis_check
@jiafatom
Merge branch 'master' into shape_axis_check
5cf0901
@jiafatom
Merge branch 'shape_axis_check' of https://github.com/jiafatom/pytorch …
a93a9f2 
…into shape_axis_check
@jiafatom
Merge branch 'shape_axis_check' of https://github.com/jiafatom/pytorch …
5d5d8f8 
…into shape_axis_check
@jiafatom
Merge branch 'master' into shape_axis_check
bafd675
@jiafatom
Merge branch 'shape_axis_check' of https://github.com/jiafatom/pytorch …
e2f4232 
…into shape_axis_check
@jiafatom
Merge branch 'shape_axis_check' of https://github.com/jiafatom/pytorch …
a10620b 
…into shape_axis_check
@jiafatom
Merge branch 'shape_axis_check' of https://github.com/jiafatom/pytorch …
c487d85 
…into shape_axis_check
@jiafatom jiafatom changed the title [ONNX] [WIP] Add checks in ONNXSetDynamicInputShape [ONNX] Add checks in ONNXSetDynamicInputShape Dec 14, 2020
@jiafatom jiafatom mentioned this pull request Dec 14, 2020
Closed
@jiafatom
Copy link
Copy Markdown
Contributor Author

jiafatom commented Dec 15, 2020

Close this one, use PR instead.

@jiafatom jiafatom closed this Dec 15, 2020
This was referenced Dec 23, 2020
Merged
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@BowenBao BowenBao Awaiting requested review from BowenBao

@spandantiwari spandantiwari Awaiting requested review from spandantiwari

@neginraoof neginraoof Awaiting requested review from neginraoof

Assignees

No one assigned

Labels

cla signed module: onnx Related to torch.onnx oncall: jit Add this issue/PR to JIT oncall triage queue open source triaged This issue has been looked at a team member, and triaged and prioritized into an appropriate module

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@jiafatom @facebook-github-bot @H-Huang @pytorchbot