Skip to content

enable mkldnn conv2d backward to support mkldnn tensor input #48994

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
XiaobingSuper wants to merge 16 commits into from
Closed

enable mkldnn conv2d backward to support mkldnn tensor input #48994

XiaobingSuper wants to merge 16 commits into from

Conversation

@XiaobingSuper
Copy link
Collaborator

@XiaobingSuper XiaobingSuper commented Dec 8, 2020 •
edited
Loading

Stack from ghstack:

Differential Revision: D25537189

@XiaobingSuper XiaobingSuper requested a review from albanD as a code owner December 8, 2020 02:42
This was referenced Dec 8, 2020
Closed
Closed
XiaobingSuper added a commit that referenced this pull request Dec 8, 2020
@XiaobingSuper
enable mkldnn conv2d backward to support mkldnn tensor input
9b0cad0 
ghstack-source-id: ad271b8
Pull Request resolved: #48994
@dr-ci
Copy link

dr-ci bot commented Dec 8, 2020 •
edited by facebook-github-bot
Loading

💊 CI failures summary and remediations

As of commit 7b5c09e (more details on the Dr. CI page):

  • 3/3 failures introduced in this PR

🕵️ 2 new failures recognized by patterns

The following CI failures do not appear to be due to upstream breakages:

See CircleCI build pytorch_linux_xenial_cuda10_2_cudnn7_py3_gcc7_test2 (1/2)

Step: "Run tests" (full log | diagnosis details | 🔁 rerun)

Feb 06 16:52:09 [E request_callback_no_python.cpp:653] Received error while processing request type 258: RuntimeError: Can not pickle torch.futures.Future 
Feb 06 16:52:09 At:
Feb 06 16:52:09   /opt/conda/lib/python3.6/site-packages/torch/distributed/rpc/internal.py(120): serialize
Feb 06 16:52:09   /opt/conda/lib/python3.6/site-packages/torch/distributed/rpc/internal.py(172): serialize
Feb 06 16:52:09 
Feb 06 16:52:09 [E request_callback_no_python.cpp:653] Received error while processing request type 258: RuntimeError: Can not pickle torch.futures.Future
Feb 06 16:52:09 
Feb 06 16:52:09 At:
Feb 06 16:52:09   /opt/conda/lib/python3.6/site-packages/torch/distributed/rpc/internal.py(120): serialize
Feb 06 16:52:09   /opt/conda/lib/python3.6/site-packages/torch/distributed/rpc/internal.py(172): serialize
Feb 06 16:52:09 
Feb 06 16:52:09 [E request_callback_no_python.cpp:653] Received error while processing request type 258: RuntimeError: Can not pickle torch.futures.Future
Feb 06 16:52:09 
Feb 06 16:52:09 At:
Feb 06 16:52:09   /opt/conda/lib/python3.6/site-packages/torch/distributed/rpc/internal.py(120): serialize
Feb 06 16:52:09   /opt/conda/lib/python3.6/site-packages/torch/distributed/rpc/internal.py(172): serialize
Feb 06 16:52:09 
Feb 06 16:52:10 ok (1.429s)
Feb 06 16:52:11   test_return_future_remote (__main__.TensorPipeRpcTestWithSpawn) ... ok (1.530s)
Feb 06 16:52:13   test_return_local_rrefs (__main__.TensorPipeRpcTestWithSpawn) ... ok (1.530s)
Feb 06 16:52:18   test_rpc_profiling_async_function (__main__.TensorPipeRpcTestWithSpawn) ... ok (5.436s)
Feb 06 16:52:23   test_rpc_profiling_async_function_single_threaded (__main__.TensorPipeRpcTestWithSpawn) ... ok (5.437s)

See CircleCI build pytorch_doc_test (2/2)

Step: "Doc test" (full log | diagnosis details | 🔁 rerun)

Feb 06 14:03:12 sccache: error: couldn't connect to server 
Feb 06 14:03:12 ++++ eval 'extract_trap_cmd '
Feb 06 14:03:12 +++++ extract_trap_cmd
Feb 06 14:03:12 +++++ printf '%s\n' ''
Feb 06 14:03:12 ++++ printf '%s\n' cleanup
Feb 06 14:03:12 +++ trap -- '
Feb 06 14:03:12 cleanup' EXIT
Feb 06 14:03:12 +++ [[ pytorch-linux-xenial-py3.6-gcc5.4-build != *pytorch-win-* ]]
Feb 06 14:03:12 +++ which sccache
Feb 06 14:03:12 +++ sccache --stop-server
Feb 06 14:03:12 Stopping sccache server...
Feb 06 14:03:12 sccache: error: couldn't connect to server
Feb 06 14:03:12 sccache: caused by: Connection refused (os error 111)
Feb 06 14:03:12 +++ true
Feb 06 14:03:12 +++ rm /var/lib/jenkins/sccache_error.log
Feb 06 14:03:12 +++ [[ pytorch-linux-xenial-py3.6-gcc5.4-build == *rocm* ]]
Feb 06 14:03:12 +++ SCCACHE_ERROR_LOG=/var/lib/jenkins/sccache_error.log
Feb 06 14:03:12 +++ SCCACHE_IDLE_TIMEOUT=1200
Feb 06 14:03:12 +++ RUST_LOG=sccache::server=error
Feb 06 14:03:12 +++ sccache --start-server
Feb 06 14:03:12 sccache: Starting the server...
Feb 06 14:03:12 +++ sccache --zero-stats

1 failure not recognized by patterns:

Job Step Action
CircleCI binary_linux_libtorch_3_7m_cpu_gcc5_4_cxx11-abi_shared-with-deps_build Spin up environment 🔁 rerun
This comment was automatically generated by Dr. CI (expand for details).Follow this link to opt-out of these comments for your Pull Requests.

Please report bugs/suggestions to the (internal) Dr. CI Users group.

albanD
albanD reviewed Dec 8, 2020
View reviewed changes
@jgong5
Copy link
Collaborator

jgong5 commented Dec 12, 2020

@VitalyFedyunin

@jgong5 jgong5 mentioned this pull request Dec 12, 2020
Closed
XiaobingSuper added a commit that referenced this pull request Dec 16, 2020
@XiaobingSuper
enable mkldnn conv2d backward to support mkldnn tensor input
1cc961d 
ghstack-source-id: 83588b1
Pull Request resolved: #48994
XiaobingSuper added a commit that referenced this pull request Dec 16, 2020
@XiaobingSuper
enable mkldnn conv2d backward to support mkldnn tensor input
b98ac96 
ghstack-source-id: 6fbde5c
Pull Request resolved: #48994
XiaobingSuper added a commit that referenced this pull request Jan 13, 2021
@XiaobingSuper
enable mkldnn conv2d backward to support mkldnn tensor input
701528b 
ghstack-source-id: 9696b15
Pull Request resolved: #48994
XiaobingSuper added a commit that referenced this pull request Jan 18, 2021
@XiaobingSuper
enable mkldnn conv2d backward to support mkldnn tensor input
9634aaa 
ghstack-source-id: 8746ef4
Pull Request resolved: #48994
ngimel
ngimel reviewed Jan 25, 2021
View reviewed changes
XiaobingSuper added a commit that referenced this pull request Jan 27, 2021
@XiaobingSuper
enable mkldnn conv2d backward to support mkldnn tensor input
f8efdab 
ghstack-source-id: e1bb12a
Pull Request resolved: #48994
XiaobingSuper added a commit that referenced this pull request Jan 27, 2021
@XiaobingSuper
enable mkldnn conv2d backward to support mkldnn tensor input
8e30979 
ghstack-source-id: f267a03
Pull Request resolved: #48994
XiaobingSuper added a commit that referenced this pull request Jan 28, 2021
@XiaobingSuper
enable mkldnn conv2d backward to support mkldnn tensor input
8d330f4 
ghstack-source-id: a0089da
Pull Request resolved: #48994
@XiaobingSuper XiaobingSuper requested a review from ngimel January 29, 2021 00:52
ngimel
ngimel reviewed Jan 29, 2021
View reviewed changes
XiaobingSuper added a commit that referenced this pull request Jan 29, 2021
@XiaobingSuper
enable mkldnn conv2d backward to support mkldnn tensor input
a0764ea 
ghstack-source-id: 4e9235a
Pull Request resolved: #48994
@VitalyFedyunin
Copy link
Contributor

VitalyFedyunin commented Feb 2, 2021

Please rebase entire stack, I'm getting internal merge conflicts. thanks.

XiaobingSuper added a commit that referenced this pull request Feb 3, 2021
@XiaobingSuper
enable mkldnn conv2d backward to support mkldnn tensor input
a5a4fca 
ghstack-source-id: 466f87c
Pull Request resolved: #48994
@XiaobingSuper
Copy link
Collaborator Author

XiaobingSuper commented Feb 3, 2021

Please rebase entire stack, I'm getting internal merge conflicts. thanks.

Rebased, thanks.

XiaobingSuper added a commit that referenced this pull request Feb 5, 2021
@XiaobingSuper
enable mkldnn conv2d backward to support mkldnn tensor input
ae16bbe 
ghstack-source-id: 33e125d
Pull Request resolved: #48994
XiaobingSuper added a commit that referenced this pull request Feb 6, 2021
@XiaobingSuper
enable mkldnn conv2d backward to support mkldnn tensor input
480c47b 
ghstack-source-id: 80462cb
Pull Request resolved: #48994
@XiaobingSuper XiaobingSuper removed the request for review from soulitzer February 6, 2021 13:31
@facebook-github-bot
Copy link
Contributor

facebook-github-bot commented Feb 18, 2021

@VitalyFedyunin merged this pull request in 8f3ed60.

@facebook-github-bot facebook-github-bot deleted the gh/XiaobingSuper/4/head branch February 22, 2021 15:17
xsacha pushed a commit to xsacha/pytorch that referenced this pull request Mar 31, 2021
@XiaobingSuper
enable mkldnn conv2d backward to support mkldnn tensor input (pytorch…
47f728d 
…#48994)

Summary: Pull Request resolved: pytorch#48994

Test Plan: Imported from OSS

Reviewed By: ejguan

Differential Revision: D25537189

Pulled By: VitalyFedyunin

fbshipit-source-id: d81d247798fad3815b735468d66ef9d62c07ef77
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@albanD albanD albanD left review comments

@ngimel ngimel ngimel approved these changes

@VitalyFedyunin VitalyFedyunin Awaiting requested review from VitalyFedyunin

Assignees

No one assigned

Labels

cla signed Merged open source

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

8 participants

@XiaobingSuper @jgong5 @VitalyFedyunin @facebook-github-bot @albanD @ngimel @pytorchbot