[PyTorch] remove convenience RecordFunctionCallback interface#48620
Closed
swolchok wants to merge 6 commits intogh/swolchok/22/basefrom
Closed
[PyTorch] remove convenience RecordFunctionCallback interface#48620swolchok wants to merge 6 commits intogh/swolchok/22/basefrom
swolchok wants to merge 6 commits intogh/swolchok/22/basefrom
Conversation
In preparation for storing bare function pointer (8 bytes) instead of std::function (32 bytes). Differential Revision: [D25132183](https://our.internmc.facebook.com/intern/diff/D25132183/) **NOTE FOR REVIEWERS**: This PR has internal Facebook specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D25132183/)! [ghstack-poisoned]
facebook-github-bot
added
cla signed
oncall: jit
This was referenced Nov 30, 2020
💊 CI failures summary and remediationsAs of commit 2e54dd3 (more details on the Dr. CI page):
Extra GitHub checks: 1 failed
This comment was automatically generated by Dr. CI (expand for details).Follow this link to opt-out of these comments for your Pull Requests.Please report bugs/suggestions to the (internal) Dr. CI Users group. This comment has been revised 16 times. |
…enience RecordFunctionCallback interface" In preparation for storing bare function pointer (8 bytes) instead of std::function (32 bytes). Differential Revision: [D25132183](https://our.internmc.facebook.com/intern/diff/D25132183/) **NOTE FOR REVIEWERS**: This PR has internal Facebook specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D25132183/)! [ghstack-poisoned]
swolchok
added a commit
that referenced
this pull request
Nov 30, 2020
Pull Request resolved: #48620 In preparation for storing bare function pointer (8 bytes) instead of std::function (32 bytes). ghstack-source-id: 117499937 Differential Revision: [D25132183](https://our.internmc.facebook.com/intern/diff/D25132183/) **NOTE FOR REVIEWERS**: This PR has internal Facebook specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D25132183/)!
…ace" In preparation for storing bare function pointer (8 bytes) instead of std::function (32 bytes). Differential Revision: [D25132183](https://our.internmc.facebook.com/intern/diff/D25132183/) **NOTE FOR REVIEWERS**: This PR has internal Facebook specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D25132183/)! [ghstack-poisoned]
ezyang
approved these changes
Dec 8, 2020
Contributor
|
could you pls clarify the win here? it's not exactly a free win - this interface brings quite a lot of convenience to toss away without second thought |
…ace" In preparation for storing bare function pointer (8 bytes) instead of std::function (32 bytes). Differential Revision: [D25132183](https://our.internmc.facebook.com/intern/diff/D25132183/) **NOTE FOR REVIEWERS**: This PR has internal Facebook specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D25132183/)! [ghstack-poisoned]
Contributor
Author
|
There are benchmark results on the FB diff at the top of the stack.
…On Tue, Dec 8, 2020 at 3:29 PM ilia-cher ***@***.***> wrote:
could you pls clarify the win here? it's not exactly a free win - this
interface brings quite a lot of convenience to toss away without second
thought
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#48620 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAAIK6CQVZ7QMMVDG3LS5J3ST2ZHNANCNFSM4UIF2R2A>
.
|
…ace" In preparation for storing bare function pointer (8 bytes) instead of std::function (32 bytes). Differential Revision: [D25132183](https://our.internmc.facebook.com/intern/diff/D25132183/) **NOTE FOR REVIEWERS**: This PR has internal Facebook specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D25132183/)! [ghstack-poisoned]
…ace" In preparation for storing bare function pointer (8 bytes) instead of std::function (32 bytes). Differential Revision: [D25132183](https://our.internmc.facebook.com/intern/diff/D25132183/) **NOTE FOR REVIEWERS**: This PR has internal Facebook specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D25132183/)! [ghstack-poisoned]
Contributor
|
This pull request has been merged in 900aa4e. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stack from ghstack:
In preparation for storing bare function pointer (8 bytes)
instead of std::function (32 bytes).
Differential Revision: D25132183
NOTE FOR REVIEWERS: This PR has internal Facebook specific changes or comments, please review them on Phabricator!