[ROCm] Enable skipped distributed global tests #48023
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The PR pytorch#47898 fixes the global tests. Hence enabling the tests. Signed-off-by: Jagadish Krishnamoorthy <[email protected]>
jaglinux
requested review from
mrshenli,
pritamdamania87,
rohan-varma and
zhaojuanmao
as code owners
facebook-github-bot
added
cla signed
oncall: distributed
Contributor
Author
|
@jeffdaily @pruthvistony @KyleCZH please review. |
Collaborator
|
LGTM. Let's confirm with the ROCm CI results. |
rohan-varma
reviewed
Nov 16, 2020
Codecov Report
@@ Coverage Diff @@
## master #48023 +/- ##
==========================================
- Coverage 81.30% 81.14% -0.16%
==========================================
Files 1839 1839
Lines 198444 198440 -4
==========================================
- Hits 161342 161028 -314
- Misses 37102 37412 +310 |
gchanan
added
the
triaged
Contributor
Author
|
Sure, test_all_reduce_sum_cuda_async test was disabled as part of ROCm CI failure. |
Contributor
Author
|
@rohan-varma can you please approve the PR ? |
rohan-varma
approved these changes
Dec 4, 2020
Contributor
rohan-varma
left a comment
rohan-varma
left a comment
There was a problem hiding this comment.
Thanks for the ping, LGTM
Contributor
facebook-github-bot
left a comment
facebook-github-bot
left a comment
There was a problem hiding this comment.
@rohan-varma has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
Contributor
|
@rohan-varma merged this pull request in 03abd81. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The PR #47898 fixes the global tests. Hence enabling the tests.
Signed-off-by: Jagadish Krishnamoorthy [email protected]