[ONNX] Enable export af aten::__derive_index#48019
Closed
neginraoof wants to merge 7 commits intopytorch:masterfrom
Closed
[ONNX] Enable export af aten::__derive_index#48019neginraoof wants to merge 7 commits intopytorch:masterfrom
neginraoof wants to merge 7 commits intopytorch:masterfrom
Conversation
💊 CI failures summary and remediationsAs of commit 3a8e823 (more details on the Dr. CI page): ✅ None of the CI failures appear to be your fault 💚
1 failure confirmed as flaky and can be ignored:
❄️ 1 failure tentatively classified as flakybut reruns have not yet been triggered to confirm:
|
gchanan
added
the
triaged
jiafatom
reviewed
Nov 17, 2020
jiafatom
reviewed
Nov 21, 2020
| class MyModule(torch.nn.Module): | ||
| def forward(self, x: torch.Tensor): | ||
| j = [] | ||
| for idx in range(len(x) - 1, -len(x), -2): |
Contributor
There was a problem hiding this comment.
For constant start and end, would it trigger __range_length? If so, can we add unit test for constant start end to include the corner case there?
BowenBao
reviewed
Nov 23, 2020
| return g.op("Add", start, g.op("Mul", index, step)) | ||
|
|
||
|
|
||
| def __range_length(g, lo, hi, step): |
Collaborator
There was a problem hiding this comment.
Consider adding link to source in comment, and copying the code of computation as well for reference.
if (step > 0 && lo < hi) {
push(stack, 1 + (hi - 1 - lo) / step);
} else if (step < 0 && lo > hi) {
push(stack, 1 + (lo - 1 - hi) / (0 - step));
} else {
push(stack, 0);
}The current symbolic should be equivalent with the positive case, is it also equivalent with the case when (hi-lo) and step are both negative?
Contributor
Author
There was a problem hiding this comment.
This is covered in tests for:
for idx in range(len(x) - 1, -len(x), -2):
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Enable export af aten::__derive_index