Enable complex tests that depend on batched matmul on CUDA #47910
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
IvanYashchuk
added
the
module: complex
💊 CI failures summary and remediationsAs of commit 95475fa (more details on the Dr. CI page): 💚 💚 Looks good so far! There are no failures yet. 💚 💚 This comment was automatically generated by Dr. CI (expand for details).Follow this link to opt-out of these comments for your Pull Requests.Please report bugs/suggestions on the GitHub issue tracker or post in the (internal) Dr. CI Users group. This comment has been revised 15 times. |
smessmer
added
the
triaged
Collaborator
Author
|
|
Codecov Report
@@ Coverage Diff @@
## master #47910 +/- ##
==========================================
- Coverage 81.32% 81.17% -0.16%
==========================================
Files 1839 1839
Lines 198601 198601
==========================================
- Hits 161522 161218 -304
- Misses 37079 37383 +304 |
mruberry
approved these changes
Nov 18, 2020
Collaborator
mruberry
left a comment
mruberry
left a comment
There was a problem hiding this comment.
Cool! Thanks @IvanYashchuk. It's great to see these "Better Engineering" PRs!
Contributor
facebook-github-bot
left a comment
facebook-github-bot
left a comment
There was a problem hiding this comment.
@mruberry has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
Contributor
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now when #42553 is merged we can delete a bit of code from the tests and enable some of the skipped complex tests.
Unfortunately,
test_pinverse_complex_xfailedandtest_symeig_complex_xfailedhad bugs and it wasn't caught automatically that these tests xpass. Need to be careful next time withunittest.expectedFailure.