Update minimum supported Python version to 3.6.2#47314
Closed
malfet wants to merge 1 commit intopytorch:masterfrom
Closed
Update minimum supported Python version to 3.6.2#47314malfet wants to merge 1 commit intopytorch:masterfrom
malfet wants to merge 1 commit intopytorch:masterfrom
Conversation
As typing.NoReturn is used in the codebase
seemethere
approved these changes
Nov 3, 2020
Contributor
facebook-github-bot
left a comment
facebook-github-bot
left a comment
There was a problem hiding this comment.
@malfet has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
Contributor
💊 CI failures summary and remediationsAs of commit a34f567 (more details on the Dr. CI page): ✅ None of the CI failures appear to be your fault 💚
🚧 1 ongoing upstream failure:These were probably caused by upstream breakages that are not fixed yet:
This comment was automatically generated by Dr. CI (expand for details).Follow this link to opt-out of these comments for your Pull Requests.Please report bugs/suggestions on the GitHub issue tracker or post in the (internal) Dr. CI Users group. This comment has been revised 2 times. |
seemethere
pushed a commit
to seemethere/pytorch
that referenced
this pull request
Nov 18, 2020
Summary: As typing.NoReturn is used in the codebase Pull Request resolved: pytorch#47314 Reviewed By: seemethere Differential Revision: D24712847 Pulled By: malfet fbshipit-source-id: f0692d408316d630bc11f1ee881b695437fb47d4 (cherry picked from commit ca61b06) Signed-off-by: Eli Uriegas <[email protected]>
This was referenced Nov 18, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As typing.NoReturn is used in the codebase