Skip to content

Conversation

@RockingJavaBean
Copy link
Contributor

@RockingJavaBean RockingJavaBean commented Oct 30, 2020

Related #45259

This PR is to address the #45259 (comment)

  • leverage the make_tensor function to generate a random tensor as the exponent, preventing the full zeros for the integer exponent.
  • add some special cases for the zero exponents and the 1 + 0j base.

@RockingJavaBean RockingJavaBean changed the title [WIP] Enhance the test cases for the complex scalar base of torch.pow [WIP] Enhance the test cases for torch.pow when the scalar base is a complex number Oct 30, 2020
@RockingJavaBean RockingJavaBean changed the title [WIP] Enhance the test cases for torch.pow when the scalar base is a complex number [WIP] Enhance the torch.pow testcase for the complex scalar base Oct 30, 2020
@codecov
Copy link

codecov bot commented Oct 30, 2020

Codecov Report

Merging #47101 into master will decrease coverage by 0.11%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master   #47101      +/-   ##
==========================================
- Coverage   60.81%   60.70%   -0.12%     
==========================================
  Files        2748     2748              
  Lines      254027   254027              
==========================================
- Hits       154488   154198     -290     
- Misses      99539    99829     +290     

@RockingJavaBean RockingJavaBean changed the title [WIP] Enhance the torch.pow testcase for the complex scalar base Enhance the torch.pow testcase for the complex scalar base Oct 30, 2020
@ngimel ngimel requested a review from zou3519 October 30, 2020 19:20
@ngimel ngimel added the triaged This issue has been looked at a team member, and triaged and prioritized into an appropriate module label Oct 30, 2020
Copy link
Contributor

@facebook-github-bot facebook-github-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@zou3519 has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

@facebook-github-bot
Copy link
Contributor

@zou3519 merged this pull request in 22b3d41.

1 similar comment
@facebook-github-bot
Copy link
Contributor

@zou3519 merged this pull request in 22b3d41.

@RockingJavaBean RockingJavaBean deleted the improve_complex_scalar_base_testcases branch December 22, 2020 01:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cla signed Merged open source triaged This issue has been looked at a team member, and triaged and prioritized into an appropriate module

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants