Skip to content

Conversation

@albanD
Copy link
Collaborator

@albanD albanD commented Oct 27, 2020

This behavior was changed by side effect by #41984
Update the doc to reflect the actual behavior of the function.

@albanD albanD requested review from gchanan and mruberry October 27, 2020 19:37
@albanD albanD requested a review from apaszke as a code owner October 27, 2020 19:37
@albanD albanD force-pushed the pack_padded_seq_doc branch from 564f233 to 3407d55 Compare October 27, 2020 20:21
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"sequences" -> "sequence"

"if provided as a Tensor" -> "if provided as a tensor" (tensor is lowercase when used in descriptions in the docs)

Copy link
Collaborator

@mruberry mruberry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool fix!

@codecov
Copy link

codecov bot commented Oct 27, 2020

Codecov Report

Merging #46937 into master will decrease coverage by 12.38%.
The diff coverage is n/a.

@@             Coverage Diff             @@
##           master   #46937       +/-   ##
===========================================
- Coverage   60.81%   48.43%   -12.39%     
===========================================
  Files        2748     2735       -13     
  Lines      254027   252151     -1876     
===========================================
- Hits       154489   122125    -32364     
- Misses      99538   130026    +30488     

Copy link
Contributor

@facebook-github-bot facebook-github-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@albanD has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

@dr-ci
Copy link

dr-ci bot commented Nov 2, 2020

💊 CI failures summary and remediations

As of commit d02adda (more details on the Dr. CI page):


  • 1/1 failures possibly* introduced in this PR
    • 1/1 non-CircleCI failure(s)

codecov.io: 1 failed


This comment was automatically generated by Dr. CI (expand for details).Follow this link to opt-out of these comments for your Pull Requests.

Please report bugs/suggestions on the GitHub issue tracker or post in the (internal) Dr. CI Users group.

See how this bot performed.

This comment has been revised 4 times.

@albanD albanD force-pushed the pack_padded_seq_doc branch from 950fedb to d02adda Compare November 2, 2020 16:31
Copy link
Contributor

@facebook-github-bot facebook-github-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@albanD has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

@facebook-github-bot
Copy link
Contributor

@albanD merged this pull request in 9c3a755.

@albanD albanD changed the title Update doc to reflect current behavior Update doc to reflect current behavior of pack_padded_sequences Feb 25, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants