-
Notifications
You must be signed in to change notification settings - Fork 26.3k
Update doc to reflect current behavior of pack_padded_sequences #46937
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
564f233 to
3407d55
Compare
torch/nn/utils/rnn.py
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"sequences" -> "sequence"
"if provided as a Tensor" -> "if provided as a tensor" (tensor is lowercase when used in descriptions in the docs)
mruberry
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Cool fix!
Codecov Report
@@ Coverage Diff @@
## master #46937 +/- ##
===========================================
- Coverage 60.81% 48.43% -12.39%
===========================================
Files 2748 2735 -13
Lines 254027 252151 -1876
===========================================
- Hits 154489 122125 -32364
- Misses 99538 130026 +30488 |
facebook-github-bot
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@albanD has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
💊 CI failures summary and remediationsAs of commit d02adda (more details on the Dr. CI page):
codecov.io: 1 failed
This comment was automatically generated by Dr. CI (expand for details).Follow this link to opt-out of these comments for your Pull Requests.Please report bugs/suggestions on the GitHub issue tracker or post in the (internal) Dr. CI Users group. This comment has been revised 4 times. |
950fedb to
d02adda
Compare
facebook-github-bot
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@albanD has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
This behavior was changed by side effect by #41984
Update the doc to reflect the actual behavior of the function.