Added support for complex input for torch.lu_solve #46862
Conversation
IvanYashchuk
added
module: complex
facebook-github-bot
left a comment
facebook-github-bot
left a comment
There was a problem hiding this comment.
@anjali411 has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
💊 CI failures summary and remediationsAs of commit 10fe454 (more details on the Dr. CI page):
ci.pytorch.org: 1 failedThis comment was automatically generated by Dr. CI (expand for details).Follow this link to opt-out of these comments for your Pull Requests.Please report bugs/suggestions on the GitHub issue tracker or post in the (internal) Dr. CI Users group. This comment has been revised 15 times. |
|
Hm, probably I didn't notice that I compiled without cuda and some tests were skipped. I'll fix those failing test cases. |
Codecov Report
@@ Coverage Diff @@
## master #46862 +/- ##
==========================================
- Coverage 81.23% 81.22% -0.01%
==========================================
Files 1837 1837
Lines 198089 198089
==========================================
- Hits 160913 160906 -7
- Misses 37176 37183 +7 |
|
Hi @IvanYashchuk! Thank you for your pull request. We require contributors to sign our Contributor License Agreement, and yours needs attention. You currently have a record in our system, but we do not have a signature on file. In order for us to review and merge your code, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA. If you have received this in error or have any questions, please contact us at [email protected]. Thanks! |
anjali411
left a comment
anjali411
left a comment
There was a problem hiding this comment.
lgtm thank you @IvanYashchuk
facebook-github-bot
left a comment
facebook-github-bot
left a comment
There was a problem hiding this comment.
@anjali411 has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
|
@anjali411 merged this pull request in ffd0003. |
|
This broke our CUDA tests: https://app.circleci.com/pipelines/github/pytorch/pytorch/238913/workflows/a3910c0f-451f-4635-969b-2a9562beabcb/jobs/8915827. The fix is probably not too hard (it looks like the |
Summary: `torch.lu_solve` now works for complex inputs both on CPU and GPU. I moved the existing tests to `test_linalg.py` and modified them to test complex dtypes, but I didn't modify/improve the body of the tests. Ref. pytorch#33152 Pull Request resolved: pytorch#46862 Reviewed By: nikithamalgifb Differential Revision: D24543682 Pulled By: anjali411 fbshipit-source-id: 165bde39ef95cafebf976c5ba4b487297efe8433
Summary: Relanding #46862 There was an issue with the simultaneous merge of two slightly conflicting PRs. This PR adds `torch.lu_solve` for complex inputs both on CPU and GPU. Pull Request resolved: #48028 Reviewed By: linbinyu Differential Revision: D25003700 Pulled By: zou3519 fbshipit-source-id: 24cd1babe9ccdbaa4e2ed23f08a9153d40d0f0cd
…#48028) Summary: Relanding pytorch#46862 There was an issue with the simultaneous merge of two slightly conflicting PRs. This PR adds `torch.lu_solve` for complex inputs both on CPU and GPU. Pull Request resolved: pytorch#48028 Reviewed By: linbinyu Differential Revision: D25003700 Pulled By: zou3519 fbshipit-source-id: 24cd1babe9ccdbaa4e2ed23f08a9153d40d0f0cd
5 participants
torch.lu_solvenow works for complex inputs both on CPU and GPU.I moved the existing tests to
test_linalg.pyand modified them to test complex dtypes, but I didn't modify/improve the body of the tests.Ref. #33152