💊 CI failures summary and remediations

As of commit 7374a75 (more details on the Dr. CI page):

• 3/3 failures introduced in this PR

🕵️ 3 new failures recognized by patterns

The following CI failures do not appear to be due to upstream breakages:

pytorch_linux_xenial_cuda9_2_cudnn7_py3_gcc5_4_build (1/3)

Step: "(Optional) Merge target branch" (full log | diagnosis details | 🔁 rerun)

CONFLICT (add/add): Merge conflict in .circleci/docker/centos-rocm/Dockerfile 
Auto-merging .circleci/docker/centos-rocm/Dockerfile 
CONFLICT (add/add): Merge conflict in .circleci/config.yml 
Auto-merging .circleci/config.yml 
CONFLICT (add/add): Merge conflict in .circleci/cimodel/data/pytorch_build_definitions.py 
Auto-merging .circleci/cimodel/data/pytorch_build_definitions.py 
CONFLICT (add/add): Merge conflict in .circleci/cimodel/data/pytorch_build_data.py 
Auto-merging .circleci/cimodel/data/pytorch_build_data.py 
CONFLICT (add/add): Merge conflict in .circleci/cimodel/data/dimensions.py 
Auto-merging .circleci/cimodel/data/dimensions.py 
Automatic merge failed; fix conflicts and then commit the result. 

pytorch_xla_linux_bionic_py3_6_clang9_build (2/3)

Step: "(Optional) Merge target branch" (full log | diagnosis details | 🔁 rerun)

CONFLICT (add/add): Merge conflict in .circleci/docker/centos-rocm/Dockerfile 
Auto-merging .circleci/docker/centos-rocm/Dockerfile 
CONFLICT (add/add): Merge conflict in .circleci/config.yml 
Auto-merging .circleci/config.yml 
CONFLICT (add/add): Merge conflict in .circleci/cimodel/data/pytorch_build_definitions.py 
Auto-merging .circleci/cimodel/data/pytorch_build_definitions.py 
CONFLICT (add/add): Merge conflict in .circleci/cimodel/data/pytorch_build_data.py 
Auto-merging .circleci/cimodel/data/pytorch_build_data.py 
CONFLICT (add/add): Merge conflict in .circleci/cimodel/data/dimensions.py 
Auto-merging .circleci/cimodel/data/dimensions.py 
Automatic merge failed; fix conflicts and then commit the result. 

pytorch_linux_xenial_py3_6_gcc5_4_build (3/3)

Step: "(Optional) Merge target branch" (full log | diagnosis details | 🔁 rerun)

CONFLICT (add/add): Merge conflict in .circleci/docker/centos-rocm/Dockerfile 
Auto-merging .circleci/docker/centos-rocm/Dockerfile 
CONFLICT (add/add): Merge conflict in .circleci/config.yml 
Auto-merging .circleci/config.yml 
CONFLICT (add/add): Merge conflict in .circleci/cimodel/data/pytorch_build_definitions.py 
Auto-merging .circleci/cimodel/data/pytorch_build_definitions.py 
CONFLICT (add/add): Merge conflict in .circleci/cimodel/data/pytorch_build_data.py 
Auto-merging .circleci/cimodel/data/pytorch_build_data.py 
CONFLICT (add/add): Merge conflict in .circleci/cimodel/data/dimensions.py 
Auto-merging .circleci/cimodel/data/dimensions.py 
Automatic merge failed; fix conflicts and then commit the result. 

Hi @jsrozner!

Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file.

In order for us to review and merge your code, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

If you have received this in error or have any questions, please contact us at [email protected]. Thanks!

I updated the docstring in the local file (function level comments). Do I also need to edit somewhere else or recompile docstrings?

As mentioned in comment, the docstring will automatically regenerate the doc on master. :)

Also, though I didn't change any types here, how is typing (for IDE type checking) documentation generated / used)?

Since this is just updating the warning and the documentation, there is no need update the typing.

Also, though I didn't change any types here, how is typing (for IDE type checking) documentation generated / used)?

Since this is just updating the warning and the documentation, there is no need update the typing.

Yes, agreed. But I was curious how the pytorch library handles typing since it is not inlined in, e.g., these function definitions

Is anything else needed by me to finish this pull request?

Also, though I didn't change any types here, how is typing (for IDE type checking) documentation generated / used)?

Since this is just updating the warning and the documentation, there is no need update the typing.

Yes, agreed. But I was curious how the pytorch library handles typing since it is not inlined in, e.g., these function definitions

We are migrating to inline, but the types are in *.pyi files adjacent :)

Is anything else needed by me to finish this pull request?

Thanks for signing and writing the pull request, this is good to go :)

@vincentqb
Can we merge?

@vincentqb merged this pull request in 42e6951.

That broke transformers where it's used:
https://github.com/huggingface/transformers/blob/aa0969c2f3cf5cf7ce5690e7b77f95b1622988d6/src/transformers/trainer_pt_utils.py#L37

But reading why it was done (goodness), transformers will just need to recode for this change.

Not sure how one could deprecate a constant...