Do not rebase select nighly builds on top of master #46038
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
malfet
force-pushed
the
malfet/do-not-rebase-nightly
branch
from
6084bbd to
9ff9c2f
Compare
Contributor
facebook-github-bot
left a comment
facebook-github-bot
left a comment
There was a problem hiding this comment.
@malfet has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
seemethere
approved these changes
Oct 8, 2020
Codecov Report
@@ Coverage Diff @@
## master #46038 +/- ##
=======================================
Coverage 68.28% 68.28%
=======================================
Files 410 410
Lines 53306 53306
=======================================
Hits 36398 36398
Misses 16908 16908 Continue to review full report at Codecov.
|
Contributor
This was referenced Mar 9, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prevents the following nightly failures from happening:
https://app.circleci.com/pipelines/github/pytorch/pytorch/224752/workflows/3a01ccc2-0215-4e95-9222-bbb4f9309201/jobs/8084912