Only populate grad accumulator to var mapping for find_unused_parameters=True in DDP#45942
Closed
rohan-varma wants to merge 5 commits intogh/rohan-varma/181/basefrom
Closed
Only populate grad accumulator to var mapping for find_unused_parameters=True in DDP#45942rohan-varma wants to merge 5 commits intogh/rohan-varma/181/basefrom
rohan-varma wants to merge 5 commits intogh/rohan-varma/181/basefrom
Conversation
…ers=True in DDP We only need to keep track of this for traversing the autograd graph when find_unused_parameters=True. Without that, we populate and keep this mapping in memory, which occupies sizeof(pointer) * number of grad accumulators of extra memory. Differential Revision: [D24154407](https://our.internmc.facebook.com/intern/diff/D24154407/) [ghstack-poisoned]
rohan-varma
requested review from
mingzhe09088,
mrshenli,
pietern,
pritamdamania87 and
zhaojuanmao
as code owners
facebook-github-bot
added
the
oncall: distributed
rohan-varma
added a commit
that referenced
this pull request
Oct 7, 2020
…ers=True in DDP We only need to keep track of this for traversing the autograd graph when find_unused_parameters=True. Without that, we populate and keep this mapping in memory, which occupies sizeof(pointer) * number of grad accumulators of extra memory. Differential Revision: [D24154407](https://our.internmc.facebook.com/intern/diff/D24154407/) ghstack-source-id: 113723598 Pull Request resolved: #45942
mrshenli
approved these changes
Oct 7, 2020
…sed_parameters=True in DDP" We only need to keep track of this for traversing the autograd graph when find_unused_parameters=True. Without that, we populate and keep this mapping in memory, which occupies sizeof(pointer) * number of grad accumulators of extra memory. Also renames the variable to something more meaningful. Differential Revision: [D24154407](https://our.internmc.facebook.com/intern/diff/D24154407/) [ghstack-poisoned]
…sed_parameters=True in DDP" We only need to keep track of this for traversing the autograd graph when find_unused_parameters=True. Without that, we populate and keep this mapping in memory, which occupies sizeof(pointer) * number of grad accumulators of extra memory. Also renames the variable to something more meaningful. Differential Revision: [D24154407](https://our.internmc.facebook.com/intern/diff/D24154407/) [ghstack-poisoned]
Codecov Report
@@ Coverage Diff @@
## gh/rohan-varma/181/base #45942 +/- ##
==========================================================
Coverage ? 68.28%
==========================================================
Files ? 410
Lines ? 53609
Branches ? 0
==========================================================
Hits ? 36608
Misses ? 17001
Partials ? 0 Continue to review full report at Codecov.
|
…sed_parameters=True in DDP" We only need to keep track of this for traversing the autograd graph when find_unused_parameters=True. Without that, we populate and keep this mapping in memory, which occupies sizeof(pointer) * number of grad accumulators of extra memory. Also renames the variable to something more meaningful. Differential Revision: [D24154407](https://our.internmc.facebook.com/intern/diff/D24154407/) [ghstack-poisoned]
…sed_parameters=True in DDP" We only need to keep track of this for traversing the autograd graph when find_unused_parameters=True. Without that, we populate and keep this mapping in memory, which occupies sizeof(pointer) * number of grad accumulators of extra memory. Also renames the variable to something more meaningful. Differential Revision: [D24154407](https://our.internmc.facebook.com/intern/diff/D24154407/) [ghstack-poisoned]
Contributor
|
This pull request has been merged in f739875. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stack from ghstack:
We only need to keep track of this for traversing the autograd graph
when find_unused_parameters=True. Without that, we populate and keep this
mapping in memory, which occupies sizeof(pointer) * number of grad accumulators
of extra memory.
Also renames the variable to something more meaningful.
Differential Revision: D24154407